Jens Luetjen
606e87b1bb
Make export/restore state internal
...
- drop filename parameter
- make save_state/load_state internal
- remove save_state/load_state from docu and RPC.
- remove models load/save from docu
- build the config path
- folder for 'core' state files
- move restore_state-to-coverage-translation into a method
2016-01-14 19:56:38 +01:00
Jens Luetjen
4869619bb9
New CoreState to hold all core states
...
- Introduce a CoreState class that holds all core states
- Move xState classes to internal
- Use validation.check_instance for consistent error messages
- Store tlid instead of TlTrack to restore last played track
2016-01-10 13:24:14 +01:00
Jens Luetjen
74344f2b19
Use tlid instead of full tl_track
...
To export/restore the PlayState the tlid is enough.
2016-01-09 12:52:01 +01:00
Jens Luetjen
46bb780a46
Rename TracklistState 'tracks' to 'tl_tracks'
...
Correct documentation.
2016-01-09 11:46:09 +01:00
Jens Luetjen
0b0cbc87d4
Merge branch 'develop' into fix/310-persist-mopidy-state-between-runs
...
Conflicts:
docs/changelog.rst
Fixed conflict in doc/changelog.rst
2016-01-05 08:16:51 +01:00
Jens Luetjen
d5a45516ef
Adujst test code for testing auto-play
2016-01-05 07:53:45 +01:00
Jens Luetjen
e56c39ee78
Add unit tests for export/restore core state
...
Fix issues shown by test code
2016-01-03 18:29:35 +01:00
Stein Magnus Jodal
4fba994441
Merge pull request #1377 from jcass77/test/pr_1356_resume_unplayable_track
...
test: Test case for skipping unplayable tracks when paused.
2015-12-29 08:53:12 +01:00
jcass
07a0f8ff3e
test: Test case to ensure that unplayable tracks are skipped over in PAUSE state.
...
Ensures that pause->next->resume handles unplayable tracks just like stop->next->play does.
2015-12-29 07:54:49 +02:00
Thomas Kemmer
ef1468d8d6
core: Add PlaylistsController.get_uri_schemes().
2015-12-13 19:02:33 +01:00
Thomas Adamcik
9f23757cc3
core: Return pending position during active seek.
...
This covers over that audio will fail query position while a seek is in
progress. It also means that instead of returning zero we at least return
something which is much closer to the time that we will soon end up playing
from.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
454077afeb
core: Make sure certain events are ignored when doing eot-seeks
2015-12-04 21:10:48 +01:00
Thomas Adamcik
aeb881896b
core: Trigger position changed from audio events.
...
Makes sure to only fire when the position changed to our intended seek target.
Otherwise we would also be triggering this when playback starts.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
e74eafb38a
core: Switch back to correct track if seek happens before stream changed
...
Technically the seek still needs to be postponed for this to work right, but
it's a step closer.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
3a57a5792b
core: Make sure we always emit state_changed between tracks
...
Gapless broke this, so this change makes sure that next/prev/play and gapless
track changes all correctly emit events.
Note that this only ensures we get PLAYING -> PLAYING events. Not the old
STOPPED -> PLAYING and then PLAYING -> STOPPED.
2015-11-21 22:43:40 +01:00
Thomas Adamcik
216bd8e412
tests: Reorder listener_mock.send.mock_calls in assertEqual
2015-11-21 14:28:47 +01:00
Thomas Adamcik
da7ec9b202
core: Cleanup track ended event handling
...
Trigger playback ended on:
- stream changed
- EOS
- stop via stream changed events
Old behavior was to manually trigger on:
- next
- prev
- play with other track and old state != STOPPED
- stop
2015-11-19 22:45:55 +01:00
Stein Magnus Jodal
0c059b85b1
compat: Replace (int, long) with compat.integer_types
2015-10-29 22:21:48 +01:00
Thomas Adamcik
0169ce7cad
core: Make sure the about-to-finish callback gets run in the actor.
...
When about to finish gets called we are running in some GStreamer thread. Our
audio code then calls the shim core callback which is responsible for
transferring our execution to the core actor thread and waiting for the
response. From this point we do normal actor calls to the backend(s) which in
turn call into the audio actor. Since the initial audio code that was called is
outside the actor this should never deadlock due to this loop.
2015-10-06 22:45:06 +02:00
Thomas Adamcik
1ca548ece7
core: Fix typos in comments
2015-10-05 21:41:15 +02:00
Thomas Adamcik
7f4e77f36f
core: Update to using _change in play and fix playback ended event
2015-09-16 23:44:36 +02:00
Thomas Adamcik
592b728e32
core: Refactor previous() to use pending_track for state changes
2015-09-04 17:16:39 +02:00
Thomas Adamcik
2cd9903a54
core: Refactor next() to use pending_track for state changes
2015-09-04 16:08:54 +02:00
Thomas Adamcik
e12ea662da
Merge branch 'develop' into feature/implement-gapless
2015-09-02 21:03:17 +02:00
Stein Magnus Jodal
c48b6515f9
core: library.refresh() should check if backend has library
...
...and not playlists.
Fixes #1257
2015-08-23 00:35:54 +02:00
Stein Magnus Jodal
9f08bce6cd
core: Update test
2015-08-11 10:06:58 +02:00
Bjørnar Snoksrud
1eb41aca7d
tests: fix test breakage due to promotion from int to long
...
This fixes #1240 .
In internals/path.py. there is a snippet of code that multiples mtime
for a file with 1000, and then casting it to `int`, to return the number
of milliseconds since epoch (or whatever). This will, however, not
ensure that the result is an `int`.
>>> type(int(2**32))
<type 'long'>
Instead, fix the tests to look for (int, long), and clarify the
implementation.
This bug found on a 32-bit VM :)
2015-08-05 22:38:21 +02:00
Thomas Adamcik
ee68a0a9da
Merge pull request #1238 from dbrgn/feature/996-playlist-delete-event
...
core: Implemented playlist_deleted event triggering
2015-07-26 12:12:23 +02:00
Danilo Bargen
8975e72b34
Implemented playlist_deleted event
2015-07-26 11:57:17 +02:00
Stein Magnus Jodal
a83d9836f9
core: Update test mock
2015-07-25 14:47:00 +02:00
Thomas Adamcik
3fe9f7b3a7
Merge branch 'develop' into feature/implement-gapless
...
Conflicts:
mopidy/commands.py
mopidy/core/playback.py
tests/core/test_playback.py
tests/local/test_playback.py
2015-07-22 20:00:46 +02:00
Stein Magnus Jodal
0ebfeb5a5b
core: Normalize negative seek positions
...
This reverts a change between 1.0 and 1.1, so no changelog.
Fixes #1180
2015-07-22 12:15:38 +02:00
Ronald Zielaznicki
82ed660777
Add core config values to relevent test cases.
2015-07-19 23:05:39 -04:00
Stein Magnus Jodal
749c8baceb
Merge branch 'v1.0.x' into develop
...
Conflicts:
mopidy/core/library.py
tests/core/test_playback.py
2015-06-25 23:15:35 +02:00
Thomas Adamcik
1d636ce59e
core: Make sure track gets changed while paused
2015-05-20 23:26:55 +02:00
Stein Magnus Jodal
d8bcd7f273
Rename mopidy.utils to mopidy.internal
2015-05-07 23:15:56 +02:00
Thomas Adamcik
af4e7c8a4e
Merge branch 'develop' into feature/core-dont-trust-backends
...
Conflicts:
docs/changelog.rst
2015-05-07 00:15:33 +02:00
Thomas Adamcik
29c66f7bc8
core: Correct volume/mute return values
2015-05-07 00:13:58 +02:00
Thomas Adamcik
4d608dd431
core: Add get_current_tlid shortcut
2015-05-06 23:00:53 +02:00
Thomas Adamcik
cfd4dcb8dd
Merge branch 'develop' into feature/core-dont-trust-backends
...
Note that this merge also updated core.playlists.create to combine the 1.0.5
fix with these changes.
Conflicts:
mopidy/core/playlists.py
2015-05-06 22:44:12 +02:00
Thomas Adamcik
c01f8679bc
core: Address review comments for do not trust backends PR
2015-05-06 22:34:44 +02:00
Stein Magnus Jodal
6d82cdb611
tests: Cleanup reset_mock() usage
2015-05-06 21:06:30 +02:00
Stein Magnus Jodal
a17c413a70
Merge branch v1.0.x into develop
2015-05-06 20:47:52 +02:00
Thomas Kemmer
636639a201
Fix #1162 : Ignore None results and exceptions from PlaylistsProvider.create().
2015-05-06 14:50:21 +02:00
Thomas Adamcik
4aa984207b
tests: Split up core bad backend tests and unify naming
2015-05-06 01:01:12 +02:00
Thomas Adamcik
e7b241e18b
core: Update playlists to handle bad data from backends and exceptions
2015-05-06 00:28:58 +02:00
Thomas Adamcik
3426633c78
core: Make sure we handle bad mixer data and exceptions.
2015-05-05 23:41:46 +02:00
Thomas Adamcik
dd4a8f3b78
core: Make sure library can handle bad data from backends
...
Note that None values are just ignored, while other bad data logs an error
message and is ignored.
2015-05-05 22:55:53 +02:00
Thomas Adamcik
a62293c316
core: Add play(tlid) support
2015-04-22 20:55:51 +02:00
Thomas Adamcik
fba4069cfd
core: Make index return current index when missing args
2015-04-19 00:22:52 +02:00