Commit Graph

48 Commits

Author SHA1 Message Date
Stein Magnus Jodal
242df28114 mpd: Support search by date (#272) 2012-12-20 21:34:06 +01:00
Stein Magnus Jodal
08f0178425 mpd: Extract query translators for direct testing 2012-12-20 00:46:35 +01:00
Stein Magnus Jodal
0f603c3ede Use urllib.{quote,unquote} instead of {pathname2url,url2pathname} 2012-12-12 23:13:52 +01:00
Stein Magnus Jodal
e9eac16284 mpd: Use relative urlencoded paths in tag cache
This partly reverts "beac2e8 mpd: Use file:// URIs in tag_cache" by removing
the "file://" URI scheme and the music dir base path from the "file:" fields in
the tag cache.

The advantage is that the tag cache becomes independent of the music dir
location and the tag cache loader can be made compatible with both old and new
tag caches.
2012-12-12 15:10:28 +01:00
Stein Magnus Jodal
6311e13cec mpd: urlencode any non-UTF-8 path so it can be displayed as UTF-8 2012-12-12 14:21:30 +01:00
Stein Magnus Jodal
a006918453 mpd: Use bytestrings in dir tree building 2012-12-12 13:45:37 +01:00
Stein Magnus Jodal
beac2e80ed mpd: Use file:// URIs in tag_cache
file:// URIs are uriencoded, and will thus conserve the encoding of the file
paths. We cannot just convert file paths in other encodings to UTF-8, because
then we won't find the files we point to.
2012-12-11 10:29:43 +01:00
Stein Magnus Jodal
bba9548b27 Rename 'current playlist' to 'tracklist' 2012-11-13 10:59:48 +01:00
Stein Magnus Jodal
6acaa490e9 Make all strings unicode by default (fixes #224) 2012-11-13 00:18:47 +01:00
Stein Magnus Jodal
666800ec57 Fix most flake8 warnings (#211) 2012-10-16 14:00:34 +02:00
Stein Magnus Jodal
6f6e2c7fd7 Let track{,s}_to_mpd_format() understand CpTrack objects
Thus the cpid and cpids kwargs can be removed, and lots of code doing
formatting of MPD responses can be simplified. This also reduces the
need for making full copies of the current playlist, which improves
performance.
2011-12-28 00:31:27 +01:00
Stein Magnus Jodal
9499250a7f Remove Album._artists workaround 2011-04-06 17:51:36 +02:00
Martins Grunskis
159831c6e7 mopidy-scan fails if track has no artist name
stack trace:

    Traceback (most recent call last):
      File ./scan, line 27, in <module>
        for a in tracks_to_tag_cache_format(tracks):
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 138, in tracks_to_tag_cache_format
        _add_to_tag_cache(result, *tracks_to_directory_tree(tracks))
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 151, in _add_to_tag_cache
        _add_to_tag_cache(result, *entry)
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 156, in _add_to_tag_cache
        track_result = dict(track_to_mpd_format(track))
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 28, in track_to_mpd_format
        ('Artist', artists_to_mpd_format(track.artists)),
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 88, in artists_to_mpd_format
        return u', '.join([a.name for a in artists if a])
    TypeError: sequence item 0: expected string or Unicode, NoneType found
2011-02-09 18:48:15 +02:00
Stein Magnus Jodal
1ed29a4b9a Fix pylint warnings 2010-11-03 00:11:46 +01:00
Stein Magnus Jodal
2941c83bb8 Merge remote branch 'adamcik/feature/musicbrainz-id-support' into develop 2010-11-03 00:08:32 +01:00
Stein Magnus Jodal
6a8998a5c3 Fix pylint warnings 2010-11-02 23:42:02 +01:00
Thomas Adamcik
37222d66f5 Add albumartistid to frontent 2010-11-02 01:00:11 +01:00
Thomas Adamcik
31933c2c2f Fix musicbrainz support in mpd format track 2010-11-02 00:43:03 +01:00
Thomas Adamcik
dd25fadd8b Track result should contain key 2010-11-01 23:23:59 +01:00
Thomas Adamcik
8bfa7d2937 Update tag cache code so it adds mtime and file that is relative 2010-11-01 23:16:49 +01:00
Thomas Adamcik
4ac1d8d217 Remove mtime and key from track_to_mpd_format 2010-11-01 23:09:21 +01:00
Thomas Adamcik
fe309d374e Get rid of all kinds of abspath and expandpath usage that is no longer needed 2010-11-01 00:37:55 +01:00
Thomas Adamcik
c513d0f6e7 Rename settings that have dirs or file to _PATH and _FILE 2010-11-01 00:37:55 +01:00
Thomas Adamcik
7767dd1ae4 Better unicode handling for scan code 2010-10-30 23:35:04 +02:00
Thomas Adamcik
52c61634f5 Add doc that explains why on earth order_mpd_track_info is used 2010-10-30 21:57:33 +02:00
Thomas Adamcik
357591e97e Introduce concept of mpd ordered track info for simpler diffing of tag caches 2010-10-30 21:53:59 +02:00
Thomas Adamcik
9309b5bd7d Handle folders correctly _add_to_tag_cache 2010-10-30 21:35:31 +02:00
Thomas Adamcik
f0619744ed Fix tracks to direcotory dir handling 2010-10-30 21:26:53 +02:00
Thomas Adamcik
b9976c4cda Remove uri_to_mpd_relative_path 2010-10-30 21:26:08 +02:00
Thomas Adamcik
d67bfb9aee Use new mtime helper 2010-10-30 20:58:41 +02:00
Thomas Adamcik
9a99bc46bf Add album artist to track to mpd format 2010-10-30 20:46:47 +02:00
Thomas Adamcik
e6cdb88881 Remove print statement 2010-10-30 20:42:34 +02:00
Thomas Adamcik
6049c7a094 Turn track_artists_to_mpd_format into artists_to_mpd_format 2010-10-30 20:41:45 +02:00
Thomas Adamcik
ea74f539ba Fix mistakes in tag cache generation 2010-10-30 01:06:26 +02:00
Thomas Adamcik
96d4633306 Ensure that key does not have uri encoded strings 2010-10-30 00:40:01 +02:00
Thomas Adamcik
ca95a510c9 Ensure that mtime is included 2010-10-30 00:37:42 +02:00
Thomas Adamcik
94db967672 Tag cache seems to support directories now 2010-10-29 23:26:05 +02:00
Thomas Adamcik
1a6831ab68 Add tracks_to_directory_tree helper 2010-10-29 23:06:58 +02:00
Thomas Adamcik
059ad2d4c9 Update track_to_mpd_format docstring with new parameters 2010-10-29 22:20:19 +02:00
Thomas Adamcik
8d1339ef7f Add option to get mtime set in translator 2010-10-29 22:18:35 +02:00
Thomas Adamcik
a8a447c47f Use key=True for track_to_mpd_format generation 2010-10-29 21:36:11 +02:00
Thomas Adamcik
488ac28431 Add key parameter to track_to_mpd_format 2010-10-29 21:25:02 +02:00
Thomas Adamcik
cf516c5ef0 Ensure that mpd_format_track handles file: properly 2010-10-29 21:17:08 +02:00
Thomas Adamcik
014e29ffa2 Fix uri_to_mpd_relative_path so that it handles None 2010-10-29 21:15:32 +02:00
Thomas Adamcik
8240dbbb55 Add docstrings 2010-10-29 20:36:38 +02:00
Thomas Adamcik
44012b30b0 Add uri_to_mpd_relative_path 2010-10-29 20:33:13 +02:00
Thomas Adamcik
02df8ca033 Start writting tracks_to_tag_cache_format 2010-10-29 20:04:53 +02:00
Johannes Knutsen
e1f8a0bf72 Rename mopidy.frontends.mpd.{serializer => translator} to match naming in backends. 2010-08-13 20:48:38 +02:00