Commit Graph

2431 Commits

Author SHA1 Message Date
Stein Magnus Jodal
6c68b17b45 Fix 'commands' and 'notcommands' for unauthenticated users
Use newly gained access to the current user's authentication state and
the command handler's auth_required flag to give correct 'commands' and
'notcommands' output to unauthenticated users when password
authentication is activated.
2011-06-04 19:44:16 +02:00
Stein Magnus Jodal
d0573aa7e8 docs: Do not autodoc private members any longer. The need really went away with the separation of BackendControllers and BackendProviders 2011-06-04 19:28:19 +02:00
Stein Magnus Jodal
528f599660 Remove _-prefix from BaseMixer.{get_volume,set_volume} as they are public members of the API, intended to be overridden 2011-06-04 19:25:38 +02:00
Stein Magnus Jodal
c52d5c9388 Document mopidy.frontends.mpd.protoocol.mpd_commands as a part of the MPD frontend API 2011-06-04 19:20:53 +02:00
Stein Magnus Jodal
3ac987ee47 Move definition of what commands are allowed without authentication from the auth filter to the request handlers 2011-06-04 19:16:07 +02:00
Stein Magnus Jodal
601a0f0a45 You are always authenticated when MPD_SERVER_PASSWORD==None 2011-06-04 19:02:20 +02:00
Stein Magnus Jodal
d5a13ae1ca Add auth_required=True to handle_request, and add it to the MpdCommand object stashed in mpd_commands 2011-06-04 18:55:54 +02:00
Stein Magnus Jodal
e68d715d3e Rename handle_pattern decorator to handle_request 2011-06-04 18:51:18 +02:00
Stein Magnus Jodal
a08885bb95 Use a MpdCommand namedtuple in the mopidy.frontends.mpd.protocol.mpd_commands list 2011-06-04 18:43:30 +02:00
Stein Magnus Jodal
e6294ec869 Fix pylint warnings in MPD frontend 2011-06-04 18:24:06 +02:00
Stein Magnus Jodal
68a671414c Update MpdServer's docstrings 2011-06-04 17:38:03 +02:00
Stein Magnus Jodal
939a8f40d6 No need for splitting init and start of MpdSession 2011-06-04 17:18:46 +02:00
Stein Magnus Jodal
6d1bac0d72 Reorder methods and add comments to divide sections 2011-06-04 17:06:17 +02:00
Thomas Adamcik
eba5cff9d1 Work around strange wma issue in scanner 2011-06-04 02:21:42 +02:00
Stein Magnus Jodal
08f085fd8d Refactor MpdDispatcher to use a filter model, like Java Servlets. Password authentication handling becomes much cleaner. 2011-06-04 02:21:14 +02:00
Thomas Adamcik
89104bd326 Add skipped test case for date missing in scanner tests 2011-06-04 01:52:11 +02:00
Thomas Adamcik
f091433a53 Cleanup error feedback 2011-06-04 01:51:44 +02:00
Thomas Adamcik
503c98b98e Cleanup of gst code for scanner 2011-06-04 01:29:28 +02:00
Stein Magnus Jodal
3fe276f32a Refactor MpdSession 2011-06-04 00:54:02 +02:00
Stein Magnus Jodal
a68bdae751 Move MPD authentication check from MpdSession to MpdDispatcher 2011-06-04 00:42:51 +02:00
Stein Magnus Jodal
1db84dccca Refactor MpdDispatcher.handle_request 2011-06-04 00:33:57 +02:00
Thomas Adamcik
710f434455 Switch to proper logging for mopidy scanner 2011-06-04 00:32:55 +02:00
Thomas Adamcik
ea8b4fc2b0 Remove if __name__ = '__main__' as it was redundant in mopidy-scanner 2011-06-04 00:17:34 +02:00
Thomas Adamcik
e25fbb35dc Note why get_state is needed 2011-06-04 00:14:17 +02:00
Thomas Adamcik
48d7cd9865 Use TAG_DURATION constant instead of 'duration' 2011-06-04 00:14:04 +02:00
Thomas Adamcik
b6c196b8ab Ensure that date is not none before using it 2011-06-04 00:13:40 +02:00
Thomas Adamcik
e2be61312f Merge pull request #101 from jodal/feature/clean-shutdown
feature/clean-shutdown
2011-06-03 15:09:21 -07:00
Stein Magnus Jodal
bf175a3dce Rename one letter variable in tests 2011-06-03 23:58:24 +02:00
Stein Magnus Jodal
6b71a7acb5 Update changelog with MPD improvements 2011-06-03 23:39:34 +02:00
Stein Magnus Jodal
c9506ca7e1 List 'kill' MPD command in 'notcommands' instead of 'commands' 2011-06-03 23:32:19 +02:00
Stein Magnus Jodal
7f7d79b21f Return permission error on use of MPD command 'kill' 2011-06-03 23:31:52 +02:00
Stein Magnus Jodal
c84639b197 Add MpdPermissionError exception 2011-06-03 23:25:00 +02:00
Stein Magnus Jodal
4036b7dd8e Add missing inheritance diagrams for the MPD docs 2011-06-03 22:54:19 +02:00
Stein Magnus Jodal
9545da4b4e Refactor MPD dispatcher 2011-06-03 22:37:05 +02:00
Stein Magnus Jodal
52ee117153 Merge branch 'feature/clean-shutdown' into feature/mpd-improvements 2011-06-03 22:35:48 +02:00
Stein Magnus Jodal
4db9c0139b Update TODO for MPD command 'kill' 2011-06-03 17:34:19 +02:00
Stein Magnus Jodal
30d6d6f29e Close client connection on MPD command 'close' 2011-06-03 17:18:38 +02:00
Stein Magnus Jodal
82381720e5 Add the current MpdSession to the MpdContext 2011-06-03 17:12:41 +02:00
Stein Magnus Jodal
acde68159a Use @property and memoization to delay backend/mixer proxy creation until it is needed 2011-06-03 17:06:32 +02:00
Stein Magnus Jodal
d4ab666b21 Update outdated docstrings in MpdSession 2011-06-03 16:57:48 +02:00
Stein Magnus Jodal
cbdc37a24d Replace all single letter instance variables in MPD protocol tests 2011-06-03 16:52:52 +02:00
Stein Magnus Jodal
d57727282e Create new MpdContext object which is passed to command handlers 2011-06-03 16:34:47 +02:00
Stein Magnus Jodal
76d0314eff Replace 'frontend' with 'context' in MPD protocol impl 2011-06-03 16:08:53 +02:00
Thomas Adamcik
acad477c8a Make it possible to stop scanner more cleanly 2011-06-02 18:41:43 +02:00
Stein Magnus Jodal
0e098e9b60 Replace not decodable characters returned from Spotify instead of crashing 2011-06-02 18:38:11 +02:00
Antoine Pierlot-Garcin
f73ba3bd62 backend-spotify: implement a container manager (fixes GH59) 2011-05-30 22:22:23 -04:00
Stein Magnus Jodal
3b27ba4746 Catch and log ActorDeadError in BaseThread 2011-05-25 23:06:15 +02:00
Stein Magnus Jodal
55bc7b19fb Remove dead code in BaseThread 2011-05-25 23:05:54 +02:00
Stein Magnus Jodal
fc9875bf3d Spotify albums may be None 2011-05-25 21:58:34 +02:00
Stein Magnus Jodal
63918ac3f3 Log a warning if MPD tries to communicate with dead actors. 2011-05-25 21:58:34 +02:00