Commit Graph

499 Commits

Author SHA1 Message Date
Stein Magnus Jodal
23e73d962b core: Define playlists.delete() return type 2018-09-19 22:27:18 +02:00
Jarryd Tilbrook
b4c98ec4a5 Fix/1531 add unix domain socket (#1629)
mpd: add functionality for unix domain socket (Fixes #1531)

The Hostname config type now supports a Unix socket path prefixed with `unix:`
2018-02-13 12:58:39 +00:00
Nick Steel
d6eff50597 core: Fix library.lookup with an empty uri list. Fixes #1619. 2017-06-15 00:10:06 +01:00
Stein Magnus Jodal
1eb9e087c9 core: Remove redundant comments 2016-10-25 00:17:58 +02:00
Stein Magnus Jodal
b6c16750cf Merge pull request #1549 from alexjaw/fix/1512
alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume
2016-10-25 00:17:14 +02:00
dublok
b0f7490926 Fix typos 2016-09-17 18:22:39 +02:00
Jens Lütjen
92767e49f9 Fix typos and formatting 2016-09-16 21:01:10 +02:00
Jens Lütjen
46dd36d914 Optimize _tl_tracks initialization 2016-09-16 20:28:10 +02:00
Jens Lütjen
5057b8b31d Merge 'develop' and resolve conflict
Conflicts:
	docs/changelog.rst
2016-09-14 18:17:52 +02:00
Alexander Jaworowski
95deb77939 alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume 2016-08-21 21:59:10 +02:00
Alexander Jaworowski
bee9bd3d23 alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume 2016-08-21 21:40:17 +02:00
Nantas Nardelli
6e603a183b Add TODO about checking length of track when null 2016-07-24 22:26:59 +01:00
Nantas Nardelli
d1449bcb6f Properly get track position before change events
In particular, this allows to send the right information when:

1. the track finishes and switches to the next one in the list;
2. user presses next / previous

The cases of EOS and stop event were already handled properly.

Note: we only have GStreamer's `about-to-finish` event to deal with the
end of a track, which usually happens a few seconds before the end of
the track. We set the position to the length of the track, which is not
overridden unless the user generates a relevant callback.
2016-07-24 20:30:48 +01:00
Jens Luetjen
7757d306ea Include _pending_position 0 (zero) as valid target 2016-04-04 21:45:02 +02:00
Jens Luetjen
c2c64620b1 Ignore position of _on_position_changed callback 2016-04-04 20:40:56 +02:00
Jens Luetjen
100d7dba7b Reworked if conditions in _load_state 2016-04-02 17:12:31 +02:00
Jens Luetjen
d93cc1b44d Remove unnecessary array initialzation 2016-04-02 16:04:45 +02:00
Jens Luetjen
ac47d254a3 Remove dead code for 'play-always' 2016-04-02 15:58:05 +02:00
Jens Luetjen
6e33bbcadd Replace restore/export with load/save
Rename _restore_state to _load_state
Rename _export_state to _save_state
2016-04-01 19:50:37 +02:00
Jens Luetjen
e9db19a352 Handle all path- and file-names as bytestings 2016-04-01 19:39:48 +02:00
Jens Luetjen
cf5dfccee2 Rename PlaybackState.position to time_position. 2016-04-01 19:13:26 +02:00
Jens Luetjen
eb930a1679 Catch exception when deleting persistent file. 2016-03-31 23:34:57 +02:00
Jens Luetjen
e9e9646d61 Removed unnecessary docstrings. 2016-03-31 23:24:25 +02:00
Jens Luetjen
44b7974f79 Restore mixer.volume/mute before starting playback 2016-03-31 23:20:26 +02:00
Jens Luetjen
01201d142c Renamed member in HistoryController
- add 'play-always' and 'play-last' to docstring for _load_state.
- renamed _start_at_pos to _start_at_position
- changed 'if const == value:' to 'if value == const:'
- changed info text to 'Limiting history'
2016-03-31 23:17:29 +02:00
Jens Luetjen
67044cecab Remove 'TODO: check if playable'
We don't need to as each backend a title is still playable.
The backend must be able to handle unplayable title.

Replace for loop with arrar.extend()
2016-03-31 22:07:53 +02:00
Jens Luetjen
3251722a28 Rename storage.save() to storage.dump().
The name matches the load/dump in the json library.
Import olny storage from mopidy.internal (not all of mopidy.internal).
2016-03-31 21:55:32 +02:00
Jens Luetjen
7928caeb71 Persist mixer mute state.
Restore mixer.mute state at start.
Update mopidy.models docstrings.
2016-03-31 21:30:48 +02:00
Jens Luetjen
d4d2ad80dc Changed name persistant file to 'state.json.gz'
Changed filename from persistent.state to state.json.gz. Now the
file extension matches the content.
2016-03-31 20:24:31 +02:00
Jens Luetjen
2bb9e39ba6 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 2016-03-31 19:04:45 +02:00
Jens Luetjen
6116705c1b Avoid endless loop in 'next' and 'previous'. 2016-03-26 09:43:38 +01:00
Jens Luetjen
a2f0d6960f Avoid endless loop if all tracks are unplayable.
Limit the number of tries for changing to the nest track.
The limit is 2 * tracklist length get all tracks in a shuffled playlist.
2016-03-26 09:43:38 +01:00
Jens Luetjen
3eac589557 Try to restore state only one time.
Delete the persistant file after read. If something
goes wrong during restore, the next start is clean.
2016-02-29 20:47:11 +01:00
Jens Luetjen
854357a295 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs
Conflicts:
	mopidy/core/playback.py
	tests/core/test_playback.py

revert _backend_error_handling
revert endless loop prevention
2016-02-17 22:18:50 +01:00
Stein Magnus Jodal
6407e87301 core: Update versionadded from 1.2 to 2.0 2016-02-14 22:40:27 +01:00
Thomas Adamcik
79a4835e4e core: Add tests for change_track failing in about-to-finish 2016-02-14 17:23:20 +01:00
Thomas Adamcik
76ab5ffb04 core: Make sure exceptions from backend's change_track is handled
Also adds TODOs for the rest of the backend calls in playback which all need to
assume backends can and will screw up.
2016-02-14 17:16:31 +01:00
Thomas Adamcik
b293a116b6 audio: Make sure about to finish skips unplayable tracks 2016-02-14 16:26:47 +01:00
Stein Magnus Jodal
cc82e68a58 core: Remove unplayable track in consume mode
Fixes #1418

This was previously fixed in 1.1.2, but the fix was skipped in when
release-1.1 was merged into develop in #1400, thus no changelog entry.
2016-02-14 15:47:22 +01:00
Jens Luetjen
bc981355bc Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 2016-02-08 18:45:58 +01:00
Stein Magnus Jodal
e67e4c2c6e core: Avoid use of deprecated property 2016-02-07 22:06:48 +01:00
Jens Luetjen
d04ff28514 Implement 'start paused' and 'start at position' 2016-02-07 17:31:38 +01:00
Jens Luetjen
3bf6b9896c Limit history to 500 track
To avoid an too large history list, save/restore maximum 500 tracks.
500 tracks a 3 minuts gives 24 hours history.
2016-02-06 16:22:54 +01:00
Jens Luetjen
9d8034869d Chance type of core.restore_state config value
Change to boolean to simplify the user configuration.
2016-02-06 15:48:43 +01:00
Jens Luetjen
0a1e43c876 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs
Conflicts:
	mopidy/audio/scan.py
Fix conflicts.
2016-02-03 22:01:51 +01:00
Jens Luetjen
49849fa5b3 Find all playable tracks in a shuffled playlist.
Run two times through the tracklist to be sure to not miss a playable track.
2016-02-03 20:49:43 +01:00
Jens Luetjen
e51b8c58be Fix for: mpd client starts with empty tracklist.
When restoring state, increment the tracklist version number.
2016-02-03 20:47:10 +01:00
Stein Magnus Jodal
226c937ffc gst1: Tune log messages 2016-01-31 21:07:16 +01:00
Stein Magnus Jodal
adb260af05 Merge branch 'release-1.1' into develop
Fixes #1400
2016-01-31 07:47:47 +01:00
Jens Luetjen
cfc2d59c82 Add a TODO for missing tracks in shuffled playlist 2016-01-30 13:51:16 +01:00