Commit Graph

73 Commits

Author SHA1 Message Date
Thomas Adamcik
07f0453c6e core: Make event triggers internal 2015-03-23 00:50:05 +01:00
Stein Magnus Jodal
2bc3db0d0e core: Add uris kwarg to tracklist.core()
Fixes #1060
2015-03-21 00:16:24 +01:00
Stein Magnus Jodal
c57f3ec9b2 core: Make tracklist.mark_*() private
Fixes #1058
2015-03-20 22:28:40 +01:00
Stein Magnus Jodal
a05c097106 docs: Change deprecated-in from 0.20 to 1.0
Fixes #1051
2015-03-18 22:00:00 +01:00
Ali Ukani
92910e4362 Fix flake8 tests
Fixes "W503 line break before binary operator"
2015-02-16 02:02:14 -05:00
Stein Magnus Jodal
8f8fa4d414 core: Emit deprecation warnings
The warnings appear as warning level log messages if running Python on
the mopidy/ directory like this:

    python -W all mopidy -v

or:

    python -W all mopidy -o loglevels/py.warnings=warning

We don't suppress warnings when Pykka is the caller in general, but just
when Pykka is looking at all properties to create its actor proxies.

When a deprecated property is used from another Pykka actor, only the
stack for the current actor thread is available for inspection, so the
warning cannot show where the actual call site in the other actor thread
is. Though, if the warnings are made exceptions with:

    python -W error mopidy

then the stack traces will include the frames from all involved actor
threads, showing where the original call site is.
2015-02-11 00:29:52 +01:00
Stein Magnus Jodal
5827e45c34 core: Use getters/setters internally in core
This fixes all the easy-to-track warnings.
2015-02-11 00:17:12 +01:00
Stein Magnus Jodal
352de135cd core: Deprecate properties (fixes #952) 2015-02-11 00:17:12 +01:00
Thomas Adamcik
eba3145888 core: Start marking some arguments and methods as internal per #870 2014-12-25 22:58:44 +01:00
Stein Magnus Jodal
dbbb86e6c0 Merge branch 'release/v0.19.x' into develop
Conflicts:
	mopidy/core/playback.py
2014-12-24 00:24:19 +01:00
Stein Magnus Jodal
c6ff9eee86 playback: Remove skipped track on next in consume mode
Also adds core level tests of consume behavior on next/prev/eot.

Fixes #902
2014-12-24 00:04:41 +01:00
Stein Magnus Jodal
4f428b8601 py3: Move compat module out of utils 2014-12-07 21:36:15 +01:00
Stein Magnus Jodal
95df66865e py3: Use list comprehensions instead of filter()
This is just a stylistic change, and is not strictly required for Python 3
compat.
2014-12-07 20:19:01 +01:00
Stein Magnus Jodal
1d26c2d63c py3: Use .item() and .values()
As .iteritem() and .itervalues() doesn't exist in Python 3.
2014-12-07 20:19:01 +01:00
Stein Magnus Jodal
58527406c1 py3: Use compat.text_type instead of unicode 2014-12-07 20:17:10 +01:00
Stein Magnus Jodal
496142c201 py3: Use absolute imports by default 2014-12-07 20:17:10 +01:00
Stein Magnus Jodal
4a6e7d292c docs: Don't refer to the tracklist as a playlist 2014-11-25 21:37:55 +01:00
Stein Magnus Jodal
b754885064 Fix all import order warnings 2014-05-07 20:08:43 +02:00
Stein Magnus Jodal
5583ca5aba New flake8 version with new checks to conform to 2014-03-29 20:47:42 +01:00
Stein Magnus Jodal
0fb7c79524 log: Use loggers named after __name__ 2014-01-01 13:31:20 +01:00
Stein Magnus Jodal
04788abaac core: Change tracklist.{filter,remove} usage
The criterias are now a mapping between field names and one or more values.
This aligns tracklist.{filter,remove} with the API of
library.{find_exact,search}, and allows for e.g. batch removals.

An exception is raised immediately if the API is used in the old way to ease
migration and debugging.
2013-11-12 00:00:22 +01:00
Javier Domingo Cansino
71bae709ef core: filter() to accept also tuples 2013-11-07 11:05:33 +01:00
Javier Domingo Cansino
45a38cdaf1 core: Changing input to accept also sets, as might be also used. 2013-11-07 10:51:29 +01:00
Javier Domingo Cansino
6721a59b26 tests: Fixing self confusion mistake
docs: Documenting tracklist's new filter() feature
2013-11-07 09:46:34 +01:00
Javier Domingo Cansino
32b01f4e4a Adding a 'to list' conversion and correcting horrible mistake in comparison (put it reverse) 2013-11-05 13:17:55 +01:00
Javier Domingo Cansino
808770733f core: Letting filter() accept lists 2013-11-05 13:08:40 +01:00
Thomas Adamcik
bfddfab15a core: Fix typos pointed out in PR#542 2013-10-20 22:47:54 +02:00
Thomas Adamcik
84c373d7ea Merge branch 'develop' into fix/bug-496-handle-single
Conflicts:
	mopidy/core/tracklist.py
2013-10-20 22:46:35 +02:00
Thomas Adamcik
ba55181bc1 core: Reduce duplication between next and eot track handling. 2013-10-20 21:48:42 +02:00
Thomas Adamcik
f1f223bba8 local: Fix handling of single in eot_track (fixes #496)
- Adds test cases for code paths that caused bug
- Short circuits EOT next track handling when in single mode.
2013-10-20 21:43:19 +02:00
Thomas Adamcik
40754bb2e0 core: Fix handling of shuffle (fixes #453)
- Shuffle internal list when random is enabled
- Use presence of tl_track to determine if this is first run to trigger
  subsequent shuffles.
2013-10-20 19:28:13 +02:00
Stein Magnus Jodal
83db750e0a core.tracklist: Formatting 2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
9864f55b75 core.tracklist: Improve if check in mark_unplayable() 2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
46aeb3bfcc core.tracklist: Move logging into mark_unplayable() 2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
67a7e0021a core.tracklist: Add docstrings to mark_* 2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
91e718e85f core.tracklist: Rename mark_{starting => playing} 2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
0ea4fd6af0 core.tracklist: Rename mark_{consumed => played} 2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
aaa3b2e93c core.tracklist: Remove redundant if stmt in index() 2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
9c2f6c2f25 core.tracklist: Tweak docstrings 2013-10-19 20:53:01 +02:00
Stein Magnus Jodal
ff89fc58a9 core.tracklist: Remove pylint comment 2013-10-19 20:53:01 +02:00
Javier Domingo Cansino
a14a19447b Updating tidy-up-core to jodal specs and changing one name. Still need to update docs 2013-10-11 12:41:11 +02:00
Javier Domingo Cansino
157556a001 docs: Documenting further the TracklistController functions 2013-08-13 09:17:50 +02:00
Javier Domingo Cansino
11d82056a9 core: Merged tracklist_position to index inside TracklistController
docs: Updated changelog.rst
2013-08-09 09:15:54 +02:00
Javier Domingo Cansino
fac2c8af7d format: Correcting flake8 messages 2013-08-09 08:32:01 +02:00
Javier Domingo Cansino
782a6a7d1f Renamed tl_track_at_* to more readable names 2013-08-08 17:01:24 +02:00
Javier Domingo Cansino
cb4130c2a7 core: Moving the trigger activation from one playback to tracklist 2013-08-08 13:45:36 +02:00
Javier Domingo Cansino
2cb64b365d docs: Documenting changed and created functions 2013-08-08 13:13:52 +02:00
Javier Domingo Cansino
ab85dd9d62 Changed mark_consumed to a flexible mark() function that currently allows to mark songs as consumed (that have been played full time), played (that have been played for some time) and unplayable 2013-08-08 12:12:37 +02:00
Javier Domingo Cansino
2c83225a1e Created a TracklistController to let it control wether if a track must be consumed or not 2013-08-08 11:56:35 +02:00
Javier Domingo Cansino
6e61f2ef85 Refactoring code to convert tl_track_at_previous() in a function, also recoded
tests.
2013-08-07 21:53:46 +02:00