Commit Graph

1428 Commits

Author SHA1 Message Date
Stein Magnus Jodal
b0ae7d3c6f local: Fix crash on non-ASCII chars in URIs 2013-10-24 23:22:01 +02:00
Stein Magnus Jodal
e448d77eb7 mpd: Fix flipped mute logic 2013-10-24 22:20:07 +02:00
Thomas Adamcik
84c373d7ea Merge branch 'develop' into fix/bug-496-handle-single
Conflicts:
	mopidy/core/tracklist.py
2013-10-20 22:46:35 +02:00
Thomas Adamcik
f1f223bba8 local: Fix handling of single in eot_track (fixes #496)
- Adds test cases for code paths that caused bug
- Short circuits EOT next track handling when in single mode.
2013-10-20 21:43:19 +02:00
Thomas Adamcik
7fc753d167 core/local: Update playback test with review comments.
- Fixes typo.
- Adds assert to better test intermediate state.
2013-10-20 21:16:18 +02:00
Thomas Adamcik
d978005008 core: flake8 fixes 2013-10-20 20:33:48 +02:00
Thomas Adamcik
40754bb2e0 core: Fix handling of shuffle (fixes #453)
- Shuffle internal list when random is enabled
- Use presence of tl_track to determine if this is first run to trigger
  subsequent shuffles.
2013-10-20 19:28:13 +02:00
Thomas Adamcik
66ae1b8eee local/core: Add and fix more random related tests.
- Adds tests for eot_track vs next_track as we were only testing the one code
  path.
- Makes test_random_until_end_of_playlist_and_play_from_start actually test
  random and not repeat.
- Adds test_play_track_then_enable_random which is the underlying bug covered
  by the regression test for issue #17.
2013-10-20 18:39:07 +02:00
Thomas Adamcik
025bafc114 local/core: Update random tests to be more predictable
- Replace setting the random seed with mocking out shuffle with reverse. This
  makes tests easier to reason about while still being able to test correct
  behaviour.
- Increases number of tracks to four to avoid test passing due to symetry in
  plain and reversed lists.
- Made test_eot_track_with_random_after_append_playlist actually test eot and
  not next.
- Found a test failure in handling of test_random_until_end_of_playlist, fix in
  next commit.
2013-10-20 18:39:07 +02:00
Stein Magnus Jodal
96008ca826 Merge pull request #539 from adamcik/fix/bug-527-temp-workaround
local: Temporary workaround for issue #527
2013-10-20 07:31:55 -07:00
Thomas Adamcik
fcd3e5d5cf local: Add test for fallback handling of unknown track uris in playlists
- Checks that adding a non local:track:... uri to a playlist and reading it
  back works.
- Also fixes mistake in API usage where we assumed lookup still raised
  LookupError.
2013-10-20 16:18:03 +02:00
Stein Magnus Jodal
c8886dec49 tests: Sort imports 2013-10-20 16:04:09 +02:00
Thomas Adamcik
2f01fc4e46 scanner: Review comments and flake fixes
- Move ScannerError to exceptions module.
- Subclass ScannerError from MopidyException.
- Fix import sorting.
2013-10-20 15:51:39 +02:00
Thomas Adamcik
a5a55952fb scanner: Switch to gst.pbutils.Discoverer and refactor API
- New API wraps gst.pbutils.Discoverer for mopidy use.
  - Custom scanner code removed.
- Callback based async API switched with simpler synchronous API
  - Scanner is feed one and one URI and returns the result or raises an error.
- Adds new ScannerError exception for error handling in scanner
- Limits local/scan_timeout to 1000-3600000 i.e. 1s to 1h
- Files with zero duration are now excluded.
- Mtime handling moved out of scanner so we can use it for streams etc.
2013-10-20 13:22:00 +02:00
Thomas Adamcik
e0bfe144f8 Merge pull request #532 from jodal/feature/search-by-albumartist
Search filtering by albumartist
2013-10-19 13:46:58 -07:00
Thomas Adamcik
c8f5c1aacf Merge pull request #537 from jodal/tidy-up-core
Core playback and tracklist modularity improvement v2
2013-10-19 13:24:21 -07:00
Stein Magnus Jodal
27a63b1688 local: Remove redundant test asserts 2013-10-19 22:17:08 +02:00
Stein Magnus Jodal
c850ed2698 Merge branch 'develop' into feature/search-by-albumartist
Conflicts:
	tests/backends/local/library_test.py
2013-10-19 22:15:50 +02:00
Stein Magnus Jodal
7d874873bd local: Include albumartist in 'any' searches 2013-10-19 22:14:53 +02:00
Stein Magnus Jodal
033e3ab813 jsonrpc: Test application error responses again
The test was modified to not fail after a refactoring, making it not test what
it was intended to test at all. This reverts the changes and updates the test
in another way, keeping the original intention.
2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
d7552b2fe2 tests: Formatting 2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
d9921d9127 core.tracklist: Test changed index() behavior 2013-10-19 20:53:01 +02:00
Javier Domingo Cansino
677c61f398 tests: Rename local tests to describe that they are testing local providers and not core controllers 2013-10-18 16:12:38 +02:00
Javier Domingo Cansino
e9c20d2e59 Correcting flake error on unused import 2013-10-15 12:11:01 +02:00
Javier Domingo Cansino
1d4ff4c9c6 Merging upstream changes in tidy-up-core 2013-10-15 09:37:54 +02:00
Stein Magnus Jodal
76b70aa0c5 mpd: Make 'list' support 'albumartist' key 2013-10-12 00:16:20 +02:00
Stein Magnus Jodal
ccbae310c6 local: Add albumartist support to search/find_exact 2013-10-12 00:16:20 +02:00
Thomas Adamcik
adecba40e5 Merge pull request #531 from jodal/feature/merge-base-backend-and-local-tests
tests: Merge BaseBackend and LocalBackend tests
2013-10-11 14:56:18 -07:00
Stein Magnus Jodal
3c53c1ddcd tests: Merge BaseBackend and LocalBackend tests 2013-10-11 22:17:27 +02:00
Javier Domingo Cansino
686dd5981d Merging branch develop into tidy-up-core 2013-10-11 10:43:50 +02:00
Stein Magnus Jodal
b539a9c094 mpd: Handle unknown outputid 2013-10-10 10:02:37 +02:00
Stein Magnus Jodal
db892e6974 mpd: Rename muting output to 'Mute' 2013-10-10 09:49:15 +02:00
Stein Magnus Jodal
863f7e0430 mpd: Trigger 'output' idle event on mute_changed()
This is required for e.g. ncmpcpp to detect that an enableoutput/disableoutput
command worked, making it possible to toggle the output back without restarting
ncmpcpp.
2013-10-09 23:52:59 +02:00
Stein Magnus Jodal
447864774e core: Add volume arg to volume_changed() event
It was already called with the argument, and both the MPD and HTTP frontends
handled it/expected it. It was just the default implementation in CoreListener
that lacked the argument.
2013-10-09 23:51:01 +02:00
Stein Magnus Jodal
158b2344ff audio: Add test TODO 2013-10-09 23:29:43 +02:00
Stein Magnus Jodal
c3e8899396 mpd: Test that output enabling/disabling unmutes/mutes audio 2013-10-09 23:28:01 +02:00
Stein Magnus Jodal
6a3e322845 core: Tweak mute docs, add simple test case 2013-10-09 23:24:17 +02:00
Stein Magnus Jodal
56b1d6390c Merge branch 'develop' into feature/audio-mute 2013-10-09 22:57:16 +02:00
Stein Magnus Jodal
f9a6fa525a Bump version number for compat with extracted extensions 2013-10-08 08:51:33 +02:00
Stein Magnus Jodal
c589583b74 mpris: Move to external extension 2013-10-07 23:42:07 +02:00
Javier Domingo Cansino
5b5bd342b6 Updating tests to be compliant with the new response (ok) 2013-10-07 13:11:13 +02:00
Thomas Adamcik
2e1971af89 audio: Handle min=max when scaling volumes (fixes: #525)
Also add gobject.threads_init() so we can run the audio actor test on its own.
2013-10-06 22:24:36 +02:00
Thomas Adamcik
a5e26f9b54 audio: flake8 fixes 2013-10-06 16:57:32 +02:00
Thomas Adamcik
b1b522694e audio: Fix lots of playlist issues and add tests. 2013-10-06 15:22:17 +02:00
Javier Domingo Cansino
2ac13d9b44 Merge branch 'develop' into tidy-up-core 2013-10-03 09:20:08 +02:00
Stein Magnus Jodal
ba361add4c Bump version to 0.15.0 2013-09-19 19:30:36 +02:00
Javier Domingo Cansino
8b13270f67 Merge branch 'develop' into tidy-up-core 2013-09-17 12:42:42 +02:00
Stein Magnus Jodal
1a02b4d17f Remove support for running Python on the mopidy/ dir
It doesn't make sense to run Mopidy without extensions registered, thus you'll
need to use setuptools and to run `python setup.py develop` anyway. Doing so
makes running `mopidy` from anywhere in the development virtualenv work,
removing any need for running `python mopidy/`.
2013-09-16 22:13:36 +02:00
Stein Magnus Jodal
e830f31480 Fix too broad truthness test (fix #501)
This caused TlTracks with tlid=0 to be sent to HTTP clients without the tlid
field.
2013-09-16 21:58:23 +02:00
Stein Magnus Jodal
05d4fa846f config: Deserialize Secret to unicode (fix #473)
MPD, Scrobbler, and Spotify extensions have been reviewed for need for changes
due to this, without anything being found.
2013-09-15 23:51:41 +02:00