Commit Graph

241 Commits

Author SHA1 Message Date
Jens Luetjen
d4d2ad80dc Changed name persistant file to 'state.json.gz'
Changed filename from persistent.state to state.json.gz. Now the
file extension matches the content.
2016-03-31 20:24:31 +02:00
Jens Luetjen
2bb9e39ba6 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 2016-03-31 19:04:45 +02:00
Jens Luetjen
bf4da7a627 Add tests to ensure that play, next will not busy-loop
Test PlaybackController functions play(), next(), previous()
and _on_about_to_finish() that they will not loop forever
if all tracks are unplayable.
2016-03-26 09:43:38 +01:00
Jens Luetjen
3eac589557 Try to restore state only one time.
Delete the persistant file after read. If something
goes wrong during restore, the next start is clean.
2016-02-29 20:47:11 +01:00
Jens Luetjen
854357a295 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs
Conflicts:
	mopidy/core/playback.py
	tests/core/test_playback.py

revert _backend_error_handling
revert endless loop prevention
2016-02-17 22:18:50 +01:00
Thomas Adamcik
79a4835e4e core: Add tests for change_track failing in about-to-finish 2016-02-14 17:23:20 +01:00
Thomas Adamcik
76ab5ffb04 core: Make sure exceptions from backend's change_track is handled
Also adds TODOs for the rest of the backend calls in playback which all need to
assume backends can and will screw up.
2016-02-14 17:16:31 +01:00
Stein Magnus Jodal
9b18ff07ee core: Readd regression test for #1352
Fixes #1418

Based on test that was present in 1.1.2 but dropped in the #1400 merge.
2016-02-14 16:12:45 +01:00
Stein Magnus Jodal
a42ce9f00e core: Test next/prev skips over unplayable tracks
Fixes #1418

Based on tests that was present in 1.1.2 but dropped in the #1400 merge.
2016-02-14 15:47:22 +01:00
Stein Magnus Jodal
cc82e68a58 core: Remove unplayable track in consume mode
Fixes #1418

This was previously fixed in 1.1.2, but the fix was skipped in when
release-1.1 was merged into develop in #1400, thus no changelog entry.
2016-02-14 15:47:22 +01:00
Stein Magnus Jodal
0539e4e8fe Revert "core: Add TODO for testing unplayable-by-backend tracks"
This reverts commit 3a8d896146.
2016-02-14 15:47:18 +01:00
Stein Magnus Jodal
3a8d896146 core: Add TODO for testing unplayable-by-backend tracks 2016-02-14 12:49:15 +01:00
Jens Luetjen
bc981355bc Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 2016-02-08 18:45:58 +01:00
Stein Magnus Jodal
cd83084804 tests: Merge TestPlayUnknownHandling into TestUnplayableURI 2016-02-07 22:01:33 +01:00
Stein Magnus Jodal
1f4f0ab03b tests: Prefix some test classes with 'Test'
We don't want to rely on them subclassing unittest.TestCase.
2016-02-07 22:00:16 +01:00
Jens Luetjen
9d8034869d Chance type of core.restore_state config value
Change to boolean to simplify the user configuration.
2016-02-06 15:48:43 +01:00
Jens Luetjen
d8405082e9 Test tracklist.get_version() change.
The tracklist version shall increase when loading state.
2016-02-04 21:14:20 +01:00
Jens Luetjen
49325c62dd Test tracklist.get_version() change.
The tracklist version shall increase when loading state.
2016-02-04 20:54:49 +01:00
Jens Luetjen
0a1e43c876 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs
Conflicts:
	mopidy/audio/scan.py
Fix conflicts.
2016-02-03 22:01:51 +01:00
Stein Magnus Jodal
2232260d1b tests: Fix typo, don't use deprecated API 2016-01-31 07:50:43 +01:00
Stein Magnus Jodal
adb260af05 Merge branch 'release-1.1' into develop
Fixes #1400
2016-01-31 07:47:47 +01:00
Jens Luetjen
e434556048 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs
Conflicts:
	docs/changelog.rst
	mopidy/audio/scan.py

Resoved conflict.
2016-01-21 19:33:58 +01:00
jcass
2fcbc691c0 fix:add changelog entry and fix line indentation. 2016-01-21 05:55:37 +02:00
jcass
dee7eb7e20 tests:fix pep8 violation. 2016-01-20 15:55:02 +02:00
jcass
239a7be708 fix: ensure that tl_track information is included in event trigger when consume mode is enabled. 2016-01-20 15:41:58 +02:00
Jens Luetjen
606e87b1bb Make export/restore state internal
- drop filename parameter
- make save_state/load_state internal
- remove save_state/load_state from docu and RPC.
- remove models load/save from docu
- build the config path
- folder for 'core' state files
- move restore_state-to-coverage-translation into a method
2016-01-14 19:56:38 +01:00
Jens Luetjen
4869619bb9 New CoreState to hold all core states
- Introduce a CoreState class that holds all core states
- Move xState classes to internal
- Use validation.check_instance for consistent error messages
- Store tlid instead of TlTrack to restore last played track
2016-01-10 13:24:14 +01:00
Jens Luetjen
74344f2b19 Use tlid instead of full tl_track
To export/restore the PlayState the tlid is enough.
2016-01-09 12:52:01 +01:00
Jens Luetjen
46bb780a46 Rename TracklistState 'tracks' to 'tl_tracks'
Correct documentation.
2016-01-09 11:46:09 +01:00
Jens Luetjen
0b0cbc87d4 Merge branch 'develop' into fix/310-persist-mopidy-state-between-runs
Conflicts:
	docs/changelog.rst

Fixed conflict in doc/changelog.rst
2016-01-05 08:16:51 +01:00
Jens Luetjen
d5a45516ef Adujst test code for testing auto-play 2016-01-05 07:53:45 +01:00
Stein Magnus Jodal
456dbe6c3a tests: Fix mock usage 2016-01-03 23:41:34 +01:00
jcass
4e63e4280c Merge remote-tracking branch 'upstream/release-1.1' into fix/1378 2016-01-04 00:04:42 +02:00
Jens Luetjen
e56c39ee78 Add unit tests for export/restore core state
Fix issues shown by test code
2016-01-03 18:29:35 +01:00
Stein Magnus Jodal
f2194e9d5e fix: skip uplayable tracks when the next track is selected while in a paused state. 2016-01-02 15:51:17 +02:00
Stein Magnus Jodal
094a874055 core: Make lookup() ignore tracks without URI
Fixes #1340
2016-01-01 23:44:26 +01:00
Stein Magnus Jodal
c47c929440 Merge PR #1356 from jcass77/fix/1352 into release-1.1 2015-12-29 14:37:08 +01:00
Stein Magnus Jodal
4fba994441 Merge pull request #1377 from jcass77/test/pr_1356_resume_unplayable_track
test: Test case for skipping unplayable tracks when paused.
2015-12-29 08:53:12 +01:00
jcass
07a0f8ff3e test: Test case to ensure that unplayable tracks are skipped over in PAUSE state.
Ensures that pause->next->resume handles unplayable tracks just like stop->next->play does.
2015-12-29 07:54:49 +02:00
Thomas Kemmer
ef1468d8d6 core: Add PlaylistsController.get_uri_schemes(). 2015-12-13 19:02:33 +01:00
Stein Magnus Jodal
be5bdb8a85 Fix review comments on PR#1359 2015-12-12 11:01:52 +01:00
jcass
e9eb9d61b4 Test cases for issue #1358 2015-12-11 07:47:07 +02:00
jcass
3cd3b45512 Fix flake8 errors. 2015-12-07 07:56:35 +02:00
jcass
fb7b466bee Result of prepare_change no longer affects whether a track is added to the history.
Update changelog and test cases.
2015-12-07 07:53:34 +02:00
jcass
2b00e83179 Mark track as playing and add to history if changing track while paused. 2015-12-06 19:16:20 +02:00
Thomas Adamcik
9f23757cc3 core: Return pending position during active seek.
This covers over that audio will fail query position while a seek is in
progress. It also means that instead of returning zero we at least return
something which is much closer to the time that we will soon end up playing
from.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
454077afeb core: Make sure certain events are ignored when doing eot-seeks 2015-12-04 21:10:48 +01:00
Thomas Adamcik
aeb881896b core: Trigger position changed from audio events.
Makes sure to only fire when the position changed to our intended seek target.
Otherwise we would also be triggering this when playback starts.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
e74eafb38a core: Switch back to correct track if seek happens before stream changed
Technically the seek still needs to be postponed for this to work right, but
it's a step closer.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
3a57a5792b core: Make sure we always emit state_changed between tracks
Gapless broke this, so this change makes sure that next/prev/play and gapless
track changes all correctly emit events.

Note that this only ensures we get PLAYING -> PLAYING events. Not the old
STOPPED -> PLAYING and then PLAYING -> STOPPED.
2015-11-21 22:43:40 +01:00