Commit Graph

319 Commits

Author SHA1 Message Date
Stein Magnus Jodal
6c68b17b45 Fix 'commands' and 'notcommands' for unauthenticated users
Use newly gained access to the current user's authentication state and
the command handler's auth_required flag to give correct 'commands' and
'notcommands' output to unauthenticated users when password
authentication is activated.
2011-06-04 19:44:16 +02:00
Stein Magnus Jodal
601a0f0a45 You are always authenticated when MPD_SERVER_PASSWORD==None 2011-06-04 19:02:20 +02:00
Stein Magnus Jodal
e68d715d3e Rename handle_pattern decorator to handle_request 2011-06-04 18:51:18 +02:00
Stein Magnus Jodal
08f085fd8d Refactor MpdDispatcher to use a filter model, like Java Servlets. Password authentication handling becomes much cleaner. 2011-06-04 02:21:14 +02:00
Stein Magnus Jodal
a68bdae751 Move MPD authentication check from MpdSession to MpdDispatcher 2011-06-04 00:42:51 +02:00
Stein Magnus Jodal
1db84dccca Refactor MpdDispatcher.handle_request 2011-06-04 00:33:57 +02:00
Stein Magnus Jodal
bf175a3dce Rename one letter variable in tests 2011-06-03 23:58:24 +02:00
Stein Magnus Jodal
c9506ca7e1 List 'kill' MPD command in 'notcommands' instead of 'commands' 2011-06-03 23:32:19 +02:00
Stein Magnus Jodal
7f7d79b21f Return permission error on use of MPD command 'kill' 2011-06-03 23:31:52 +02:00
Stein Magnus Jodal
c84639b197 Add MpdPermissionError exception 2011-06-03 23:25:00 +02:00
Stein Magnus Jodal
9545da4b4e Refactor MPD dispatcher 2011-06-03 22:37:05 +02:00
Stein Magnus Jodal
52ee117153 Merge branch 'feature/clean-shutdown' into feature/mpd-improvements 2011-06-03 22:35:48 +02:00
Stein Magnus Jodal
30d6d6f29e Close client connection on MPD command 'close' 2011-06-03 17:18:38 +02:00
Stein Magnus Jodal
cbdc37a24d Replace all single letter instance variables in MPD protocol tests 2011-06-03 16:52:52 +02:00
Stein Magnus Jodal
d57727282e Create new MpdContext object which is passed to command handlers 2011-06-03 16:34:47 +02:00
Stein Magnus Jodal
86e90f14c6 Add MpdSystemError exception 2011-05-25 21:58:34 +02:00
Thomas Adamcik
0b91b26910 Check if creation of IPv6 sockets works before using it (fixes #75) 2011-04-23 18:15:28 +02:00
Stein Magnus Jodal
342c13f811 Fix 'song: None' in 'status' response 2011-04-06 22:40:50 +02:00
Stein Magnus Jodal
dec1643e7f Merge remote-tracking branch 'grunskis/develop' into develop 2011-04-05 21:37:21 +02:00
Stein Magnus Jodal
20e55873e9 Update MPD/command list 2011-03-20 01:10:32 +01:00
Stein Magnus Jodal
f0ebc24234 Update MPD/stored playlists 2011-03-20 01:04:18 +01:00
Stein Magnus Jodal
289cefc53a Update MPD/stickers 2011-03-20 00:58:13 +01:00
Stein Magnus Jodal
0de8d1b4b8 Update MPD/status 2011-03-20 00:56:43 +01:00
Stein Magnus Jodal
f73268c332 Update MPD/server 2011-03-20 00:38:09 +01:00
Stein Magnus Jodal
21153dd52b Update MPD/regression tests 2011-03-20 00:29:43 +01:00
Stein Magnus Jodal
2e1ea8080e Update MPD/reflection 2011-03-20 00:21:43 +01:00
Stein Magnus Jodal
cbe727d2bd Update MPD/playback 2011-03-20 00:19:30 +01:00
Stein Magnus Jodal
1048795f2b Update working MPD tests to start mixer actor 2011-03-20 00:17:31 +01:00
Stein Magnus Jodal
517a2a9356 Update MPD/music_db 2011-03-19 18:05:09 +01:00
Stein Magnus Jodal
4e82730732 Update MPD/dispatcher 2011-03-19 17:57:06 +01:00
Stein Magnus Jodal
0d57a74cb3 Update MPD/current_playlist 2011-03-19 17:55:05 +01:00
Stein Magnus Jodal
88780c717b Update MPD/connection 2011-03-19 17:55:00 +01:00
Stein Magnus Jodal
a4a015af1d Update MPD/audio_output 2011-03-19 17:54:57 +01:00
Stein Magnus Jodal
b89150f5d2 Skip tests instead of commenting them out 2011-02-12 02:21:38 +01:00
Stein Magnus Jodal
163ead53da Add 'play -1' support when playing 2011-02-12 02:03:18 +01:00
Stein Magnus Jodal
15c992e06a Add 'play -1' support, which fixes resume in MPoD 2011-02-12 01:45:36 +01:00
Stein Magnus Jodal
2463fdd945 Fix test that was declared twice 2011-02-12 01:38:44 +01:00
Martins Grunskis
159831c6e7 mopidy-scan fails if track has no artist name
stack trace:

    Traceback (most recent call last):
      File ./scan, line 27, in <module>
        for a in tracks_to_tag_cache_format(tracks):
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 138, in tracks_to_tag_cache_format
        _add_to_tag_cache(result, *tracks_to_directory_tree(tracks))
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 151, in _add_to_tag_cache
        _add_to_tag_cache(result, *entry)
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 156, in _add_to_tag_cache
        track_result = dict(track_to_mpd_format(track))
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 28, in track_to_mpd_format
        ('Artist', artists_to_mpd_format(track.artists)),
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 88, in artists_to_mpd_format
        return u', '.join([a.name for a in artists if a])
    TypeError: sequence item 0: expected string or Unicode, NoneType found
2011-02-09 18:48:15 +02:00
Stein Magnus Jodal
5e87dcbfff Add 'date' query support to 'find' and 'search' to improve ncmpcpp media library browsing 2011-01-28 11:52:18 +01:00
Stein Magnus Jodal
c097af1a83 Fix a bunch of pylint errors/warnings in test suite 2011-01-23 18:39:05 +01:00
Stein Magnus Jodal
e1197ed84c Change default value of MPD_SERVER_PASSWORD from False to None 2011-01-21 16:31:35 +01:00
Stein Magnus Jodal
775ec64976 Test and improve password handling in MpdSession 2011-01-21 02:15:27 +01:00
Stein Magnus Jodal
8f0e00e1d7 Implement 'password' command which will be reached post-auth 2011-01-21 00:17:01 +01:00
Stein Magnus Jodal
3eb1d47765 Fix seek for Droid MPD 2011-01-09 23:46:03 +01:00
Stein Magnus Jodal
469e5fa189 Fix volume setting for Droid MPD 2011-01-09 23:38:46 +01:00
Stein Magnus Jodal
827940a977 Update Git repo references in tests 2010-11-23 09:39:40 +01:00
Stein Magnus Jodal
b7a0d75372 Merge branch 'feature/split-controllers-and-providers' into develop 2010-11-03 00:09:36 +01:00
Stein Magnus Jodal
13ece43363 Split BaseLibraryController in controller and provider 2010-11-02 23:08:54 +01:00
Thomas Adamcik
37222d66f5 Add albumartistid to frontent 2010-11-02 01:00:11 +01:00
Thomas Adamcik
31933c2c2f Fix musicbrainz support in mpd format track 2010-11-02 00:43:03 +01:00
Thomas Adamcik
e7a7d342b8 Add tests for musicbrainz in mpd formated tracks 2010-11-02 00:36:01 +01:00
Thomas Adamcik
5974d696f1 Refactor mpd formater test 2010-11-02 00:36:01 +01:00
Thomas Adamcik
dd25fadd8b Track result should contain key 2010-11-01 23:23:59 +01:00
Thomas Adamcik
8bfa7d2937 Update tag cache code so it adds mtime and file that is relative 2010-11-01 23:16:49 +01:00
Thomas Adamcik
4ac1d8d217 Remove mtime and key from track_to_mpd_format 2010-11-01 23:09:21 +01:00
Thomas Adamcik
c513d0f6e7 Rename settings that have dirs or file to _PATH and _FILE 2010-11-01 00:37:55 +01:00
Thomas Adamcik
357591e97e Introduce concept of mpd ordered track info for simpler diffing of tag caches 2010-10-30 21:53:59 +02:00
Thomas Adamcik
b9976c4cda Remove uri_to_mpd_relative_path 2010-10-30 21:26:08 +02:00
Thomas Adamcik
d67bfb9aee Use new mtime helper 2010-10-30 20:58:41 +02:00
Thomas Adamcik
9a99bc46bf Add album artist to track to mpd format 2010-10-30 20:46:47 +02:00
Thomas Adamcik
6049c7a094 Turn track_artists_to_mpd_format into artists_to_mpd_format 2010-10-30 20:41:45 +02:00
Thomas Adamcik
ea74f539ba Fix mistakes in tag cache generation 2010-10-30 01:06:26 +02:00
Thomas Adamcik
96d4633306 Ensure that key does not have uri encoded strings 2010-10-30 00:40:01 +02:00
Thomas Adamcik
ca95a510c9 Ensure that mtime is included 2010-10-30 00:37:42 +02:00
Thomas Adamcik
7559426c50 Add test for files in multiple directories 2010-10-29 23:56:01 +02:00
Thomas Adamcik
93eda1c81e Extra test for multiple top level files 2010-10-29 23:46:40 +02:00
Thomas Adamcik
6b99416830 Add test for sub sub dirs in tag cache generator 2010-10-29 23:43:49 +02:00
Thomas Adamcik
94db967672 Tag cache seems to support directories now 2010-10-29 23:26:05 +02:00
Thomas Adamcik
1a6831ab68 Add tracks_to_directory_tree helper 2010-10-29 23:06:58 +02:00
Thomas Adamcik
8d1339ef7f Add option to get mtime set in translator 2010-10-29 22:18:35 +02:00
Thomas Adamcik
21eadf3dc7 Refactor tag_cache generation tests 2010-10-29 21:56:20 +02:00
Thomas Adamcik
a8a447c47f Use key=True for track_to_mpd_format generation 2010-10-29 21:36:11 +02:00
Thomas Adamcik
b2cb3136b2 Rename tests 2010-10-29 21:27:40 +02:00
Thomas Adamcik
488ac28431 Add key parameter to track_to_mpd_format 2010-10-29 21:25:02 +02:00
Thomas Adamcik
151b1c3b4e Add explicit tests for position and cpid in track_to_mpd_format 2010-10-29 21:23:15 +02:00
Thomas Adamcik
cf516c5ef0 Ensure that mpd_format_track handles file: properly 2010-10-29 21:17:08 +02:00
Thomas Adamcik
014e29ffa2 Fix uri_to_mpd_relative_path so that it handles None 2010-10-29 21:15:32 +02:00
Thomas Adamcik
44012b30b0 Add uri_to_mpd_relative_path 2010-10-29 20:33:13 +02:00
Thomas Adamcik
02df8ca033 Start writting tracks_to_tag_cache_format 2010-10-29 20:04:53 +02:00
Thomas Adamcik
3e595213ac Ensure that result has exact right number of elements 2010-10-29 19:34:33 +02:00
Stein Magnus Jodal
c9535ffe10 Setting the state to STOPPED right before starting a track makes the test fail as it should 2010-10-24 20:40:47 +02:00
Stein Magnus Jodal
24015cafa8 Merge branch 'develop' into feature/playid-minus-one-should-resume 2010-10-24 20:15:34 +02:00
Stein Magnus Jodal
37426c6b54 Formatting 2010-10-21 23:32:36 +02:00
Stein Magnus Jodal
1d25a2ddea Remove redundant calls to playback.on_current_playlist_change() 2010-10-21 23:25:52 +02:00
Stein Magnus Jodal
3cfc282acc Add regression test for GH-22 2010-10-21 23:11:36 +02:00
Stein Magnus Jodal
abe54aacb0 Merge branch 'release/0.1.1' into develop
Conflicts:
	docs/changes.rst
2010-10-21 22:30:39 +02:00
Stein Magnus Jodal
e2a4aaada7 Add regression test for GH-17 2010-10-21 22:11:24 +02:00
Stein Magnus Jodal
51065c5e0a Merge branch 'hotfix/GH-18' into develop
Conflicts:
	mopidy/backends/base/playback.py
2010-10-19 12:43:20 +02:00
Stein Magnus Jodal
e4c3a73f8f Merge branch 'hotfix/GH-18' into release/0.1.1 2010-10-19 12:42:26 +02:00
Stein Magnus Jodal
3a951ca948 Seed the random function to make the test predictable 2010-10-19 12:41:18 +02:00
Stein Magnus Jodal
5cdfbce122 Add regression test for GH-18 2010-10-04 23:18:32 +02:00
Stein Magnus Jodal
6dbb550f98 Merge branch 'feature/fix-mpd-list' into develop 2010-10-04 22:27:18 +02:00
Stein Magnus Jodal
8fe261322f Add test to check that "playid -1" resume playback
The problem is, the test shouldn't pass, but it does.
2010-10-04 22:17:03 +02:00
Stein Magnus Jodal
9b73cbb18d Add more tests to prove the new 'list' query hendling 2010-08-28 16:27:28 +02:00
Stein Magnus Jodal
4b4c4b709e Rewrite list command to support more advanced queries 2010-08-28 16:07:44 +02:00
Stein Magnus Jodal
d6798ac870 Fix GH-16: 'addid ""' crashes with SpotifyError 2010-08-26 19:04:13 +02:00
Stein Magnus Jodal
c89d58fccf Fix 'add ' and 'addid ' 2010-08-24 23:11:22 +02:00
Stein Magnus Jodal
10c1cab0c7 Reorganize mopidy.frontends.mpd
- Rename .frontend.MpdFrontend to .dispatcher.MpdDispatcher, as it
  dispatches requests.
- Move exceptions into .exceptions.
- Move .server.MpdSession to .session.MpdSession.
- Move handle_pattern to .protocol.handle_pattern.
2010-08-19 23:51:46 +02:00
Stein Magnus Jodal
7d04550f53 Remove unused imports 2010-08-17 02:38:55 +02:00
Stein Magnus Jodal
148612d842 Merge remote branch 'knutz3n/add_invalid_url_fix' into gstreamer 2010-08-16 22:38:08 +02:00
Johannes Knutsen
7674775718 Don't call lookup on backends with uris they don't support 2010-08-16 22:34:00 +02:00
Stein Magnus Jodal
73258d6f9d Reimplement 'load' using SPC.get() instead of search() 2010-08-16 22:33:04 +02:00
Stein Magnus Jodal
d7bf31bab4 Rename CurrentPlaylistController.{load => append} 2010-08-16 21:34:06 +02:00
Stein Magnus Jodal
b7030b127a MPD: Fix 'play[id] -1' behaviour when current track is set 2010-08-14 21:58:39 +02:00
Johannes Knutsen
00f59e590b test seek with songpos 2010-08-14 16:00:06 +02:00
Johannes Knutsen
8599bcd491 test seekid updates cpid 2010-08-14 15:59:46 +02:00
Johannes Knutsen
fe9ad74e1b fixed test_seek and test_seekid 2010-08-14 15:44:05 +02:00
Stein Magnus Jodal
5d9fd5b625 MPD: Update tests and fix 'playlistfind' 2010-08-14 14:42:44 +02:00
Stein Magnus Jodal
908ad5016f Merge master into gstreamer 2010-08-14 14:30:12 +02:00
Stein Magnus Jodal
abcc9c1007 MPD: Improve seek impl and add seekid impl. Add tests which fails. 2010-08-14 14:10:44 +02:00
Stein Magnus Jodal
da2a44fd17 Fix 400 or so tests broken by changing the mixer constructor 2010-08-14 04:07:50 +02:00
Johannes Knutsen
e1f8a0bf72 Rename mopidy.frontends.mpd.{serializer => translator} to match naming in backends. 2010-08-13 20:48:38 +02:00
Stein Magnus Jodal
635791cf0e MPD: Support missing quotes for 'consume', 'random', 'repeat', and
'single' to work with BitMPC.
2010-08-13 13:33:15 +02:00
Stein Magnus Jodal
9f71c1533a MPD: Support 'play' without quotes to work with BitMPC 2010-08-13 13:09:03 +02:00
Stein Magnus Jodal
5393407571 MPD: Support 'plchanges' without quotes to work with BitMPC 2010-08-13 13:04:56 +02:00
Stein Magnus Jodal
a3fb8a1f72 MPD: Support 'pause' without args to work with MPDroid 2010-08-13 12:26:34 +02:00
Stein Magnus Jodal
255d70d1ae MPD: Support 'plchanges "-1"' to work better with MPDroid 2010-08-13 12:20:51 +02:00
Stein Magnus Jodal
d0aac71cfb MPD: Split protocol implementation into 11 modules 2010-08-10 02:08:59 +02:00
Stein Magnus Jodal
b4c91af7d7 Relocate MPD frontend to 'mopidy.frontends.mpd' 2010-08-09 21:17:36 +02:00