Commit Graph

5987 Commits

Author SHA1 Message Date
Thomas Adamcik
f4c501a08f local: Reuse the mtime we already found in local scan 2014-12-23 23:25:47 +01:00
Stein Magnus Jodal
c8c44c868b Merge branch 'release/v0.19.x' into develop 2014-12-23 22:58:54 +01:00
Stein Magnus Jodal
302bb7c221 ext: Fix unpacking of VersionConflict exception
Fixes #911
2014-12-23 22:58:19 +01:00
Thomas Adamcik
60aec2dc95 docs: Update changelog with audio taglist changes etc 2014-12-23 22:39:37 +01:00
Stein Magnus Jodal
6ec35b2d02 Merge branch 'release/v0.19.x' into develop 2014-12-23 22:23:32 +01:00
Stein Magnus Jodal
fcf39833ca config: Support UTF-8 in default config
Fixes issue reported at https://discuss.mopidy.com/t/428.

Mopidy-HTTP-Kuechenradio includes a non-ASCII UTF-8 character in its
default config. If Mopidy didn't already have a config file, it crashed
when trying to create the initial config file based on the default
config of all available extensions.
2014-12-23 22:21:10 +01:00
Stein Magnus Jodal
aa3b8ab5f8 path: Support unicode content when creating file 2014-12-23 22:21:10 +01:00
Stein Magnus Jodal
532905bd74 docs: Add :discuss: shortcut for linking to forum threads 2014-12-23 22:21:10 +01:00
Thomas Adamcik
935a038405 audio: Only add albums that have a name
Fixes case where we could have an empty album. We could alternatively be more
conservative and only limit to fully empty albums. But I think we only want
ones with names anyway.
2014-12-22 22:45:31 +01:00
Thomas Adamcik
819680e074 audio: Move utils test to tests folder 2014-12-22 22:34:11 +01:00
Thomas Adamcik
9b9cdc3ade stream: Fix track conversion bug and add tests
This adds basic checks for the library provider lookup:

- Check that uri schemes are respected
- Check that blacklisting and globbing works
- Check uri successfully gets converted to a track
2014-12-22 22:29:36 +01:00
Stein Magnus Jodal
afcc77d3f8 Merge branch 'release/v0.19.x' into develop 2014-12-21 23:47:04 +01:00
Thomas Adamcik
94bdb88b9c http: Log errors instead of dying for HTTP startup.
(cherry picked from commit 9a2f8a3e4f)

Conflicts:
	docs/changelog.rst
2014-12-21 23:46:35 +01:00
Thomas Adamcik
77dc046efd audio: Fix rST formatting in docstring 2014-12-21 21:49:51 +01:00
Thomas Adamcik
7b36a598bb review: Fix typos found in PR#915 feedback 2014-12-21 21:48:09 +01:00
Thomas Adamcik
32da1cb8e9 local: Use MIN_DURATION_MS in log message 2014-12-21 21:46:21 +01:00
Thomas Adamcik
9a2f8a3e4f http: Log errors instead of dying for HTTP startup. 2014-12-20 21:32:08 +01:00
Thomas Adamcik
b6cf86c6a2 startup: Log backend and frontend startup times.
Allows us to debug cases where a "bad" extension is blocking the startup.  In
there future we might also warning log extension that take longer than some
threshold to help find these cases.
2014-12-19 22:37:48 +01:00
Thomas Adamcik
9be788b129 audio: Move tags to track conversion to audio utils 2014-12-18 23:36:56 +01:00
Thomas Adamcik
983148a9a4 audio: Start storing the tags we find in audio
Adds a new get_currents_tags method for fetching the full set of current tags.
There are still some untested cases for this, and I also suspect we still want
some API refinements one core starts using this.
2014-12-18 23:28:19 +01:00
Thomas Adamcik
bc347f1650 audio: Fix minor typo in a debug log message 2014-12-18 23:28:19 +01:00
Thomas Adamcik
6c62252919 audio: Add tags changed event to audio.
Current version simply emits the keys of the changed tags to the audio
listener. Following change will add support for storing the actual data.
2014-12-18 23:28:19 +01:00
Thomas Adamcik
de6bd63481 audio: Remove min duration code from scanner.
The local scanner now handles this itself by looking at the duration.
2014-12-18 23:28:19 +01:00
Thomas Adamcik
4f8244c499 audio: Convert audio_data_to_track to tags_to_track
The new function only uses tags as input. In other words we now need to set
length, uri and mtime ourselves. Users of scan APIs have been updated.
2014-12-18 23:28:19 +01:00
Thomas Adamcik
4948dee4b9 audio: Make scanner return duration in milliseconds
Also ensures that we normalize unknown duration to None instead of -1.
2014-12-18 23:28:19 +01:00
Thomas Adamcik
d9d501cd98 audio: Update scanner to just return tags+duration
The caller should know what URI we are talking about. Additionally finding the
mtime is never belonged in this class and has been moved out.
2014-12-18 23:28:19 +01:00
Thomas Adamcik
dcaa0f6732 local: Move musicbrainz cover art helper to translator 2014-12-18 23:28:14 +01:00
Stein Magnus Jodal
70829390d1 docs: Fix typo 2014-12-16 23:39:22 +01:00
Stein Magnus Jodal
44599f1163 Merge branch 'release/v0.19.x' into develop
Conflicts:
	.mailmap
	AUTHORS
2014-12-16 23:38:39 +01:00
Stein Magnus Jodal
b300c09034 docs: Update authors 2014-12-16 23:35:42 +01:00
Stein Magnus Jodal
188c9ef26f docs: Update changelog 2014-12-16 23:34:00 +01:00
Thomas Amland
d2bf3f6d83 [local] fix modified files not being updated
(cherry picked from commit dfd897832a)
2014-12-16 23:31:00 +01:00
Thomas Adamcik
b365d2494b mpd: Remove "Comment" tag type from translator output.
Newer versions of the protocol have removed this tag, so we should as well.
This also works around the issue of #881 which was breaking things with
newlines in comment fields.

The readcomments command seems to replace this, but it seems to only care about
specific extra tagtypes, not the general comment tag we normally collect when
scanning things.

(cherry picked from commit 08a8d5c43b)
2014-12-16 23:30:38 +01:00
Stein Magnus Jodal
6e55435aa9 mpd: Enable browsing of empty dirs
This was disabled together with a bunch of other changes without any
explanation in commit f24ca36e5a. I'm
guessing that this wasn't intentional, and no test covered the case.

(cherry picked from commit 4e508cd017)
2014-12-16 23:25:31 +01:00
Stein Magnus Jodal
d057e5abdb Merge branch 'release/v0.19.x' into develop 2014-12-16 23:23:11 +01:00
Stein Magnus Jodal
a00bfb7fa1 Merge branch 'master' into release/v0.19.x 2014-12-16 23:22:16 +01:00
Stein Magnus Jodal
217919884e docs: Edit Raspbmc appendix a bit 2014-12-16 23:20:18 +01:00
Deni Bertovic
02489b02be Add appendinx about xbmc issues
XBMC won't boot because a different libtag version got
installed with mopidy system wide, and XBMC picks that up
insted of the one it vendors in. Added info how to fix this.
2014-12-16 23:08:50 +01:00
Stein Magnus Jodal
f1fd21f647 docs: Add upmpdcli as an alternative to Rygel
Based on PR #871 by @woutervanwijk.

Fixes #871
2014-12-16 23:01:52 +01:00
Thomas Adamcik
90fdd46109 local: Cleanup translator tests 2014-12-14 23:14:11 +01:00
Thomas Adamcik
671ee5ee6a audio: Switch to using converted taglists instead of raw data. 2014-12-14 22:25:52 +01:00
Thomas Adamcik
f477e9176e audio: Add helper for converting taglists
Goal is simply to avoid leaking gst types to the rest of mopidy. Only part we
will be leaking is the tag keys. Which we can live with.
2014-12-14 22:23:13 +01:00
Stein Magnus Jodal
84897dde05 Merge pull request #907 from adamcik/feature/mpd-remove-comments
Feature/mpd remove comments
2014-12-14 18:08:29 +01:00
Thomas Adamcik
541412dbfc mpd: Remove newline escaping code.
This was added for #881, where the correct fix turned out to be to remove
comments from the responses. We should still add some sanity checks for
verifying that our responses at the very least only contain printable chars.
2014-12-14 14:35:13 +01:00
Thomas Adamcik
08a8d5c43b mpd: Remove "Comment" tag type from translator output.
Newer versions of the protocol have removed this tag, so we should as well.
This also works around the issue of #881 which was breaking things with
newlines in comment fields.

The readcomments command seems to replace this, but it seems to only care about
specific extra tagtypes, not the general comment tag we normally collect when
scanning things.
2014-12-14 14:16:37 +01:00
Thomas Adamcik
2c3217685b utils: Switch to exceptions.FindError for errors. 2014-12-14 14:08:45 +01:00
Thomas Adamcik
5015a7ff28 docs: Update authors and changelog 2014-12-14 13:37:13 +01:00
Thomas Adamcik
f99028ce41 Merge pull request #882 from lukasvogel/develop
Escape newline characters when dispatching data
2014-12-14 13:19:21 +01:00
Thomas Adamcik
1404f379ca Merge pull request #904 from tamland/tag_refresh
local: fix modified files not being updated
2014-12-14 13:17:09 +01:00
Thomas Adamcik
2be42b0848 Merge pull request #906 from jodal/feature/mpd-browse-empty-dir
mpd: Enable browsing of empty dirs
2014-12-14 13:14:21 +01:00