andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #1520 from bchretien/topic/fix-mpd-protocol

Browse Source 
mpd: fix protocol for replay_gain_status
This commit is contained in:
Nick Steel 2016-05-31 17:10:54 +01:00
commit 2fe9fbb9af
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/changelog.rst
View File

@ -38,6 +38,9 @@ Bug fix release.
where a :confval:`file/media_dirs` path contained non-ASCII characters. where a :confval:`file/media_dirs` path contained non-ASCII characters.
(Fixes: :issue:`1345`, PR: :issue:`1493`) (Fixes: :issue:`1345`, PR: :issue:`1493`)
- MPD: Fix MPD protocol for ``replay_gain_status`` command. The actual command
remains unimplemented. (PR: :issue:`1520`)
v2.0.0 (2016-02-15) v2.0.0 (2016-02-15)
=================== ===================

2
mopidy/mpd/protocol/playback.py
View File

@ -325,7 +325,7 @@ def replay_gain_status(context):
Prints replay gain options. Currently, only the variable Prints replay gain options. Currently, only the variable
``replay_gain_mode`` is returned. ``replay_gain_mode`` is returned.
""" """
return 'off' # TODO return 'replay_gain_mode: off' # TODO
@protocol.commands.add('seek', songpos=protocol.UINT, seconds=protocol.UINT) @protocol.commands.add('seek', songpos=protocol.UINT, seconds=protocol.UINT)

2
tests/mpd/protocol/test_playback.py
View File

@ -115,7 +115,7 @@ class PlaybackOptionsHandlerTest(protocol.BaseTestCase):
def test_replay_gain_status_default(self): def test_replay_gain_status_default(self):
self.send_request('replay_gain_status') self.send_request('replay_gain_status')
self.assertInResponse('OK') self.assertInResponse('OK')
self.assertInResponse('off') self.assertInResponse('replay_gain_mode: off')
def test_mixrampdb(self): def test_mixrampdb(self):
self.send_request('mixrampdb "10"') self.send_request('mixrampdb "10"')