Commit Graph

2288 Commits

Author SHA1 Message Date
ismailof
19818d3f68 Add MPD nextsong/nextsongid test case 2016-06-06 23:20:13 +02:00
Benjamin Chrétien
37cd296552 mpd: fix protocol for replay_gain_status 2016-05-31 16:36:37 +02:00
Jens Luetjen
c24380679f Test only events triggered after seek 2016-04-09 11:10:21 +02:00
Jens Luetjen
b55996da6a Changed wording export/restore to save/load 2016-04-02 16:28:04 +02:00
Jens Luetjen
00c47117d5 Test models.MixerState.mute 2016-04-02 16:11:47 +02:00
Jens Luetjen
ac47d254a3 Remove dead code for 'play-always' 2016-04-02 15:58:05 +02:00
Jens Luetjen
6ee36752bd Test whole save/load state. 2016-04-01 22:16:05 +02:00
Jens Luetjen
6e33bbcadd Replace restore/export with load/save
Rename _restore_state to _load_state
Rename _export_state to _save_state
2016-04-01 19:50:37 +02:00
Jens Luetjen
cf5dfccee2 Rename PlaybackState.position to time_position. 2016-04-01 19:13:26 +02:00
Jens Luetjen
3251722a28 Rename storage.save() to storage.dump().
The name matches the load/dump in the json library.
Import olny storage from mopidy.internal (not all of mopidy.internal).
2016-03-31 21:55:32 +02:00
Jens Luetjen
7928caeb71 Persist mixer mute state.
Restore mixer.mute state at start.
Update mopidy.models docstrings.
2016-03-31 21:30:48 +02:00
Jens Luetjen
d4d2ad80dc Changed name persistant file to 'state.json.gz'
Changed filename from persistent.state to state.json.gz. Now the
file extension matches the content.
2016-03-31 20:24:31 +02:00
Jens Luetjen
2bb9e39ba6 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 2016-03-31 19:04:45 +02:00
Stein Magnus Jodal
8820a88e0c file: Fix crash when media_dirs contains non-ASCII chars
Fixes #1345
2016-03-26 11:30:35 +01:00
Jens Luetjen
bf4da7a627 Add tests to ensure that play, next will not busy-loop
Test PlaybackController functions play(), next(), previous()
and _on_about_to_finish() that they will not loop forever
if all tracks are unplayable.
2016-03-26 09:43:38 +01:00
Jens Luetjen
3eac589557 Try to restore state only one time.
Delete the persistant file after read. If something
goes wrong during restore, the next start is clean.
2016-02-29 20:47:11 +01:00
Jens Luetjen
854357a295 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs
Conflicts:
	mopidy/core/playback.py
	tests/core/test_playback.py

revert _backend_error_handling
revert endless loop prevention
2016-02-17 22:18:50 +01:00
Thomas Adamcik
f53a0d2200 stream: Address review comments for PR#1447 2016-02-15 20:46:43 +01:00
Thomas Adamcik
ce81b362dc stream: Add scheme and blacklist check to translate_uri
We don't bother with this inside the unwrap code as if something redirects us
so be it.
2016-02-15 00:00:30 +01:00
Thomas Adamcik
a6495e0ecd stream: Update library tests to include backend 2016-02-14 23:49:05 +01:00
Thomas Adamcik
9296ddd75b stream: Update playback tests to include backend 2016-02-14 23:47:51 +01:00
Thomas Adamcik
79a4835e4e core: Add tests for change_track failing in about-to-finish 2016-02-14 17:23:20 +01:00
Thomas Adamcik
76ab5ffb04 core: Make sure exceptions from backend's change_track is handled
Also adds TODOs for the rest of the backend calls in playback which all need to
assume backends can and will screw up.
2016-02-14 17:16:31 +01:00
Stein Magnus Jodal
9b18ff07ee core: Readd regression test for #1352
Fixes #1418

Based on test that was present in 1.1.2 but dropped in the #1400 merge.
2016-02-14 16:12:45 +01:00
Stein Magnus Jodal
a42ce9f00e core: Test next/prev skips over unplayable tracks
Fixes #1418

Based on tests that was present in 1.1.2 but dropped in the #1400 merge.
2016-02-14 15:47:22 +01:00
Stein Magnus Jodal
cc82e68a58 core: Remove unplayable track in consume mode
Fixes #1418

This was previously fixed in 1.1.2, but the fix was skipped in when
release-1.1 was merged into develop in #1400, thus no changelog entry.
2016-02-14 15:47:22 +01:00
Stein Magnus Jodal
0539e4e8fe Revert "core: Add TODO for testing unplayable-by-backend tracks"
This reverts commit 3a8d896146.
2016-02-14 15:47:18 +01:00
Stein Magnus Jodal
3a8d896146 core: Add TODO for testing unplayable-by-backend tracks 2016-02-14 12:49:15 +01:00
Thomas Kemmer
6aef96a0d3 Fix #1428: Add m3u/base_dir confval. 2016-02-14 12:07:22 +01:00
Trygve Aaberge
3e781310f9 tests: Add buffer_time to test config 2016-02-14 00:15:27 +01:00
Jens Luetjen
bc981355bc Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 2016-02-08 18:45:58 +01:00
Stein Magnus Jodal
cd83084804 tests: Merge TestPlayUnknownHandling into TestUnplayableURI 2016-02-07 22:01:33 +01:00
Stein Magnus Jodal
1f4f0ab03b tests: Prefix some test classes with 'Test'
We don't want to rely on them subclassing unittest.TestCase.
2016-02-07 22:00:16 +01:00
Stein Magnus Jodal
3f7fbf67f3 Fix remaining gi.repository imports 2016-02-07 12:45:12 +01:00
Jens Luetjen
9d8034869d Chance type of core.restore_state config value
Change to boolean to simplify the user configuration.
2016-02-06 15:48:43 +01:00
Jens Luetjen
d8405082e9 Test tracklist.get_version() change.
The tracklist version shall increase when loading state.
2016-02-04 21:14:20 +01:00
Jens Luetjen
49325c62dd Test tracklist.get_version() change.
The tracklist version shall increase when loading state.
2016-02-04 20:54:49 +01:00
Jens Luetjen
0a1e43c876 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs
Conflicts:
	mopidy/audio/scan.py
Fix conflicts.
2016-02-03 22:01:51 +01:00
Stein Magnus Jodal
d9f53d5da3 gst1: Move all gi imports to a helper module 2016-02-01 23:09:28 +01:00
Stein Magnus Jodal
e68c4668fe audio: Fallback to datetime tag if no date tag 2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
9657004b77 audio: Move date tag from Track to Album
The Track model doesn't have a date attribute.
2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
f877ac0807 audio: Add support for GLib.Date tag values 2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
0fa78b8e39 gst1: Fix datetime tag conversion 2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
df62997186 audio: Decode tags to unicode 2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
8b543bad44 local: URIs should be unicode
Any non-ASCII content is uriencoded anyway.
2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
31c894030d audio: Move tag helpers to mopidy.audio.tags 2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
7926ef1f12 gst1: Fail if trying to create buffers without audio
Which causes lots of failed assertion messages from GStreamer
2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
ef5281488b gst1: Fix buffer.pts not being set if 0 2016-01-31 21:07:17 +01:00
Stein Magnus Jodal
eb4c742015 gst1: Run gst.init() if needed everywhere using Gst 2016-01-31 21:07:16 +01:00
Stein Magnus Jodal
592f5dec53 gst1: Remove deprecated GObject.threads_init()
Ref https://wiki.gnome.org/Projects/PyGObject/Threading

"The requirement to call GObject.threads_init() has been removed from
PyGObject 3.10.2 when using Python native threads with GI (via the
threading module) as well as with GI repositories which manage their own
threads that may call back into Python (like GStreamer callbacks). The
GObject.threads_init() function will still exist for the entire 3.x
series for compatibility reasons but emits a deprecation warning."
2016-01-31 21:07:16 +01:00
Stein Magnus Jodal
dfaed1e4c2 gst1: Replace STATE_* with State.* 2016-01-31 21:07:14 +01:00
Stein Magnus Jodal
1d269af210 gst1: Call Gst.init() and remove sys.argv hack
GStreamer no longer use sys.argv directly. If you want GStreamer to
handle command line arguments, you must pass them explicitly to
Gst.init().
2016-01-31 21:07:14 +01:00
Stein Magnus Jodal
8c82f4773f gst1: Update imports to use PyGI 2016-01-31 21:07:14 +01:00
Stein Magnus Jodal
2232260d1b tests: Fix typo, don't use deprecated API 2016-01-31 07:50:43 +01:00
Stein Magnus Jodal
adb260af05 Merge branch 'release-1.1' into develop
Fixes #1400
2016-01-31 07:47:47 +01:00
Jens Luetjen
e434556048 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs
Conflicts:
	docs/changelog.rst
	mopidy/audio/scan.py

Resoved conflict.
2016-01-21 19:33:58 +01:00
jcass
2fcbc691c0 fix:add changelog entry and fix line indentation. 2016-01-21 05:55:37 +02:00
jcass
dee7eb7e20 tests:fix pep8 violation. 2016-01-20 15:55:02 +02:00
jcass
239a7be708 fix: ensure that tl_track information is included in event trigger when consume mode is enabled. 2016-01-20 15:41:58 +02:00
Stein Magnus Jodal
14444fe24f mpd: Add volume command 2016-01-17 22:28:23 +01:00
Stein Magnus Jodal
f15b4e7327 mpd: Move setvol tests to its own test case 2016-01-17 22:28:12 +01:00
Jens Luetjen
606e87b1bb Make export/restore state internal
- drop filename parameter
- make save_state/load_state internal
- remove save_state/load_state from docu and RPC.
- remove models load/save from docu
- build the config path
- folder for 'core' state files
- move restore_state-to-coverage-translation into a method
2016-01-14 19:56:38 +01:00
Jens Luetjen
4869619bb9 New CoreState to hold all core states
- Introduce a CoreState class that holds all core states
- Move xState classes to internal
- Use validation.check_instance for consistent error messages
- Store tlid instead of TlTrack to restore last played track
2016-01-10 13:24:14 +01:00
Jens Luetjen
74344f2b19 Use tlid instead of full tl_track
To export/restore the PlayState the tlid is enough.
2016-01-09 12:52:01 +01:00
Jens Luetjen
46bb780a46 Rename TracklistState 'tracks' to 'tl_tracks'
Correct documentation.
2016-01-09 11:46:09 +01:00
jcass
c2c2aa0322 Handle missing or empty 'port' configuration parameter.
(cherry picked from commit 3488e6442d)
2016-01-05 21:17:59 +01:00
Jens Luetjen
0b0cbc87d4 Merge branch 'develop' into fix/310-persist-mopidy-state-between-runs
Conflicts:
	docs/changelog.rst

Fixed conflict in doc/changelog.rst
2016-01-05 08:16:51 +01:00
Jens Luetjen
d5a45516ef Adujst test code for testing auto-play 2016-01-05 07:53:45 +01:00
Thomas Kemmer
b2d1e1b4f7 m3u: Major refactoring, add default_encoding and default_extension settings. 2016-01-04 14:19:49 +01:00
Stein Magnus Jodal
456dbe6c3a tests: Fix mock usage 2016-01-03 23:41:34 +01:00
jcass
4e63e4280c Merge remote-tracking branch 'upstream/release-1.1' into fix/1378 2016-01-04 00:04:42 +02:00
Jens Luetjen
e56c39ee78 Add unit tests for export/restore core state
Fix issues shown by test code
2016-01-03 18:29:35 +01:00
Jens Luetjen
a5a9178b06 Use model(s) to save/restore current play state 2016-01-02 15:28:41 +01:00
Stein Magnus Jodal
f2194e9d5e fix: skip uplayable tracks when the next track is selected while in a paused state. 2016-01-02 15:51:17 +02:00
Stein Magnus Jodal
094a874055 core: Make lookup() ignore tracks without URI
Fixes #1340
2016-01-01 23:44:26 +01:00
Stein Magnus Jodal
6afd5b0c70 Fix tests and update changelog 2016-01-01 23:13:42 +01:00
Stein Magnus Jodal
811131f716 Merge pull request #1371 from jcass77/enhance/format_proxy
Handle missing or empty 'port' configuration parameter.
2015-12-29 14:41:58 +01:00
Stein Magnus Jodal
c47c929440 Merge PR #1356 from jcass77/fix/1352 into release-1.1 2015-12-29 14:37:08 +01:00
Stein Magnus Jodal
4fba994441 Merge pull request #1377 from jcass77/test/pr_1356_resume_unplayable_track
test: Test case for skipping unplayable tracks when paused.
2015-12-29 08:53:12 +01:00
jcass
07a0f8ff3e test: Test case to ensure that unplayable tracks are skipped over in PAUSE state.
Ensures that pause->next->resume handles unplayable tracks just like stop->next->play does.
2015-12-29 07:54:49 +02:00
Stein Magnus Jodal
5462f0e319 Merge pull request #1369 from tkem/m3u-fix-1364
m3u: Derive track name from file name for non-extended M3U playlists.
2015-12-29 02:02:48 +01:00
jcass
3488e6442d Handle missing or empty 'port' configuration parameter. 2015-12-26 15:28:07 +02:00
Thomas Kemmer
22690ee5a9 m3u: Derive track name from file name for non-extended M3U playlists. 2015-12-23 18:14:19 +01:00
Thomas Kemmer
ef1468d8d6 core: Add PlaylistsController.get_uri_schemes(). 2015-12-13 19:02:33 +01:00
Stein Magnus Jodal
be5bdb8a85 Fix review comments on PR#1359 2015-12-12 11:01:52 +01:00
jcass
e9eb9d61b4 Test cases for issue #1358 2015-12-11 07:47:07 +02:00
jcass
3cd3b45512 Fix flake8 errors. 2015-12-07 07:56:35 +02:00
jcass
fb7b466bee Result of prepare_change no longer affects whether a track is added to the history.
Update changelog and test cases.
2015-12-07 07:53:34 +02:00
jcass
2b00e83179 Mark track as playing and add to history if changing track while paused. 2015-12-06 19:16:20 +02:00
Stein Magnus Jodal
3e259f1c00 Merge pull request #1347 from adamcik/feature/mpd-idle-cleanup
MPD idle cleanup
2015-12-05 21:36:11 +01:00
Stein Magnus Jodal
23cdeb208b Merge pull request #1346 from adamcik/feature/eot-seek-handling
Gapless aware seek handling
2015-12-05 21:34:51 +01:00
Stein Magnus Jodal
23d83a833f Merge pull request #1349 from adamcik/feature/mpd-playlists-error-handling
MPD playlist editing error handling
2015-12-05 21:14:55 +01:00
Thomas Adamcik
00b52da6ab mpd: Make sure rename error handling is correct 2015-12-05 14:30:18 +01:00
Thomas Adamcik
9ac1760dd1 mpd: Update playlistmove to check names and indexes 2015-12-05 14:11:27 +01:00
Thomas Adamcik
5de9495eaa mpd: Update playlistdelete to handle unknown names and indexes 2015-12-05 14:01:43 +01:00
Thomas Adamcik
b21debf6ee mpd: Sanity check stored playlist names 2015-12-05 13:51:36 +01:00
Thomas Adamcik
c3393d3d85 mpd: Refresh mapping when name is not present (Fixes #1348) 2015-12-05 12:49:45 +01:00
Thomas Adamcik
98e19e803b mpd: Deleting unkown playlist should return not found 2015-12-05 12:48:14 +01:00
Thomas Adamcik
07328e7dd2 mpd: Map playlists_loaded to idle event stored_playlist 2015-12-05 11:08:33 +01:00
Stein Magnus Jodal
28224cef8c audio: Fix tests not exiting normally 2015-12-05 00:34:33 +01:00