Commit Graph

1857 Commits

Author SHA1 Message Date
Stein Magnus Jodal
59760bb36c web: Remove WebSocket demo page 2014-06-21 23:27:35 +02:00
Trygve Aaberge
0c3e5bd71e mpd: Test that empty query parts are ignored 2014-06-21 17:29:41 +02:00
Thomas Adamcik
7975815cde audio: Expand audio state changed with target state 2014-06-21 17:28:25 +02:00
Stein Magnus Jodal
fbcc73004d http: Redirect from /app to /app/ 2014-06-21 16:36:16 +02:00
Stein Magnus Jodal
6c6600c37b http: Group HTTP server tests 2014-06-21 16:21:39 +02:00
dz0ny
7c428ce8d2 Fix http router so it can handle /{ext_name} same as /{ext_name}/ 2014-06-21 15:05:13 +02:00
Trygve Aaberge
81898cb709 mpd: Test order of result from lsinfo 2014-06-21 14:42:35 +02:00
Thomas Adamcik
2e1ca08fef audio: Use on buffering internal in buferring tests 2014-06-21 14:20:56 +02:00
Thomas Adamcik
58976ef52d config: Lists need to handle missing values 2014-06-21 14:11:24 +02:00
Trygve Aaberge
0b7243dce1 mpd: Test albums in listall(info) 2014-06-21 01:52:44 +02:00
Stein Magnus Jodal
4cd545e147 Merge branch 'trygveaa/feature/mpd-browse-playlists' into develop 2014-06-20 22:19:48 +02:00
Trygve Aaberge
496b3f5552 mpd: Test playlists in listall(info) 2014-06-20 22:16:27 +02:00
Thomas Adamcik
c87684aa6b audio: Handle all caps ASX tags.
Also add support for simple asx format.
2014-06-20 21:31:03 +02:00
Stein Magnus Jodal
720a403439 http: Remove unused Router class 2014-06-04 21:32:54 +02:00
Stein Magnus Jodal
33228f2528 http: Simplify app registration 2014-06-04 21:32:19 +02:00
Stein Magnus Jodal
b6ab29eed4 http: Remove unused code 2014-06-04 21:02:33 +02:00
Stein Magnus Jodal
d13194dfa4 http: Remove static file serving from the Router 2014-06-04 20:55:28 +02:00
Stein Magnus Jodal
eea6138b3d http: Simplify static files serving 2014-06-04 20:47:49 +02:00
Stein Magnus Jodal
684a64405d http: Move MopidyHttpRouter into handlers module 2014-05-22 21:03:42 +02:00
Stein Magnus Jodal
1223103e8f http: Test that routers can mount WSGI apps 2014-05-21 00:38:38 +02:00
Stein Magnus Jodal
fe9a126a2a http: Enforce router's URL namespace 2014-05-20 23:53:26 +02:00
Stein Magnus Jodal
4b383c1762 http: Move Mopidy request handlers to a MopidyHttpRouter 2014-05-20 23:49:22 +02:00
Stein Magnus Jodal
5d1f8f2203 http: Give routers access to the core API 2014-05-20 23:30:49 +02:00
Stein Magnus Jodal
5897675eab http: Split tests into three files 2014-05-20 23:07:28 +02:00
Stein Magnus Jodal
e9ff16fe63 http: Simplify test imports 2014-05-20 22:55:37 +02:00
Stein Magnus Jodal
6d04aaf3e4 http: More consistent use of 'request handler' 2014-05-20 22:50:45 +02:00
Stein Magnus Jodal
ea5a317b00 http: Avoid tornado import before extension is loaded, group all handlers 2014-05-20 22:36:15 +02:00
Stein Magnus Jodal
1a72f68707 http: Import modules, not attributes 2014-05-20 22:32:45 +02:00
Stein Magnus Jodal
1838f10dcf http: Rename 'setup_routes()' to 'get_request_handlers()' 2014-05-20 22:28:18 +02:00
Stein Magnus Jodal
e8291d471e http: Rename 'linkify()' to 'get_root_url()' 2014-05-20 22:16:01 +02:00
Stein Magnus Jodal
cad0207ef8 http: Rename 'path' to 'static_file_path' 2014-05-20 22:12:06 +02:00
dz0ny
031c7c8e93 Add: Tornado as required dependency
Fix: Remove draft76
Fix: Remove class attributes for ws handler
Revert: default to /ws/ for for mopidy.html
2014-05-12 16:16:08 +02:00
dz0ny
73721c77ad Fix: Fields order doesn't matter for json. Test for valid dict and data only 2014-05-12 15:14:42 +02:00
dz0ny
26833b4093 Fix: Import order for whole PR 2014-05-12 14:54:50 +02:00
dz0ny
f1d1a4713b Squashed commit of the following:
commit dbb7005aa866cdc337bde9c8169e9bf15e5c8042
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 11 22:12:58 2014 +0200

    Fix: Make PR mergable

commit 5bb27da72c4276a930bf33955e6583f6781d23f6
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 23:31:54 2014 +0200

    Add: helper method for extensin url

commit 8a348b26b65102084a606ff73384a478bb785cf1
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 00:35:50 2014 +0200

    Add: Refactor ws and rpc to handlers, reuse code

commit 677c809d2b39a6c982ab835368fdb8a3ad9d1a92
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 00:18:10 2014 +0200

    Fix: Return proper HTTP headers

commit fe5fea2fc2a0d28a39532d6d4cd2b21013d57d24
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Wed May 7 23:48:19 2014 +0200

    Add: RPC post handler
    Add: tests for http post handler

commit e77e60310853b368758b09b303a96a95ff1b9b93
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 22:15:04 2014 +0200

    Add: Documentation on how to extend http api

commit a3a14fb5d15f095e5bab23a590e0a8360a039f9a
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 19:48:34 2014 +0200

    Add: HTTP tests for default router and static handler

commit 0d9544256bcb8f048eaedb5cdd57b1de027d387b
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:44:32 2014 +0200

    Fix: Move StaticFileHandler to main http package

commit c83c9f661e658e4a843dc5c8c6ba5dc3f1ea9c1e
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:29:49 2014 +0200

    Add: default Router implementation

commit 258cb7210bdf13833884c04cfb7fb4fa704394a7
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:00:46 2014 +0200

    Add: Switch to registry for router registration

commit b7bfe7b814235b030d7ac30de90e2331e3d809d3
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 21:52:58 2014 +0200

    Fix: Private methods
    Fix: Point to mopidy.html instead main.html
    Fix: Less noise in console

commit 232abe3029e93f78ce25db0c1bd44743cc23ed2d
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 21:32:07 2014 +0200

    Fix: Start IOLoop in separate thread, so actor can stop it

commit d686892c2fa993cbedc99c8e8e7f9c961ac6f35a
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 19:30:49 2014 +0200

    Fix: Router load order
    Fix: JS helper library WSS default url
    Add: Handlers from extensions

commit a1b0f5673a6719f229df27feccb284324675e9d1
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 14:53:30 2014 +0200

    Add: Switch to Tornado framework
2014-05-12 14:54:50 +02:00
Stein Magnus Jodal
95c06f40db audio: Fix test setup 2014-05-12 14:52:45 +02:00
Thomas Adamcik
e4e7b20f74 flake: Fix stupid flake error caused by newly added check 2014-05-08 22:57:02 +02:00
Thomas Adamcik
56b9724ffc Merge pull request #715 from geigerzaehler/gst-buffer
Pause gstreamer when buffering
2014-05-08 22:07:13 +02:00
Stein Magnus Jodal
b754885064 Fix all import order warnings 2014-05-07 20:08:43 +02:00
Stein Magnus Jodal
2979de0f94 http: Polish Mopidy-HTTP Zeroconf service
Builds upon #725 to:

- Remove extra config for Mopidy-HTTP Zeroconf service
- Refactor Zeroconf setup code in the HTTP frontend a bit
- Add documentation
2014-05-06 23:20:14 +02:00
Stein Magnus Jodal
1b5c21452f Merge wlcx/feature/zeroconf-announce-mopidy into develop 2014-05-06 23:16:26 +02:00
Sam Willcocks
05089fba3b Update tests to add zeroconf-websocket config option 2014-04-27 17:50:41 +01:00
Trygve Aaberge
d62ad966af network: Respond to messages before closing connections
This makes a connection tell the actor to stop the connection, instead
of stopping it itself. This is preferable, because other messages sent
to the actor that is not processed yet, may now send data to the client.

E.g. it makes this work:
$ echo status | nc localhost 6600
2014-04-25 06:11:01 +02:00
Thomas Scholtes
2b7ff237b8 Add tests for Audio buffering 2014-04-03 21:43:56 +02:00
Stein Magnus Jodal
5583ca5aba New flake8 version with new checks to conform to 2014-03-29 20:47:42 +01:00
Stein Magnus Jodal
957036c899 Merge pull request #707 into develop
Improve scan performance for remote filesystems
2014-03-02 08:34:54 +01:00
Stein Magnus Jodal
061ff00a39 tests: Don't depend on the order of random sequences 2014-02-28 01:17:53 +01:00
Thomas Adamcik
7386dd30b6 utils: Remove old find_files 2014-02-26 23:53:12 +01:00
Thomas Adamcik
5b7a6065e7 util: Add find_mtimes helper 2014-02-26 23:27:44 +01:00
Stein Magnus Jodal
30dde4e593 ext: Remove old extension API
As far as I know, all extensions except Mopidy-Arcam (not currently
maintained) and Mopidy-VKontakte already use the new API. Both of the
remaining extensions got open pull requests with the needed changes to use the
new API.
2014-02-17 11:44:57 +01:00
Thomas Adamcik
79ce2ab902 Merge branch 'develop' into feature/mpd-tokenized-requests
Conflicts:
	docs/changelog.rst
2014-02-16 23:22:07 +01:00
Thomas Adamcik
8756c2bff5 review: Type fixing 2014-02-16 23:17:46 +01:00
Stein Magnus Jodal
4df730742d Release v0.18.3 2014-02-16 21:46:21 +01:00
Stein Magnus Jodal
fa15e7a264 Bump version number to 0.18.2 2014-02-16 21:24:57 +01:00
Thomas Adamcik
2e6f716b72 Merge branch 'develop' into feature/mpd-tokenized-requests
Conflicts:
	mopidy/mpd/protocol/stored_playlists.py
2014-01-30 22:48:28 +01:00
Thomas Adamcik
e4932c05b1 audio: Add more TODOs 2014-01-30 22:21:59 +01:00
Stein Magnus Jodal
38d3c6ccf9 models: Make Playlist.last_modified milliseconds since Unix epoch 2014-01-28 23:57:02 +01:00
Thomas Adamcik
dd98ad8353 audio: Update tests and dummy audio actor to pass 2014-01-28 23:19:33 +01:00
Thomas Adamcik
d1b91117b4 audio: Update dummy audio used for testing 2014-01-28 21:34:31 +01:00
Thomas Adamcik
0d18bdea79 audio: Add about to finish callback support 2014-01-27 23:43:11 +01:00
Thomas Adamcik
99d581f7fc audio: Add position_changed event to know when seeks happen 2014-01-27 23:04:15 +01:00
Thomas Adamcik
6490d5bd2d audio: Add more tests for audio events 2014-01-27 22:34:42 +01:00
Thomas Adamcik
a4315251ca audio: Slight test refactor to not hide what is going on 2014-01-26 23:30:12 +01:00
Thomas Adamcik
d962277bc9 audio: Add stream_changed event plus tests 2014-01-26 23:27:30 +01:00
Thomas Adamcik
f24ca36e5a mpd: Switch browse commands to common helper 2014-01-25 00:42:32 +01:00
Thomas Adamcik
3cec929bd7 Merge branch 'develop' into feature/mpd-tokenized-requests
Conflicts:
	mopidy/mpd/protocol/music_db.py
	tests/mpd/protocol/test_music_db.py
2014-01-24 19:38:56 +01:00
Thomas Adamcik
da724e6b77 Merge remote-tracking branch 'UncommonGoods/develop' into develop 2014-01-24 19:31:25 +01:00
Thomas Adamcik
e304b7fc2b mpd: Use mopidy.mpd.exceptions in commands 2014-01-24 01:12:26 +01:00
Thomas Adamcik
86f5602023 mpd: Remove old command handlers 2014-01-24 00:35:10 +01:00
Thomas Adamcik
dc8d311bc3 mpd: Complete music db conversion with list 2014-01-24 00:23:05 +01:00
Thomas Adamcik
68aa0b556c mpd: Convert search functions in music db 2014-01-23 23:58:42 +01:00
Stein Magnus Jodal
bf9499131a Bump version number to 0.18.1 2014-01-23 23:19:51 +01:00
Thomas Adamcik
8f8bed5b87 mpd: Implement playlistinfo from current playlist 2014-01-23 23:12:25 +01:00
Thomas Adamcik
fddb299ed9 mpd: Update type converters naming and add UINT
Also adds tests for RANGE helper.
2014-01-23 21:31:18 +01:00
Thomas Adamcik
eb85f92d96 mpd: Store auth required and if command should be listed 2014-01-22 23:27:25 +01:00
nathanharper
039fc4b681 refactored mpd.protocol.music_db regex
got quote backreference working,
eliminated need for the non-capturing pattern,
fixed problem with quoted fields.
2014-01-22 05:16:38 -05:00
Thomas Adamcik
066fed1522 mpd: Update tokenizer to use mopidy.mpd.exceptions 2014-01-22 00:10:30 +01:00
Thomas Adamcik
756cf1518b mpd: Add last missing error cases for tokenizer.
If we decide that exact error message parity is not needed these can and should
be removed as they complicate the tokenizer.
2014-01-21 23:20:24 +01:00
Thomas Adamcik
f7ec1fba01 mpd: Fix tokenizer error messages to match original protocol 2014-01-21 22:10:00 +01:00
Thomas Adamcik
f7aff706a8 mpd: Move commands tests to mpd directory 2014-01-21 21:14:30 +01:00
Thomas Adamcik
d445740318 mpd: Split out tokenizer and add proper errors. 2014-01-21 21:10:55 +01:00
Thomas Adamcik
335cf4e612 mpd: Return command name in find handler. 2014-01-21 20:40:49 +01:00
Thomas Adamcik
3c0cc1564c local: Make browse test check ordering again 2014-01-20 23:22:15 +01:00
Thomas Adamcik
9ba168e9b9 local: Update browse cache code to add all directories
Tests have been updated to make sure multiple folders are added. We had
forgotten to add child folders to the ones that had already been created.
2014-01-19 22:21:02 +01:00
Thomas Adamcik
455f3dd403 mpd: Write commands helper for tokenized command handling
This provides a class which works as a command registry. Functions are added to
the registry through a method on the class `add`.  Add acts as a decorator
taking in the name of the command and optionally type converters for arguments.

When handling requests, we can now tokenize the line, and then just pass the
arguments to our commands helper. It will lookup the correct handler and apply
any validation before calling the original function.

For the sake of testing the original function is not wrapped. This the
functions, and anything testing them directly can simply assume pre-converted
data as long as type annotations are in place.

A sample usage would be:

    @protocol.commands.add('addid', position=protocol.integer)
    def addid(context, uri, position=None)
        pass

    def handle_request(line):
        tokens = protocol.tokenizer(line)
        context = ...
        result = protocol.commands.call(tokens, context=context)
2014-01-19 19:59:07 +01:00
Thomas Adamcik
b34a8c1f73 mpd: Add MPD tokenizer
- Adds tests for correctness of tokenizer (which also would have shown shlex
  wouldn't have worked).
- Should conform with the original's behavior, though we won't be able to match
  the error messages without a lot of extra work as a non-regexp version is
  likely a no go on python due to speed.
2014-01-19 13:47:09 +01:00
Stein Magnus Jodal
1ea0978af5 dummy: Move dummy backend back into the mopidy package 2014-01-18 01:38:10 +01:00
Thomas Adamcik
e97e620635 local: Rename json test to new naming scheme 2014-01-18 01:35:33 +01:00
Stein Magnus Jodal
da71d7fb14 Merge pull request #647 from adamcik/feature/browse-by-uri
Convert browse API to be fully URI based.
2014-01-17 15:58:39 -08:00
Stein Magnus Jodal
31abe0bc93 mpd: Annotate exceptions with current command automatically (fixes #649) 2014-01-18 00:34:41 +01:00
Stein Magnus Jodal
06856851f7 local: Make search filters more robust (fixes #635) 2014-01-17 23:43:43 +01:00
Thomas Adamcik
43e16ddb65 mpd: Switch mpd to use path<->uri mapping for browsing 2014-01-17 17:16:24 +01:00
Thomas Adamcik
d6aa9fb013 local: Convert local browsing to uri based system. 2014-01-17 17:16:24 +01:00
Thomas Adamcik
999f478010 core: Update browse to use uri isntead of path 2014-01-17 17:16:24 +01:00
Thomas Adamcik
826419d829 backend/core: Switch to root_directory instead of name 2014-01-16 22:53:18 +01:00
Stein Magnus Jodal
300c5d2e64 Merge pull request #644 from adamcik/feature/scanner-tag-handling
Cleanup taglist handling and translation to tracks.
2014-01-15 15:10:26 -08:00
Stein Magnus Jodal
06719d0e66 Bump version to 0.18.0a1 for easier testing of updated extensions 2014-01-15 23:51:28 +01:00
Thomas Adamcik
81b920a9e4 model: Update to handle None in sets.
Also adds some missing tests for composers and performers.
2014-01-15 22:20:36 +01:00
Thomas Adamcik
3e9cd0c4b7 audio: Add tests for all fields that can be converted 2014-01-15 22:20:36 +01:00
Thomas Adamcik
ac9f106107 audio: Update how translator test data is built. 2014-01-15 22:20:36 +01:00
Thomas Adamcik
b0b5d4972f models: Make .copy(foo=None) null out field. 2014-01-15 22:20:36 +01:00
Thomas Adamcik
807bedad85 audio: Change audio data convert to operate on taglists 2014-01-15 22:20:36 +01:00
Thomas Adamcik
7209b38aa6 audio: Nest tags in scan data return value 2014-01-15 22:20:36 +01:00
Thomas Adamcik
57798a2757 audio: Ensure tests can be run on their own 2014-01-15 22:20:35 +01:00
Stein Magnus Jodal
d698653d83 mpd: Implement "listallinfo" command (fixes #145) 2014-01-15 01:11:27 +01:00
Stein Magnus Jodal
afbff12ccc mpd: Implement "listall" command 2014-01-15 00:52:01 +01:00
Stein Magnus Jodal
c781f77ef3 Rename test files to pattern expected by test runners 2014-01-15 00:01:50 +01:00
Stein Magnus Jodal
ead48f61cb Merge pull request #641 from jodal/feature/consistent-playback-events
Make core playback events consistent
2014-01-14 14:55:21 -08:00
Stein Magnus Jodal
c6cff2794c Merge pull request #640 from adamcik/feature/local-browse
Add local browsing
2014-01-14 14:43:31 -08:00
Thomas Adamcik
03838a1968 mpd: Add tests for adding VFS folders 2014-01-14 23:29:52 +01:00
Thomas Adamcik
a8458720ee local: Review fixes 2014-01-14 22:07:20 +01:00
Stein Magnus Jodal
1d108752f6 core: Make events emitted on playback consistent (fixes #629)
This commit does not try to make the events correct/perfect with regard to
GStreamer states, end-of-stream signalling, etc. It only tries to make the
events work consistently across all the methods on the playback controller.

* play(track) while already playing has changed from:

  - playback_state_changed(old_state='playing', new_state='playing')
  - track_playback_started(track=...)

  to:

  - playback_state_changed(old_state='playing', new_state='stopped')
  - track_playback_ended(track=..., time_position=...)
  - playback_state_changed(old_state='stopped', new_state='playing')
  - track_playback_started(track=...)

* next() has changed from:

  - track_playback_ended(track=..., time_position=...)
  - playback_state_changed(old_state='playing', new_state='stopped')
  - track_playback_ended(track=..., time_position=0)
  - playback_state_changed(old_state='stopped', new_state='playing')
  - track_playback_started(track=...)

  to same as play() above.

* previous() has changed in the same way as next().

* on_end_of_track() has changed from:

  - track_playback_ended(track=..., time_position=...)
  - playback_state_changed(old_state='playing', new_state='playing')
  - track_playback_started(track=...)

  to same as play() above.

* stop() has reordered its events from:

  - track_playback_ended(track=..., time_position=...)
  - playback_state_changed(old_state='playing', new_state='stopped')

  to:

  - playback_state_changed(old_state='playing', new_state='stopped')
  - track_playback_ended(track=..., time_position=...)
2014-01-14 01:18:39 +01:00
Thomas Adamcik
82584eb21a local: Add browser support for json library. 2014-01-13 23:43:55 +01:00
Stein Magnus Jodal
e071a161d6 Merge pull request #634 from sdbakker/enhancement/mixer-volume
Mixer volume in config
2014-01-13 13:27:51 -08:00
Stein Magnus Jodal
05632c3b8b backend: Update backend API imports 2014-01-11 18:20:45 +01:00
Stein Magnus Jodal
d724001f5b tests: Move mopidy.backends.dummy to tests.dummy_backend 2014-01-11 15:49:22 +01:00
Stein Magnus Jodal
2731d23578 local: Move mopidy.{backends => }.local 2014-01-11 15:17:05 +01:00
Simon de Bakker
ca35094554 Forgot to adapt tests for audio actor 2014-01-10 23:38:59 +01:00
Thomas Adamcik
cb97def432 Merge pull request #626 from jodal/feature/library-browse
Library browsing support in backend and core API and MPD lsinfo command
2014-01-09 13:20:40 -08:00
Thomas Adamcik
c51fdc68a2 Merge branch 'feature/extm3u' of https://github.com/tkem/mopidy into develop
Conflicts:
	mopidy/backends/local/translator.py
2014-01-09 22:14:29 +01:00
Stein Magnus Jodal
fe28311324 models: Use new Ref constructors 2014-01-09 08:54:33 +01:00
Stein Magnus Jodal
9da5ccbb79 models: Add type specific constructors to Ref 2014-01-09 08:50:31 +01:00
Stein Magnus Jodal
1fd1a38013 Merge branch 'develop' into feature/library-browse
Conflicts:
	mopidy/backends/local/json/library.py
	mopidy/core/actor.py
	tests/backends/local/library_test.py
2014-01-09 08:39:38 +01:00
Stein Magnus Jodal
28cf3228b2 Merge pull request #617 from adamcik/feature/extension-registry
Switch to registry for most of mopidy extension hooks
2014-01-08 23:32:06 -08:00
Thomas Adamcik
96eb9a87c6 mpd: Whitespace fix to make travis happy. 2014-01-09 00:41:46 +01:00
kingosticks
f2a26ef246 Fixed line length for flake 2014-01-08 23:04:38 +00:00
kingosticks
0d74be0b1e Empty MPD commands should return an error instead of OK, just like the original MPD server. Includes tests. 2014-01-06 12:33:20 +00:00
Stein Magnus Jodal
252f4792a0 core: Check if library is browsable at startup 2014-01-03 23:12:03 +01:00
Stein Magnus Jodal
69836d2e16 backend: Rename library.name to library.root_directory_name 2014-01-03 23:10:02 +01:00
Stein Magnus Jodal
af3b0e40fd models: Add Ref.type constants 2014-01-03 22:19:54 +01:00
Stein Magnus Jodal
048c3bb544 core: Use library name instead of URI scheme in browse() 2014-01-02 23:10:15 +01:00
Stein Magnus Jodal
7dba0dafa5 mpd: Include dirs and files in lsinfo response 2014-01-02 22:06:33 +01:00
Stein Magnus Jodal
6027ed1fac core: Add library.browse() 2014-01-02 22:06:33 +01:00
Stein Magnus Jodal
a3731c8187 backend: Add library.browse() 2014-01-02 22:06:32 +01:00
Thomas Adamcik
702befd6ae Merge branch 'develop' into feature/extension-registry
Conflicts:
	setup.py
2013-12-31 15:34:02 +01:00
Thomas Adamcik
29bb2d52b6 local: Re-add test for #500 fix. 2013-12-31 15:31:09 +01:00
Thomas Adamcik
e82ce6256d core: Re-add one uri scheme per backend constraint. 2013-12-31 14:45:57 +01:00
Stein Magnus Jodal
4b9ab5fcbc Remove empty "frontends" packages 2013-12-31 14:14:19 +01:00
Stein Magnus Jodal
1ee534126e mpd: Move mopidy.{frontends => }.mpd 2013-12-31 14:11:16 +01:00
Stein Magnus Jodal
621aff22c9 http: Move mopidy.{frontends => }.http 2013-12-31 14:04:25 +01:00
Thomas Adamcik
60112d7c6f Merge branch 'develop' into feature/extension-registry 2013-12-30 00:37:17 +01:00
Stein Magnus Jodal
e87d5729e3 models: Add lightweight Ref model with URI, name, and type 2013-12-29 19:31:14 +01:00
Thomas Adamcik
d93d3e6fcd local: Add local/library config value
- Updated library provider to support missing library
- Added config value to select local library provider
- Updated tests to use library config value
2013-12-24 00:22:58 +01:00
Thomas Adamcik
e065f349db local: Add local library provider back
- Re-add a local library provider that uses our new library interface
- Re-add our json library using the new interface
- Hardcode these to use each other for now
- Scanner bit is still missing, will re-add in one of the next commits
- Bypassed test for #500 for the time being
2013-12-23 23:43:04 +01:00
Thomas Adamcik
353782e2c8 local: Add local/data_dir config value.
Not in use yet but, needed for future changes planed in this branch.
2013-12-23 21:40:35 +01:00
Stein Magnus Jodal
3859448e06 core: Test version property, fix typo in changelog 2013-12-15 22:49:33 +01:00
Thomas Kemmer
9bf7e39425 fix flake8 error E302 2013-12-10 06:57:16 +01:00
Thomas Kemmer
584dc1eaf6 add playlists test for writing EXTM3U files 2013-12-09 16:13:05 +01:00
Thomas Kemmer
18c44e0d8a add translator tests for EXTM3U files 2013-12-09 15:54:28 +01:00
Thomas Kemmer
b6ee1707d3 add translator tests for EXTM3U files 2013-12-09 15:52:46 +01:00
Thomas Kemmer
a5c02c1034 basic EXTM3U playlist support 2013-12-08 15:23:23 +01:00
Thomas Adamcik
9c2d38e989 local: Remove tag cache support
- Updates doc references to tag cache
- Removes tag cache from config and marks it deprecated
- Removes tag cache from setup.py
- Removes tag cache from config converter
- Removes tag cache from tests
- Converts local library tests to use JSON.
2013-12-04 22:38:16 +01:00
Thomas Adamcik
da63942b48 config: Improve handling of Deprecated config values 2013-12-04 22:38:16 +01:00
Thomas Adamcik
26ec956a08 config: Add deprecated config value support.
This makes it possible to mark a key as deprecated, this implies it will be
ignored if present, and never included in the resulting config.
2013-11-29 00:15:03 +01:00
Thomas Adamcik
3bbcb4d121 local: Review comment fixes 2013-11-28 23:20:03 +01:00
Thomas Adamcik
603b57ef3c utils: Remove find_uris and update find_files
- find_uris is no more
- find_files now returns file paths relative to path being searched
- find_files now only works on directories
- find_files tests have been updated to reflect changes
- local scanner has gotten a minimal update to reflect this alteration
2013-11-27 22:50:35 +01:00
Thomas Adamcik
c025b87076 tagcache: Split out to own extension for eventual deletion. 2013-11-27 00:04:51 +01:00
Thomas Adamcik
04044d035f core: Refactor core Backends helper
Replaces the jungle of extra dicts/lists with an OrderedDict per backend
feature type. Also makes sure that each type/scheme is unique instead of
the scheme alone.
2013-11-27 00:04:51 +01:00
Thomas Adamcik
ff9f473c2f local: Move tag cache translators and tests out. 2013-11-26 17:47:52 +01:00
Thomas Adamcik
774e629425 config: Fix review comments. 2013-11-23 07:18:57 +01:00
Thomas Adamcik
b22d7bee0b utils: Add mkdir and content options to get_or_create_file
This lets callers control is parent directories are created, and set the
default content of the file.
2013-11-22 07:17:02 +01:00
Stein Magnus Jodal
8ea996de13 Revert "tests: Don't redefine PYTHONPATH"
This reverts commit 6be5cc0f1b.
2013-11-20 23:13:31 +01:00
Stein Magnus Jodal
6be5cc0f1b tests: Don't redefine PYTHONPATH
Shot in the dark to get Travis to find dbus-python when running the `mopidy`
command as a subprocess of the tests.
2013-11-20 22:40:12 +01:00
Stein Magnus Jodal
b0cffb8681 mpd: Move query_from_mpd_search_format into only module using it 2013-11-17 16:00:15 +01:00
Thomas Adamcik
03c301705d commands: Move mopidy.utils.command to mopidy.commands
- Also adds documenation to Command class.
- Moves scan command to commands to match naming.
2013-11-16 03:02:45 +01:00
Thomas Adamcik
2f6ecd9171 commands: Move to using a help attribute instead of __doc__ 2013-11-16 02:26:47 +01:00
Thomas Adamcik
37ba3ca01d Merge branch 'develop' into feature/commands-helper-tmp
Conflicts:
	mopidy/utils/log.py
2013-11-14 23:36:27 +01:00
Thomas Adamcik
c0f1a1352b commands: Replace set_defaults with set method
For our use case we only need to be able to override a value, not set defaults
so this simplifies everything.
2013-11-14 23:31:20 +01:00
Thomas Adamcik
39f7fd5955 commands: Extend use of exit helper to parser errors
This moves all the bad arugment handling into our class and makes sure to mark
all the helpers as internal.
2013-11-14 23:31:20 +01:00
Thomas Adamcik
d82f48a42f commands: Internalise handling of help action
This means help will always be handled by the root command. Additionally this
adds an exit helper.
2013-11-14 23:31:20 +01:00
Thomas Adamcik
0b1b249ae8 commands: Remove trailing newline for command errors 2013-11-14 23:31:20 +01:00
Thomas Adamcik
1394f3929b commands: Add run method to Commands 2013-11-14 23:31:20 +01:00
Thomas Adamcik
f5a5f9e9b1 commands: Add str method CommandError 2013-11-14 23:31:20 +01:00
Thomas Adamcik
b5360a1360 commands: Add usage to CommandError 2013-11-14 23:31:20 +01:00
Thomas Adamcik
001c8e0bdc commands: Add set_defaults() to the parser
- Removes mock based test that checks delegation, just check commands result
- Allow setting of defaults that propegate down the chain
- Move internal parser args to a _parse helper.
2013-11-14 23:31:20 +01:00
Thomas Adamcik
6bddcb7875 commands: Add help_formatter() with tests. 2013-11-14 23:31:20 +01:00
Thomas Adamcik
88bc046605 commands: Make sure parser errors get translated to correct error type. 2013-11-14 23:31:20 +01:00
Thomas Adamcik
fa7eee3bdf commands: Add basic format usage helper 2013-11-14 23:31:20 +01:00
Thomas Adamcik
754865d8b6 commands: Set child names upon adding them 2013-11-14 23:31:20 +01:00
Thomas Adamcik
7c82485a07 commands: Start adding commands util helper.
This class is intended to be used to contruct a tree of sub-commands. In this
intial version it mainly focuses on exposing `add_argument` to allow for nested
parsers. Next step is to start adding better `--help` that shows the entire tree
and hooking it up to select what code path to really run.
2013-11-14 23:31:20 +01:00
Lasse Bigum
f5e94d8f7c Address review comments 2013-11-13 00:40:47 +01:00
Lasse Bigum
9ba5f6862f Merge branch 'develop' of https://github.com/mopidy/mopidy into feature/extra_tags 2013-11-13 00:23:44 +01:00
Stein Magnus Jodal
04788abaac core: Change tracklist.{filter,remove} usage
The criterias are now a mapping between field names and one or more values.
This aligns tracklist.{filter,remove} with the API of
library.{find_exact,search}, and allows for e.g. batch removals.

An exception is raised immediately if the API is used in the old way to ease
migration and debugging.
2013-11-12 00:00:22 +01:00
Stein Magnus Jodal
4e7c2bab4d Merge branch 'develop' into feature/filter_improvement 2013-11-11 23:18:23 +01:00
Stein Magnus Jodal
a289d831d0 Merge pull request #569 from ZenithDK/scan_multiple_artist
Fix scan with multiple track artists and add tests
2013-11-11 14:07:36 -08:00
Stein Magnus Jodal
924553b62e http: Fix tests 2013-11-11 22:40:45 +01:00
Lasse Bigum
2bd1f043ce Updated code with new multiple artist handling and added tests 2013-11-09 03:01:53 +01:00
Lasse Bigum
8b7621c3e3 Merge branch 'develop' of https://github.com/mopidy/mopidy into feature/extra_tags 2013-11-09 02:37:44 +01:00
Lasse Bigum
c776565f65 Another round of review comments 2013-11-09 01:22:27 +01:00
Lasse Bigum
093c0400a9 Fix review comments 2013-11-08 21:43:31 +01:00
Lasse Bigum
03750a8bf2 Fix scan with multiple track artists and add tests 2013-11-08 21:25:21 +01:00
Thomas Adamcik
9539c2ac35 main: Switch to subcommands
- show-deps replaced with 'mopidy deps'
- show-config replaced with 'mopidy config'
- Just running mopidy now displays help, run 'mopidy run' to start server.
2013-11-08 19:53:00 +01:00
Javier Domingo Cansino
6721a59b26 tests: Fixing self confusion mistake
docs: Documenting tracklist's new filter() feature
2013-11-07 09:46:34 +01:00
Javier Domingo Cansino
8b5f30e5ff Adding test case 2013-11-07 09:34:40 +01:00
Thomas Adamcik
469f414c4c audio: Don't do duration conversion to ms in scanner 2013-11-06 19:10:49 +01:00
Thomas Adamcik
20b0602842 audio/scanner: Move translator into audio.
Tries to move more of the gst bits and pieces we are leaking into audio.
2013-11-06 19:10:49 +01:00
Thomas Adamcik
0a2d74eff1 scanner: Update to use new mopidy.audio.scan
Also adds the check less than 100ms check back to the scanner.
2013-11-06 19:10:49 +01:00
Lasse Bigum
af6225538d Add more tests 2013-11-05 23:17:15 +01:00
Lasse Bigum
9d7db4cf4f Add frontend MPD tests for 'search comment "foo"' 2013-11-03 01:52:34 +01:00
Lasse Bigum
a516d2051d Added a ton of extra tests and expanded a few to include new tags 2013-11-03 01:01:42 +01:00
Lasse Bigum
f90f5f608e Fix testcases after merging mopidy/develop 2013-11-02 23:44:33 +01:00
Lasse Bigum
e12a75c880 Merge branch 'develop' of https://github.com/mopidy/mopidy into feature/extra_tags 2013-11-02 23:39:19 +01:00
Lasse Bigum
9593da08b6 Rename track in MPD to track_name to avoid confusion 2013-11-02 22:34:26 +01:00
Stein Magnus Jodal
838f584e2b local: Formatting 2013-11-02 22:18:37 +01:00
Stein Magnus Jodal
b0d43444c2 local: Remove debug logging in tests 2013-11-02 22:18:26 +01:00
Lasse Bigum
f295cbd3cb Fix flake8 issues 2013-11-02 22:14:25 +01:00
Lasse Bigum
24944bd8e3 Split artist and albumartist dependency, update tests based on this 2013-11-02 22:13:54 +01:00
Lasse Bigum
86f18935fe Fix flake8 errors and add a few more tests 2013-11-02 21:57:53 +01:00
Lasse Bigum
fd213f2d78 Add tests for albumartist 2013-11-02 21:57:53 +01:00
Lasse Bigum
e7746dac1b Remove debug, make track_no more robust 2013-11-02 21:54:46 +01:00
Lasse Bigum
efc9fc75b5 Fix track_no 2013-11-02 21:49:44 +01:00
Stein Magnus Jodal
04d9fa667b deps: Don't strip last dir from dependency path 2013-11-02 19:25:06 +01:00
Lasse Bigum
2bbd9003a2 Date is not mandatory AFAICT 2013-11-02 03:07:13 +01:00
Lasse Bigum
df1820f0a7 Add genre, composer, and performer tags and use them 2013-11-02 02:29:37 +01:00
Stein Magnus Jodal
c3a9bc06ed Bump version for development 2013-10-27 22:44:10 +01:00
Stein Magnus Jodal
9064fc02fd Merge branch 'develop' into feature/mpd-search-by-albumartist
Conflicts:
	mopidy/frontends/mpd/protocol/music_db.py
	mopidy/frontends/mpd/translator.py
2013-10-27 21:30:58 +01:00
Stein Magnus Jodal
be6e6c9a93 local: Readd lost test assertion 2013-10-27 21:26:26 +01:00
Stein Magnus Jodal
c42dd1bf1d mpd: Add 'find track ""' test to match search tests 2013-10-27 21:23:45 +01:00
Stein Magnus Jodal
d13d9958b0 mpd: Formatting 2013-10-27 21:22:57 +01:00
Stein Magnus Jodal
f7e85b1f12 Merge branch 'develop' into feature/track_and_count 2013-10-27 21:04:09 +01:00
Stein Magnus Jodal
f9c09a8990 Merge pull request #548 from adamcik/feature/write-config
Prep work for adding a `mopidy config --set ...` type command.
2013-10-27 12:52:46 -07:00
Stein Magnus Jodal
24a2b08fc5 mpd: Don't return fake artists when searching by albumartist 2013-10-27 20:24:07 +01:00
Stein Magnus Jodal
dabddd81fd mpd: Accept 'albumartist' type to 'find' and 'search' commands 2013-10-27 20:22:45 +01:00
Thomas Adamcik
ecc0bae344 local: Delete uris in library refresh (fixes #500)
Makes sure we remove uri's that can no longer be found in the tag cache.
2013-10-27 14:10:56 +01:00
Thomas Adamcik
73f91710e1 config: Add postprocessor for converting config back.
Idea forward from here is that once we have a config sub command that we expose
a setting config values which will:

1. Run the preprocessor on the file to edit.
2. Load it into config parser.
3. Modify the value.
4. Write it to a io.ByteString
5. Run the postprocessor
6. Save the file with comments etc intact.
2013-10-27 12:30:02 +01:00
Thomas Adamcik
d5cb4282d9 config: Add preprocessor for preserving comments when editing configs.
Adds markers to configs files that ensures configparser won't mangle comments
in the files. Will be combined with a postprocessor that undoes these changes.
2013-10-27 11:38:01 +01:00
Stein Magnus Jodal
b0ae7d3c6f local: Fix crash on non-ASCII chars in URIs 2013-10-24 23:22:01 +02:00
Stein Magnus Jodal
e448d77eb7 mpd: Fix flipped mute logic 2013-10-24 22:20:07 +02:00
Lasse Bigum
457c39fc78 Remove duplicate test group, merge it into existing 2013-10-22 23:40:38 +02:00
Lasse Bigum
95046b4852 Fix small bug and fix test 2013-10-22 00:12:32 +02:00
Lasse Bigum
1975694d08 Changed track to track_no, fix code, add tests
Added testcases for track and count
2013-10-20 23:04:48 +02:00
Thomas Adamcik
84c373d7ea Merge branch 'develop' into fix/bug-496-handle-single
Conflicts:
	mopidy/core/tracklist.py
2013-10-20 22:46:35 +02:00
Thomas Adamcik
f1f223bba8 local: Fix handling of single in eot_track (fixes #496)
- Adds test cases for code paths that caused bug
- Short circuits EOT next track handling when in single mode.
2013-10-20 21:43:19 +02:00
Thomas Adamcik
7fc753d167 core/local: Update playback test with review comments.
- Fixes typo.
- Adds assert to better test intermediate state.
2013-10-20 21:16:18 +02:00
Thomas Adamcik
d978005008 core: flake8 fixes 2013-10-20 20:33:48 +02:00
Thomas Adamcik
40754bb2e0 core: Fix handling of shuffle (fixes #453)
- Shuffle internal list when random is enabled
- Use presence of tl_track to determine if this is first run to trigger
  subsequent shuffles.
2013-10-20 19:28:13 +02:00
Thomas Adamcik
66ae1b8eee local/core: Add and fix more random related tests.
- Adds tests for eot_track vs next_track as we were only testing the one code
  path.
- Makes test_random_until_end_of_playlist_and_play_from_start actually test
  random and not repeat.
- Adds test_play_track_then_enable_random which is the underlying bug covered
  by the regression test for issue #17.
2013-10-20 18:39:07 +02:00
Thomas Adamcik
025bafc114 local/core: Update random tests to be more predictable
- Replace setting the random seed with mocking out shuffle with reverse. This
  makes tests easier to reason about while still being able to test correct
  behaviour.
- Increases number of tracks to four to avoid test passing due to symetry in
  plain and reversed lists.
- Made test_eot_track_with_random_after_append_playlist actually test eot and
  not next.
- Found a test failure in handling of test_random_until_end_of_playlist, fix in
  next commit.
2013-10-20 18:39:07 +02:00
Stein Magnus Jodal
96008ca826 Merge pull request #539 from adamcik/fix/bug-527-temp-workaround
local: Temporary workaround for issue #527
2013-10-20 07:31:55 -07:00
Thomas Adamcik
fcd3e5d5cf local: Add test for fallback handling of unknown track uris in playlists
- Checks that adding a non local:track:... uri to a playlist and reading it
  back works.
- Also fixes mistake in API usage where we assumed lookup still raised
  LookupError.
2013-10-20 16:18:03 +02:00
Stein Magnus Jodal
c8886dec49 tests: Sort imports 2013-10-20 16:04:09 +02:00
Thomas Adamcik
2f01fc4e46 scanner: Review comments and flake fixes
- Move ScannerError to exceptions module.
- Subclass ScannerError from MopidyException.
- Fix import sorting.
2013-10-20 15:51:39 +02:00
Thomas Adamcik
a5a55952fb scanner: Switch to gst.pbutils.Discoverer and refactor API
- New API wraps gst.pbutils.Discoverer for mopidy use.
  - Custom scanner code removed.
- Callback based async API switched with simpler synchronous API
  - Scanner is feed one and one URI and returns the result or raises an error.
- Adds new ScannerError exception for error handling in scanner
- Limits local/scan_timeout to 1000-3600000 i.e. 1s to 1h
- Files with zero duration are now excluded.
- Mtime handling moved out of scanner so we can use it for streams etc.
2013-10-20 13:22:00 +02:00
Thomas Adamcik
e0bfe144f8 Merge pull request #532 from jodal/feature/search-by-albumartist
Search filtering by albumartist
2013-10-19 13:46:58 -07:00
Thomas Adamcik
c8f5c1aacf Merge pull request #537 from jodal/tidy-up-core
Core playback and tracklist modularity improvement v2
2013-10-19 13:24:21 -07:00
Stein Magnus Jodal
27a63b1688 local: Remove redundant test asserts 2013-10-19 22:17:08 +02:00
Stein Magnus Jodal
c850ed2698 Merge branch 'develop' into feature/search-by-albumartist
Conflicts:
	tests/backends/local/library_test.py
2013-10-19 22:15:50 +02:00
Stein Magnus Jodal
7d874873bd local: Include albumartist in 'any' searches 2013-10-19 22:14:53 +02:00
Stein Magnus Jodal
033e3ab813 jsonrpc: Test application error responses again
The test was modified to not fail after a refactoring, making it not test what
it was intended to test at all. This reverts the changes and updates the test
in another way, keeping the original intention.
2013-10-19 20:53:02 +02:00
Stein Magnus Jodal
d7552b2fe2 tests: Formatting 2013-10-19 20:53:02 +02:00