Commit Graph

1912 Commits

Author SHA1 Message Date
Thomas Adamcik
50f68064be core: Update PlaylistsController to catch backend exceptions 2015-04-06 02:13:51 +02:00
Thomas Adamcik
66771dec68 core: Update LibraryController to catch backend exceptions 2015-04-06 02:12:56 +02:00
Stein Magnus Jodal
c4940cbea2 autopep8: Add space after class signature/docstring 2015-04-03 00:05:26 +02:00
Thomas Adamcik
83c3d0013f Merge pull request #1096 from jodal/feature/faster-travis-build
travis: Use new faster build infrastructure
2015-04-02 21:41:43 +02:00
Stein Magnus Jodal
2bc63ec027 audio: Skip MP3 tests if missing plugin 2015-04-02 20:53:29 +02:00
Thomas Adamcik
9ede14f4a1 tests: Convert to using deprecation helpers across the board. 2015-03-30 23:50:54 +02:00
Thomas Adamcik
f4c93619d1 core: Make core tracklist.add(tracks=...) deprecation safe 2015-03-29 23:11:00 +02:00
Thomas Adamcik
dc673d554c tests: Ignore deprecated tracklist.add(tracks=...) in local tests
Note, this is mostly because these tests are just core tests in disguise and
need a lot more love than I can give them right now.
2015-03-29 23:11:00 +02:00
Thomas Adamcik
c85689edad mpd: Make mpd warnings safe with respect to tracklist.add(tracks=...) 2015-03-29 23:11:00 +02:00
Thomas Adamcik
f7399c1849 tests: Stop using playlist filters in mpd music_db tests 2015-03-29 23:11:00 +02:00
Thomas Adamcik
79b0584887 tests: Stop using tracklist add tracks in mpd status test 2015-03-29 23:11:00 +02:00
Thomas Adamcik
7d42d028c6 tests: Stop using tracklist tracks in mpd playback tests 2015-03-29 23:11:00 +02:00
Thomas Adamcik
faf8174ef7 tests: Update mpd.test_status to not use tracklist.add(tracks=...) 2015-03-29 23:11:00 +02:00
Thomas Adamcik
a8860faa35 tests: Cleanup mpd.protocol.current_playlist tests
- Split into smaller test cases more or less per command
- Created a BasePopulatedTracklistTestCase with a sensible setUp
- Modified test cases to work with the common tracklist state
- Replaced all calls to tracklist.add(tracks=...) with uris=...
- Test tracklist ordering in more compact way that also gives better error
  messages
2015-03-29 23:11:00 +02:00
Thomas Adamcik
d3b275e1a4 core: Mark tracklist.add by URI as deprecated 2015-03-29 23:11:00 +02:00
Thomas Adamcik
49fc9941a1 core: Mark searching via keyword argument based query deprecated 2015-03-29 23:11:00 +02:00
Thomas Adamcik
0ab52a73fa core: Mark library.lookup by uri deprecated
Updates core, mpd and tests to not use deprecated calls or safely catch them
when running with -W error.
2015-03-29 23:11:00 +02:00
Thomas Adamcik
f5f9899db9 tests: Make bases test classes in core 2015-03-29 23:10:58 +02:00
Thomas Adamcik
a54551d985 core: Mark get_playlists and filter as deprecated 2015-03-29 23:10:19 +02:00
Thomas Adamcik
5a3fb64250 core: Emit deprecation warning for library.find_exact 2015-03-29 23:08:03 +02:00
Thomas Adamcik
b31f0c421f tests: Make tests warning safe 2015-03-26 21:58:44 +01:00
Stein Magnus Jodal
2c11344434 dummy: Make it obvious that method is test-only 2015-03-25 13:16:27 +01:00
Stein Magnus Jodal
c9f60170f8 Merge pull request #1084 from tkem/feature/m3u_replace_invalid_chars
m3u: Replace slashes in playlist names with pipes.
2015-03-25 09:48:39 +01:00
Stein Magnus Jodal
36fba3d67d flake8: Fix unussed import 2015-03-25 09:48:24 +01:00
Thomas Kemmer
a9393c3850 m3u: Replace slashes in playlist names with pipes. 2015-03-25 05:36:03 +01:00
Stein Magnus Jodal
d768a3b4f7 Merge pull request #1082 from adamcik/feature/only-support-new-style-search-in-backends
core/backend: Stop supporting old search signatures
2015-03-25 00:09:06 +01:00
Stein Magnus Jodal
f2a56edbf0 dummy: Replace playlists property with test-only helper 2015-03-25 00:03:56 +01:00
Thomas Adamcik
ead725e995 core/backend: Stop supporting old search signatures
All backends are expected to support the exact argument. A friendly log message
will be printed to prompt users to upgrade backends that fail due to this.
2015-03-24 23:54:49 +01:00
Stein Magnus Jodal
a8e6cd26dc core: Warn if backend does not implement as_list()
Fixes #1080
2015-03-24 23:40:50 +01:00
Thomas Adamcik
141c14ad45 core: Add exact to search() and deprecate find_exact()
Backends that still implement find_exact will be called without exact as an
argument to search, and we will continue to use find_exact. Please remove
find_exact from such backends and switch to the new search API.
2015-03-24 09:31:03 +01:00
Stein Magnus Jodal
23e2295c46 dummy: Fix playlists.get_items() bug 2015-03-24 01:54:07 +01:00
Thomas Adamcik
24fe242d56 core/backend: Remove find_exact from backends
Functionality has been replaced with an `exact` param in the search method.
Backends that still implement find_exact will continue being called via
the old method for now.
2015-03-23 23:55:03 +01:00
Stein Magnus Jodal
07cf962434 Merge branch 'develop' into feature/new-playlists-api
Conflicts:
	docs/changelog.rst
2015-03-23 21:45:32 +01:00
Stein Magnus Jodal
dbe4165a0f m3u: Only test through core actor 2015-03-23 13:31:25 +01:00
Thomas Adamcik
6d22c4fd59 core: Remove set_current_tl_track 2015-03-23 00:50:05 +01:00
Thomas Adamcik
07f0453c6e core: Make event triggers internal 2015-03-23 00:50:05 +01:00
Stein Magnus Jodal
d37bd62bb1 backend: Remove playlists.playlists property 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
e3f2e368c7 m3u: Add playlists.get_items() 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
4bae9c874c m3u: Add playlists.as_list() 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
5693b454ee m3u: Use lookup() instead of playlists prop in tests 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
bd2e4f7af0 core: Reimplement get_playlists() using new backend API 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
4f3a0839b3 core: Add playlists.as_list() and playlists.get_items(uri) 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
55b1eb7383 backend: Add playlists.as_list() and playlists.get_items(uri) 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
9462071e0c Merge pull request #1074 from adamcik/fix/1069-handle-broken-backends
core: Protect against old clients that implement backend.play
2015-03-23 00:05:05 +01:00
Thomas Adamcik
a74bc24bdc core: Protect against old clients that implement backend.play 2015-03-22 23:54:37 +01:00
Thomas Adamcik
7ec2342921 core: Normalize search queries
This is needed as otherwise each and every backend needs to handle the fact
that some "bad" clients might send {'field': 'value'} instead of
{'field': ['value']} Though the real problem isn't the clients but our
organically grown query API.
2015-03-22 23:33:49 +01:00
Thomas Adamcik
28f8a99090 review: Fixed mock use and docstring 2015-03-22 23:14:29 +01:00
Thomas Adamcik
efe9430c7a core: Update playback code to take change track into account.
This change has us checking the return value of change_track when deciding if
the play call was a success or if the track is unplayable. Which ensures that
the following can no longer happen: 1) play stream 2) play stream that fails
change_track 3) stream 1) continues playing. Correct behavior being the next
stream playing instead.
2015-03-22 22:12:51 +01:00
Thomas Kemmer
67d4dac862 m3u: Store by URI internally
Based upon tkem's PR #1053
2015-03-22 21:54:29 +01:00
Stein Magnus Jodal
12649265b1 Bump version to 1.0.0
So that the development version of extensions can start depending on
1.0.0 and test that they work with the changed APIs.
2015-03-22 09:25:04 +01:00