Commit Graph

7635 Commits

Author SHA1 Message Date
Nick Steel
627684ec7b Updated playlistclear to use playlist lookup helper and added save failure tests. 2018-04-15 21:19:01 +01:00
nsteel
52a90a5a06 MPD's load and listplaylistinfo lookup track metadata. Fixes #1511.
Includes tests and refactored all playlist lookups to use helper.
2018-04-15 21:19:01 +01:00
Stein Magnus Jodal
53c8159bbc
Merge pull request #1668 from kingosticks/fix/cors
Protect RPC interface against CSRF
2018-04-15 22:14:46 +02:00
Nick Steel
ae4dab65e4 docs: added changelog entry 2018-04-15 17:46:46 +01:00
Nick Steel
1d6e081171 docs: mention that same-origin requests are always allowed. 2018-04-15 17:26:16 +01:00
Nick Steel
51741a7cbc HTTP: Apply allowed_origins to Websocket requests also. 2018-04-15 17:14:13 +01:00
Nick Steel
7caba4a05d docs: improved http/allowed_origins description. 2018-04-15 17:12:16 +01:00
Nick Steel
1b863b417b HTTP: New RPC CORS tests and fixed existing. 2018-04-15 17:12:16 +01:00
Nick Steel
ecb5a7038a docs: http/allowed_origins config setting description 2018-04-15 17:12:16 +01:00
Nick Steel
94ba9b6642 HTTP: Content-Type other than application/json is a 415 client error.
Also Fixed up formatting following code review.
2018-04-15 17:12:16 +01:00
Nick Steel
cd829c7042 HTTP: CSRF protection for RPC endpoint.
By now enforcing the Content-Type header is set to 'application/json', we force browsers attempting a cross-domain
request to first perform a CORS preflight OPTIONS request. This request always includes an Origin header which we
check against our whitelist. The whitelist contains the current Host as well as anything specified in the new optional
allowed_origins config value. Any non-browser tools must also now set the Context-type header.
2018-04-15 17:12:16 +01:00
Stein Magnus Jodal
41882c6395 http: Remove conditional only needed for Tornado < 3.2 2018-04-13 13:05:23 +02:00
Stein Magnus Jodal
3e91f9819d tests: Make DummyAudio reset position when URI changes 2018-04-09 23:46:30 +02:00
Stein Magnus Jodal
84aafaadcb docs: MPRIS playlists interface is implemented 2018-04-08 21:08:12 +02:00
Stein Magnus Jodal
fa70c1e527 docs: Fix testing example 2018-04-08 21:06:08 +02:00
Stein Magnus Jodal
4c4bdd4afc Update .mailmap and authors list 2018-04-06 23:03:07 +02:00
Stein Magnus Jodal
61deb461f2 tasks: Update to work with invoke >= 0.13 2018-04-06 22:16:44 +02:00
Stein Magnus Jodal
e6c89f3b6a docs: Tweak changelog 2018-04-06 22:11:47 +02:00
Stein Magnus Jodal
eed47a8ecf
Merge pull request #1666 from mattLLVW/feature/remove-max-track-length
config: remove 10000 tracks limitation in playlists
2018-04-06 21:58:26 +02:00
matt LLVW
2e6c0049a4 config: remove 10000 tracks limitation in playlists 2018-04-04 19:20:17 +02:00
Stein Magnus Jodal
2a0710876b tox: Upgrade pytest from <3.3 to >=3.3 2018-04-01 01:33:28 +02:00
Stein Magnus Jodal
2471e5d269 Upgrade pytest from <3.3 to >=3.3
Remove dependency on pytest-capturelog, which is included in pytest 3.3.
2018-04-01 01:23:10 +02:00
Stein Magnus Jodal
4581451973 docs: Update changelog 2018-03-30 11:59:46 +02:00
Stein Magnus Jodal
e215484c75 encoding: Never crash if unknown bytes in OS errors
Fixes #1599
2018-03-30 11:25:31 +02:00
Stein Magnus Jodal
f3c9387219 encoding: Fix assert to match test intention 2018-03-30 11:08:23 +02:00
Stein Magnus Jodal
cd2bbaba07 docs: Add PR#1611 to changelog 2018-03-30 10:44:08 +02:00
Stein Magnus Jodal
87ff8d9269
Merge pull request #1611 from BernhardGehl/patch-1
remove leftover utf-8 encode from path handling
2018-03-30 10:41:05 +02:00
Stein Magnus Jodal
c16d651263
Merge pull request #1665 from mopidy/feature/tornado-4.4
Require tornado >= 4.4
2018-03-29 20:58:51 +02:00
Stein Magnus Jodal
95577206a0 Require tornado >= 4.4 2018-03-29 20:51:01 +02:00
Stein Magnus Jodal
0b2fdce882 Merge branch 'fix/macos-build' into develop 2018-03-29 18:00:51 +02:00
Stein Magnus Jodal
c59eccb06c stream: Don't compare entire track object
On Ubuntu 16.04 with GStreamer 1.2, we don't get a bitrate.

On Ubuntu 18.04 or macOS with GStreamer 1.12, we get a bitrate.
2018-03-29 17:16:22 +02:00
Stein Magnus Jodal
2e32b5c8bf audio: Explicitly convert long to int 2018-03-29 17:06:08 +02:00
Stein Magnus Jodal
5112985cc7 m3u: Fix tests on macOS 10.13 2018-03-29 16:59:14 +02:00
Stein Magnus Jodal
f46c290ec1 Merge branch 'release-2.1' into develop 2018-03-29 16:30:17 +02:00
Stein Magnus Jodal
7d02870f79 Merge branch 'master' into release-2.1 2018-03-29 16:25:41 +02:00
Stein Magnus Jodal
86e5e7d347 Require Tornado < 5
Tornado 5 requires Python >= 2.7.9 because of improvements made to the
`ssl` module in that version. Mopidy probably works with Tornado 5, but
to keep tests running with Python 2.7.6 on Travis CI we don't support
Tornado 5 for now.
2018-03-29 15:59:41 +02:00
Stein Magnus Jodal
1f09ef6b84 tests: Use pytest<3.3 to avoid breaking changes 2018-03-29 11:08:41 +02:00
Stein Magnus Jodal
efdf6704b8 Ignore new pytest cache dir 2018-03-29 10:24:41 +02:00
Stein Magnus Jodal
99d8a2124e Fix new flake8 warnings 2018-03-29 10:21:50 +02:00
Stein Magnus Jodal
caa60f33f5 Update copyright year 2018-03-29 10:01:03 +02:00
Stein Magnus Jodal
b0c9117ed7 Merge branch 'master' into release-2.1 2018-03-29 09:59:22 +02:00
Stein Magnus Jodal
b25abf114a docs: Fix whitespace 2018-03-29 09:58:37 +02:00
Nick Steel
79d42c34af
Pin older version of pytest to avoid breaking change
This is a temporary workaround
2018-02-13 13:00:48 +00:00
Jarryd Tilbrook
b4c98ec4a5 Fix/1531 add unix domain socket (#1629)
mpd: add functionality for unix domain socket (Fixes #1531)

The Hostname config type now supports a Unix socket path prefixed with `unix:`
2018-02-13 12:58:39 +00:00
Stein Magnus Jodal
ef3c392fad
Merge pull request #1655 from jjok/patch-1
Remove Deezer backend
2018-01-29 22:54:35 +01:00
Jonathan Jefferies
26577eea2d
Remove Deezer backend
The Deezer extension has been removed from Github at Deezer's request, so is no longer available.

https://github/dmca/blob/master/2018/2018-01-12-Deezer.md
2018-01-24 22:06:02 +00:00
Dan Brough
1a94183f00 docs: Add Mopidy-RNZ backend (#1649) 2017-12-19 23:51:29 +01:00
Nick Steel
9e31e76a05
Merge pull request #1646 from jradtilbrook/fix/1645-flake8-e722
fix/1645-flake8-e722
2017-11-04 12:59:36 +00:00
jradtilbrook
f00fd8e1df
flake8: fix import order violations 2017-11-04 20:34:05 +08:00
jradtilbrook
257c42e111
flake8: fix bare except clause 2017-11-04 19:58:04 +08:00