Commit Graph

2041 Commits

Author SHA1 Message Date
Thomas Adamcik
95dc30288c httpclient: Fix import in tests 2015-05-09 00:52:29 +02:00
Thomas Adamcik
f6f445e4b6 Merge branch 'develop' into feature/http-helpers
Conflicts:
	docs/changelog.rst
2015-05-09 00:45:09 +02:00
Thomas Adamcik
382aa0a775 httpclient: Move to top level module 2015-05-09 00:44:16 +02:00
Stein Magnus Jodal
c59784c1e8 local: Add path_to_file_uri() 2015-05-08 00:55:03 +02:00
Stein Magnus Jodal
56cffa0089 local: Test path_to_local_{directory,track}() 2015-05-08 00:55:03 +02:00
Stein Magnus Jodal
4d5b485760 local: Add local_uri_to_file_uri()
Which replaces local_track_uri_to_file_uri() and also handles
local:directory: URIs.
2015-05-08 00:55:03 +02:00
Stein Magnus Jodal
d8bcd7f273 Rename mopidy.utils to mopidy.internal 2015-05-07 23:15:56 +02:00
Thomas Adamcik
af4e7c8a4e Merge branch 'develop' into feature/core-dont-trust-backends
Conflicts:
	docs/changelog.rst
2015-05-07 00:15:33 +02:00
Thomas Adamcik
29c66f7bc8 core: Correct volume/mute return values 2015-05-07 00:13:58 +02:00
Thomas Adamcik
4d608dd431 core: Add get_current_tlid shortcut 2015-05-06 23:00:53 +02:00
Thomas Adamcik
cfd4dcb8dd Merge branch 'develop' into feature/core-dont-trust-backends
Note that this merge also updated core.playlists.create to combine the 1.0.5
fix with these changes.

Conflicts:
	mopidy/core/playlists.py
2015-05-06 22:44:12 +02:00
Thomas Adamcik
c01f8679bc core: Address review comments for do not trust backends PR 2015-05-06 22:34:44 +02:00
Stein Magnus Jodal
6d82cdb611 tests: Cleanup reset_mock() usage 2015-05-06 21:06:30 +02:00
Stein Magnus Jodal
a17c413a70 Merge branch v1.0.x into develop 2015-05-06 20:47:52 +02:00
Thomas Kemmer
636639a201 Fix #1162: Ignore None results and exceptions from PlaylistsProvider.create(). 2015-05-06 14:50:21 +02:00
Thomas Adamcik
4aa984207b tests: Split up core bad backend tests and unify naming 2015-05-06 01:01:12 +02:00
Thomas Adamcik
e7b241e18b core: Update playlists to handle bad data from backends and exceptions 2015-05-06 00:28:58 +02:00
Thomas Adamcik
3426633c78 core: Make sure we handle bad mixer data and exceptions. 2015-05-05 23:41:46 +02:00
Thomas Adamcik
dd4a8f3b78 core: Make sure library can handle bad data from backends
Note that None values are just ignored, while other bad data logs an error
message and is ignored.
2015-05-05 22:55:53 +02:00
Stein Magnus Jodal
746c3059ba Merge pull request #1160 from adamcik/feature/model-corner-case-handling
Move new models features to new class
2015-05-05 08:08:05 +02:00
Thomas Adamcik
b480311d66 models: Add ValidatedImmutableObject and "revert" ImmutableObject
Testing with extension that use custom models it was discovered that the
changes to have type safe models were a bit to invasive to be suitable for a
minor release. This change fixes this by bringing back ImmutableObjects in
their old form, and moving the shinny new features to ValidatedImmutableObject.

A subset of the tests for ImmutableObjects have been resurrected to have some
confidence in this working the way we think it should.
2015-05-04 23:41:11 +02:00
Thomas Adamcik
7f6809aebb models: Explicitly define which models can be deserialized 2015-05-04 22:36:27 +02:00
Thomas Adamcik
07159f69c2 models: Decouple fields tests from the model metaclass 2015-05-04 21:37:17 +02:00
Thomas Adamcik
bb95dc3b9b models: Make sure parent fields are used by children.
Without this change any sub-class would end up with an empty _fields and none
of the actual fields would be writable even internally.
2015-05-03 22:58:43 +02:00
Stein Magnus Jodal
b4a6a4da7f Merge branch 'v1.0.x' into develop 2015-04-30 08:44:10 +02:00
Stein Magnus Jodal
2f96dacae8 Bump version to 1.0.4 2015-04-30 08:41:03 +02:00
Thomas Adamcik
94039e06dc models: Make sure sub-classes can extend models 2015-04-29 21:32:43 +02:00
Thomas Adamcik
9182a7870e utils: Support opting out of adding auth to proxy 2015-04-29 00:38:06 +02:00
Thomas Adamcik
8cf9da3d55 utils: Fix corner case in format_proxy scheme handling 2015-04-29 00:27:56 +02:00
Thomas Adamcik
5153d9e19f utils: Add format_user_agent helper 2015-04-28 23:51:19 +02:00
Thomas Adamcik
a48aadaaed utils: Add basic format proxy helper 2015-04-28 23:50:52 +02:00
Thomas Adamcik
8851fb151c models: Allow Ref.type to have any value
This is to address a potential breakage brought up in #1150 as it turns out
Mopidy-Podcast uses custom models and ref types.
2015-04-28 22:58:15 +02:00
Stein Magnus Jodal
97c336200b Merge branch 'v1.0.x' into develop 2015-04-28 00:02:26 +02:00
Stein Magnus Jodal
9c2aabb899 Bump version to 1.0.3 2015-04-28 00:00:25 +02:00
Stein Magnus Jodal
b14aee3e04 Merge branch 'v1.0.x' into develop
Conflicts:
	docs/changelog.rst
2015-04-27 00:18:41 +02:00
Stein Magnus Jodal
21289f8fe5 Bump version to 1.0.2 2015-04-27 00:02:12 +02:00
Thomas Adamcik
651e89357f tests: Fix IssueGH1120RegressionTest flakiness 2015-04-26 23:23:30 +02:00
Thomas Adamcik
7e59a5aecb models: Split models into smaller modules 2015-04-25 00:11:41 +02:00
Thomas Adamcik
b3ea425fd0 tests: Fix IssueGH1120RegressionTest flakiness 2015-04-24 19:26:02 +02:00
Stein Magnus Jodal
3dba4f4208 Merge branch 'v1.0.x' into develop 2015-04-23 23:40:04 +02:00
Stein Magnus Jodal
9c793a38ff Bump version to 1.0.1 2015-04-23 23:35:45 +02:00
Thomas Adamcik
d4c695ac75 mpd: Split browse and playlist name to uri caching 2015-04-23 23:08:25 +02:00
Thomas Adamcik
a62293c316 core: Add play(tlid) support 2015-04-22 20:55:51 +02:00
Thomas Adamcik
fba4069cfd core: Make index return current index when missing args 2015-04-19 00:22:52 +02:00
Thomas Adamcik
6a7005be1e core: Add tlid argument to index calls.
Should save clients from having to pass tl_track models around.
2015-04-19 00:22:52 +02:00
Stein Magnus Jodal
7752ebe7e4 Merge pull request #1130 from adamcik/feature/more-deprecation-cleanups
More deprecations and correspoding cleanups
2015-04-17 00:18:28 +02:00
Thomas Adamcik
09027854c6 validation: Reject iterators as core arguments
iter() always never re-wraps an iterator, so 'iter(i) is iter(i)' tests if we
wrapped a container or if we already had an iterator. I also tried
types.GeneratorType and inspect helpers but they did not work for this use
case.
2015-04-17 00:05:46 +02:00
Thomas Adamcik
81fd426caf tests: Update tests to not used deprecated kwargs 2015-04-17 00:00:58 +02:00
Thomas Adamcik
efad50c253 cleanup: Stop using deprecated copy() 2015-04-17 00:00:58 +02:00
Stein Magnus Jodal
e265f5d673 Merge pull request #1128 from adamcik/feature/validate-core-input
Validate core inputs
2015-04-16 07:45:17 +02:00
Thomas Adamcik
98587f5098 review: Fix test name 2015-04-15 23:48:44 +02:00
Thomas Adamcik
97235f9441 core: Don't allow TLIDs in queries, or integers
Handle this in tracklist.filter() which is the only API that allows number
and/or TLIDs.
2015-04-14 23:46:20 +02:00
Thomas Adamcik
324bec1f4a core: Validate core API calls 2015-04-14 23:45:56 +02:00
Thomas Adamcik
8646ba4252 utils: Add validation helpers for verifying core APIs 2015-04-14 23:16:12 +02:00
Stein Magnus Jodal
093c4340cd Merge branch 'v1.0.x' into develop
Conflicts:
	mopidy/audio/scan.py
	tests/audio/test_scan.py
2015-04-13 08:19:14 +02:00
Thomas Adamcik
94628b5f82 local: Don't use tuple form of TlTracks in tests 2015-04-13 00:50:33 +02:00
Thomas Adamcik
1b10a783d3 mpd: Update tests to use setters and actual booleans 2015-04-13 00:16:09 +02:00
Stein Magnus Jodal
f85ea2a39d flake8: Fix new import order warnings
(cherry picked from commit 71ab9733c7)
2015-04-12 23:05:53 +02:00
Stein Magnus Jodal
71ab9733c7 flake8: Fix new import order warnings 2015-04-12 23:03:46 +02:00
Thomas Adamcik
20019edf2d models: Fix review comments 2015-04-12 16:03:51 +02:00
Thomas Adamcik
6327a67874 models: Make sure we really only add __weakref__ once 2015-04-11 00:47:53 +02:00
Thomas Adamcik
9bc4d8b713 audio: Make scanner handle all media types.
I don't think this makes anything slower, as before we would still decode
anything we came across in the hopes that we find raw audio.
2015-04-11 00:29:07 +02:00
Stein Magnus Jodal
c367d350f7 Merge pull request #1117 from adamcik/feature/models-memory-reduction
Improve models memory usage
2015-04-08 23:29:08 +02:00
Thomas Adamcik
2cc91c0a7f core: Fix review comments for PR#1111 2015-04-08 23:13:07 +02:00
Thomas Adamcik
e5f59495fc core: Update refresh test case to fail on multiple calls to same backend 2015-04-08 21:18:18 +02:00
Thomas Adamcik
511cf4e326 core: Catch exceptions when browsing in backends
Also splits browse into to method to better distinguish the two possible code
paths.
2015-04-08 21:17:44 +02:00
Thomas Adamcik
682c6b1c6c Merge branch 'develop' into feature/make-core-more-robust
Conflicts:
	docs/changelog.rst
2015-04-08 20:28:10 +02:00
Thomas Adamcik
05244f7e60 models: Deprecate copy and add replace method
Changed as with the memoization copy was lying, so replace is a better name.
2015-04-08 01:41:50 +02:00
Thomas Adamcik
b7375323e9 models: Memoize identical instances automatically
This combined with the previous changes has brought the memory use for a 14k
track test-set down from about 75MB to 17MB or so. Note that this does however,
mean that copy is now lying to us as it does not such thing whenever it can
avoid it.
2015-04-08 01:14:56 +02:00
Thomas Adamcik
86481b1d50 models: Shortcut case where copy didn't change anything
We no longer copy in this case and will just give you the same instance back.
2015-04-08 00:34:02 +02:00
Thomas Adamcik
0fee1b4b11 models: Switch to slots to reduce memory usage per instance 2015-04-08 00:30:53 +02:00
Thomas Adamcik
08fd99ffdb models: Add Identifer type which interns values.
This gives some moderate memory saving since the values are used in multiple
places.
2015-04-08 00:11:23 +02:00
Stein Magnus Jodal
7bda4f835f xdg: Add XDG dir utils 2015-04-07 23:50:59 +02:00
Thomas Adamcik
9b442e1563 review: Address review comments 2015-04-06 23:27:46 +02:00
Thomas Adamcik
50f68064be core: Update PlaylistsController to catch backend exceptions 2015-04-06 02:13:51 +02:00
Thomas Adamcik
66771dec68 core: Update LibraryController to catch backend exceptions 2015-04-06 02:12:56 +02:00
Thomas Adamcik
2d03cd7290 models: Make fields handle unsetting defaults in __dict__ 2015-04-05 13:09:19 +02:00
Thomas Adamcik
73415ce60f models: Make sure del on attributes does not work 2015-04-05 13:08:15 +02:00
Thomas Adamcik
07912e1091 models: Add fields for supporting validation of models
Feature makes use of python descriptors to hook in type checking and other
validation when fields get set.
2015-04-05 13:08:15 +02:00
Thomas Adamcik
5c0430ef4a tests: Move models tests into a directory 2015-04-05 13:08:15 +02:00
Thomas Adamcik
8f96bf0f39 tests: Fix some model use oddities 2015-04-05 13:08:15 +02:00
Stein Magnus Jodal
c4940cbea2 autopep8: Add space after class signature/docstring 2015-04-03 00:05:26 +02:00
Thomas Adamcik
83c3d0013f Merge pull request #1096 from jodal/feature/faster-travis-build
travis: Use new faster build infrastructure
2015-04-02 21:41:43 +02:00
Stein Magnus Jodal
2bc63ec027 audio: Skip MP3 tests if missing plugin 2015-04-02 20:53:29 +02:00
Thomas Adamcik
9ede14f4a1 tests: Convert to using deprecation helpers across the board. 2015-03-30 23:50:54 +02:00
Thomas Adamcik
f4c93619d1 core: Make core tracklist.add(tracks=...) deprecation safe 2015-03-29 23:11:00 +02:00
Thomas Adamcik
dc673d554c tests: Ignore deprecated tracklist.add(tracks=...) in local tests
Note, this is mostly because these tests are just core tests in disguise and
need a lot more love than I can give them right now.
2015-03-29 23:11:00 +02:00
Thomas Adamcik
c85689edad mpd: Make mpd warnings safe with respect to tracklist.add(tracks=...) 2015-03-29 23:11:00 +02:00
Thomas Adamcik
f7399c1849 tests: Stop using playlist filters in mpd music_db tests 2015-03-29 23:11:00 +02:00
Thomas Adamcik
79b0584887 tests: Stop using tracklist add tracks in mpd status test 2015-03-29 23:11:00 +02:00
Thomas Adamcik
7d42d028c6 tests: Stop using tracklist tracks in mpd playback tests 2015-03-29 23:11:00 +02:00
Thomas Adamcik
faf8174ef7 tests: Update mpd.test_status to not use tracklist.add(tracks=...) 2015-03-29 23:11:00 +02:00
Thomas Adamcik
a8860faa35 tests: Cleanup mpd.protocol.current_playlist tests
- Split into smaller test cases more or less per command
- Created a BasePopulatedTracklistTestCase with a sensible setUp
- Modified test cases to work with the common tracklist state
- Replaced all calls to tracklist.add(tracks=...) with uris=...
- Test tracklist ordering in more compact way that also gives better error
  messages
2015-03-29 23:11:00 +02:00
Thomas Adamcik
d3b275e1a4 core: Mark tracklist.add by URI as deprecated 2015-03-29 23:11:00 +02:00
Thomas Adamcik
49fc9941a1 core: Mark searching via keyword argument based query deprecated 2015-03-29 23:11:00 +02:00
Thomas Adamcik
0ab52a73fa core: Mark library.lookup by uri deprecated
Updates core, mpd and tests to not use deprecated calls or safely catch them
when running with -W error.
2015-03-29 23:11:00 +02:00
Thomas Adamcik
f5f9899db9 tests: Make bases test classes in core 2015-03-29 23:10:58 +02:00
Thomas Adamcik
a54551d985 core: Mark get_playlists and filter as deprecated 2015-03-29 23:10:19 +02:00
Thomas Adamcik
5a3fb64250 core: Emit deprecation warning for library.find_exact 2015-03-29 23:08:03 +02:00
Thomas Adamcik
b31f0c421f tests: Make tests warning safe 2015-03-26 21:58:44 +01:00