Commit Graph

6598 Commits

Author SHA1 Message Date
Thomas Adamcik
d630a97bc1 ext: Refactor tests based on review comments 2015-05-12 22:00:31 +02:00
Thomas Adamcik
dbc3100e9c main: Update to use extension_data structure
Updated config and __main__ code to use the new wrapper format and pre-fetched
values.
2015-05-11 22:47:13 +02:00
Thomas Adamcik
8b6553ec16 ext: Update validate_extension to validate_extension_data
Adds more checks to catch extension errors and importantly tests for exercise
these code paths.
2015-05-11 22:30:50 +02:00
Thomas Adamcik
4566ddd9ae ext: Add exception logging to extension loading 2015-05-11 21:29:03 +02:00
Thomas Adamcik
8ed9e5f1e0 ext: Catch exceptions in extension helpers 2015-05-11 21:20:37 +02:00
Thomas Adamcik
8434a22c83 ext: Switch to using fixtures for mocking 2015-05-11 20:53:50 +02:00
Thomas Adamcik
5550785146 ext: Wrap extension state in a ExtensionData tuple
This allows us to do more of the data loading that might fail safely in the
mopidy.ext module instead of having things spread all over the place.

Note that only minimal changes have been made to __main__ to make things work.
Further refactoring should follow.
2015-05-11 00:33:41 +02:00
Thomas Adamcik
5937cdc3b2 ext: Add tests for validate_extension and handle validate_environment failures 2015-05-10 23:15:13 +02:00
Thomas Adamcik
c4e18f4218 ext: Add ext.load_extensions tests and basic error handling 2015-05-10 23:00:13 +02:00
Thomas Adamcik
f814e945d3 tests: Convert ext test to pytests 2015-05-10 21:49:04 +02:00
Thomas Adamcik
3a276c3cd0 Merge pull request #1174 from jodal/feature/local-uri-and-path-helpers
Brush up local URI/path helpers
2015-05-08 22:21:51 +02:00
Stein Magnus Jodal
64b5342c51 docs: Document mopidy.local.translator 2015-05-08 00:55:03 +02:00
Stein Magnus Jodal
c59784c1e8 local: Add path_to_file_uri() 2015-05-08 00:55:03 +02:00
Stein Magnus Jodal
56cffa0089 local: Test path_to_local_{directory,track}() 2015-05-08 00:55:03 +02:00
Stein Magnus Jodal
4d5b485760 local: Add local_uri_to_file_uri()
Which replaces local_track_uri_to_file_uri() and also handles
local:directory: URIs.
2015-05-08 00:55:03 +02:00
Stein Magnus Jodal
e30cd2cfa5 local: Rename local_{track_ => }uri_to_file_uri() 2015-05-08 00:32:09 +02:00
Thomas Adamcik
5475ce0b77 Merge pull request #1173 from jodal/feature/internal-modules
Rename mopidy.utils to mopidy.internal
2015-05-07 23:57:58 +02:00
Stein Magnus Jodal
d8bcd7f273 Rename mopidy.utils to mopidy.internal 2015-05-07 23:15:56 +02:00
Stein Magnus Jodal
4c8c8cd927 docs: Don't refer to when.js before it's introduced 2015-05-07 22:39:35 +02:00
Stein Magnus Jodal
6fe382f37e docs: Mopidy.js supports by-name parameters
Since Mopidy 0.19 / Mopidy.js 0.4
2015-05-07 22:34:15 +02:00
Stein Magnus Jodal
d0418d625b docs: Link from JS docs to static web client example 2015-05-07 21:49:08 +02:00
Stein Magnus Jodal
f96a22e5cb docs: Remove note on how to access core attributes
The corresponding methods are now fully documented and the old
attributes are deprecated.
2015-05-07 21:49:08 +02:00
Stein Magnus Jodal
622a3c5494 docs: Group API docs in sections 2015-05-07 21:39:54 +02:00
Stein Magnus Jodal
3d051e1a24 docs: Remove old deps from list of mocked modules 2015-05-07 21:20:05 +02:00
Stein Magnus Jodal
7c57c51b2e docs: Fix unexpected indentation error 2015-05-07 21:16:37 +02:00
Stein Magnus Jodal
1d82bd7043 docs: Use consistent syntax for module headers 2015-05-07 21:15:28 +02:00
Stein Magnus Jodal
526216b61b docs: Remove note header 2015-05-07 21:15:16 +02:00
Stein Magnus Jodal
d02f7dca18 docs: Move frontend API between core and backend 2015-05-07 21:15:06 +02:00
Stein Magnus Jodal
ccecf6b6bf docs: Remove plurality from backends/frontends API docs 2015-05-07 21:08:02 +02:00
Stein Magnus Jodal
ae07603da0 docs: Add module name to API docs headers
In the same way the Python stdlib docs does.
2015-05-07 21:02:25 +02:00
Stein Magnus Jodal
ad585d60d4 Merge pull request #1163 from adamcik/feature/core-dont-trust-backends
Don't trust backends...
2015-05-07 20:38:59 +02:00
Thomas Adamcik
af4e7c8a4e Merge branch 'develop' into feature/core-dont-trust-backends
Conflicts:
	docs/changelog.rst
2015-05-07 00:15:33 +02:00
Thomas Adamcik
29c66f7bc8 core: Correct volume/mute return values 2015-05-07 00:13:58 +02:00
Stein Magnus Jodal
1f06771ccf Merge pull request #1167 from adamcik/feature/get-current-tlid
core: Add get_current_tlid shortcut
2015-05-06 23:06:22 +02:00
Thomas Adamcik
4d608dd431 core: Add get_current_tlid shortcut 2015-05-06 23:00:53 +02:00
Thomas Adamcik
cfd4dcb8dd Merge branch 'develop' into feature/core-dont-trust-backends
Note that this merge also updated core.playlists.create to combine the 1.0.5
fix with these changes.

Conflicts:
	mopidy/core/playlists.py
2015-05-06 22:44:12 +02:00
Thomas Adamcik
c01f8679bc core: Address review comments for do not trust backends PR 2015-05-06 22:34:44 +02:00
Stein Magnus Jodal
6d82cdb611 tests: Cleanup reset_mock() usage 2015-05-06 21:06:30 +02:00
Stein Magnus Jodal
a17c413a70 Merge branch v1.0.x into develop 2015-05-06 20:47:52 +02:00
Stein Magnus Jodal
bf13bb4dd6 Merge pull request #1165 from tkem/fix/1162-v1.0.x
Fix #1162: Ignore None results and exceptions from PlaylistsProvider.create().
2015-05-06 20:47:23 +02:00
Thomas Kemmer
636639a201 Fix #1162: Ignore None results and exceptions from PlaylistsProvider.create(). 2015-05-06 14:50:21 +02:00
Thomas Adamcik
9f64a8719a docs: Add core not trusting backends entry to changelog 2015-05-06 01:02:49 +02:00
Thomas Adamcik
4aa984207b tests: Split up core bad backend tests and unify naming 2015-05-06 01:01:12 +02:00
Thomas Adamcik
e7b241e18b core: Update playlists to handle bad data from backends and exceptions 2015-05-06 00:28:58 +02:00
Thomas Adamcik
3426633c78 core: Make sure we handle bad mixer data and exceptions. 2015-05-05 23:41:46 +02:00
Thomas Adamcik
dd4a8f3b78 core: Make sure library can handle bad data from backends
Note that None values are just ignored, while other bad data logs an error
message and is ignored.
2015-05-05 22:55:53 +02:00
Stein Magnus Jodal
746c3059ba Merge pull request #1160 from adamcik/feature/model-corner-case-handling
Move new models features to new class
2015-05-05 08:08:05 +02:00
Thomas Adamcik
85871fb33d docs: Improve fields documentation 2015-05-05 00:00:22 +02:00
Thomas Adamcik
b480311d66 models: Add ValidatedImmutableObject and "revert" ImmutableObject
Testing with extension that use custom models it was discovered that the
changes to have type safe models were a bit to invasive to be suitable for a
minor release. This change fixes this by bringing back ImmutableObjects in
their old form, and moving the shinny new features to ValidatedImmutableObject.

A subset of the tests for ImmutableObjects have been resurrected to have some
confidence in this working the way we think it should.
2015-05-04 23:41:11 +02:00
Thomas Adamcik
5989d3a017 models: Simplify how we add __weakref__ to slots 2015-05-04 22:39:36 +02:00