Commit Graph

4568 Commits

Author SHA1 Message Date
Stein Magnus Jodal
f9c09a8990 Merge pull request #548 from adamcik/feature/write-config
Prep work for adding a `mopidy config --set ...` type command.
2013-10-27 12:52:46 -07:00
Stein Magnus Jodal
1d651c5ff4 Merge pull request #549 from adamcik/fix/bug-500-library-refresh-does-not-remove-uris
local: Delete uris in library refresh (fixes #500)
2013-10-27 12:52:06 -07:00
Thomas Adamcik
ecc0bae344 local: Delete uris in library refresh (fixes #500)
Makes sure we remove uri's that can no longer be found in the tag cache.
2013-10-27 14:10:56 +01:00
Thomas Adamcik
73f91710e1 config: Add postprocessor for converting config back.
Idea forward from here is that once we have a config sub command that we expose
a setting config values which will:

1. Run the preprocessor on the file to edit.
2. Load it into config parser.
3. Modify the value.
4. Write it to a io.ByteString
5. Run the postprocessor
6. Save the file with comments etc intact.
2013-10-27 12:30:02 +01:00
Thomas Adamcik
d5cb4282d9 config: Add preprocessor for preserving comments when editing configs.
Adds markers to configs files that ensures configparser won't mangle comments
in the files. Will be combined with a postprocessor that undoes these changes.
2013-10-27 11:38:01 +01:00
Stein Magnus Jodal
add79d90dd docs: Warn about EOT issue with Shoutcast (fixes #545) 2013-10-25 18:16:08 +02:00
Stein Magnus Jodal
b0ae7d3c6f local: Fix crash on non-ASCII chars in URIs 2013-10-24 23:22:01 +02:00
Stein Magnus Jodal
e448d77eb7 mpd: Fix flipped mute logic 2013-10-24 22:20:07 +02:00
Stein Magnus Jodal
1e3191a0f9 docs: Search is on every page, don't need a search page 2013-10-24 09:51:09 +02:00
Stein Magnus Jodal
f4d0d5648f docs: Fix typo 2013-10-23 22:39:33 +02:00
Stein Magnus Jodal
84612ca1ac docs: Fix typo 2013-10-23 22:27:04 +02:00
Stein Magnus Jodal
9d0b04e96f docs: Fix link to Mopidy-Arcam 2013-10-23 21:20:00 +02:00
Stein Magnus Jodal
80b9329dcb docs: Update authors 2013-10-23 20:57:30 +02:00
Stein Magnus Jodal
8097add7ed docs: More exact GStreamer version range 2013-10-23 20:30:25 +02:00
Stein Magnus Jodal
ef15c4f6fc docs: Enable new RTD theme 2013-10-23 20:29:05 +02:00
Stein Magnus Jodal
2117add55f docs: Include minimum GStreamer version 2013-10-20 23:48:17 +02:00
Thomas Adamcik
010cb62756 docs: Add note about fixing #198 to changelog 2013-10-20 23:45:33 +02:00
Stein Magnus Jodal
c31815b0e6 docs: Update changelog 2013-10-20 23:21:45 +02:00
Stein Magnus Jodal
07a65198a2 Merge pull request #542 from adamcik/fix/bug-496-handle-single
Resolve mistakes in single handling.
2013-10-20 13:58:15 -07:00
Thomas Adamcik
bfddfab15a core: Fix typos pointed out in PR#542 2013-10-20 22:47:54 +02:00
Thomas Adamcik
84c373d7ea Merge branch 'develop' into fix/bug-496-handle-single
Conflicts:
	mopidy/core/tracklist.py
2013-10-20 22:46:35 +02:00
Stein Magnus Jodal
6133d20fa9 Merge pull request #541 from adamcik/feature/random-cleanup
Cleanup random tests and fix #453
2013-10-20 13:30:47 -07:00
Thomas Adamcik
ba55181bc1 core: Reduce duplication between next and eot track handling. 2013-10-20 21:48:42 +02:00
Thomas Adamcik
f1f223bba8 local: Fix handling of single in eot_track (fixes #496)
- Adds test cases for code paths that caused bug
- Short circuits EOT next track handling when in single mode.
2013-10-20 21:43:19 +02:00
Thomas Adamcik
7fc753d167 core/local: Update playback test with review comments.
- Fixes typo.
- Adds assert to better test intermediate state.
2013-10-20 21:16:18 +02:00
Thomas Adamcik
d978005008 core: flake8 fixes 2013-10-20 20:33:48 +02:00
Thomas Adamcik
40754bb2e0 core: Fix handling of shuffle (fixes #453)
- Shuffle internal list when random is enabled
- Use presence of tl_track to determine if this is first run to trigger
  subsequent shuffles.
2013-10-20 19:28:13 +02:00
Thomas Adamcik
66ae1b8eee local/core: Add and fix more random related tests.
- Adds tests for eot_track vs next_track as we were only testing the one code
  path.
- Makes test_random_until_end_of_playlist_and_play_from_start actually test
  random and not repeat.
- Adds test_play_track_then_enable_random which is the underlying bug covered
  by the regression test for issue #17.
2013-10-20 18:39:07 +02:00
Thomas Adamcik
025bafc114 local/core: Update random tests to be more predictable
- Replace setting the random seed with mocking out shuffle with reverse. This
  makes tests easier to reason about while still being able to test correct
  behaviour.
- Increases number of tracks to four to avoid test passing due to symetry in
  plain and reversed lists.
- Made test_eot_track_with_random_after_append_playlist actually test eot and
  not next.
- Found a test failure in handling of test_random_until_end_of_playlist, fix in
  next commit.
2013-10-20 18:39:07 +02:00
Thomas Adamcik
d968244712 docs: Update changelog with scanner info. 2013-10-20 17:19:03 +02:00
Stein Magnus Jodal
cfe93c244b scanner: Reject files with <100ms audio data 2013-10-20 16:43:04 +02:00
Stein Magnus Jodal
96008ca826 Merge pull request #539 from adamcik/fix/bug-527-temp-workaround
local: Temporary workaround for issue #527
2013-10-20 07:31:55 -07:00
Thomas Adamcik
fcd3e5d5cf local: Add test for fallback handling of unknown track uris in playlists
- Checks that adding a non local:track:... uri to a playlist and reading it
  back works.
- Also fixes mistake in API usage where we assumed lookup still raised
  LookupError.
2013-10-20 16:18:03 +02:00
Stein Magnus Jodal
53333f7121 docs: Update changelog 2013-10-20 16:06:08 +02:00
Stein Magnus Jodal
c8886dec49 tests: Sort imports 2013-10-20 16:04:09 +02:00
Stein Magnus Jodal
e6712bac93 Merge pull request #538 from adamcik/feature/gst-discoverer
scanner: Switch to gst.pbutils.Discoverer and refactor API
2013-10-20 07:03:47 -07:00
Thomas Adamcik
2f01fc4e46 scanner: Review comments and flake fixes
- Move ScannerError to exceptions module.
- Subclass ScannerError from MopidyException.
- Fix import sorting.
2013-10-20 15:51:39 +02:00
Stein Magnus Jodal
d8b0952f66 scanner: Remove support for running Python on the mopidy/scanner.py file
See commit 1a02b4d17f for details
2013-10-20 15:46:35 +02:00
Thomas Adamcik
0f6176a3b4 local: Temporary workaround for issue #527
Adds a fallback to `Track(uri=uri` when track lookup fails for playlists. This
means we can at least load metadata less tracks giving users functioning
playlists, instead of only supporting `local:track:...` style URIs.

Issue is not fixed, but this is sufficient to reduce priority until we get to
the larger planed refactor for this and other core API issues.
2013-10-20 13:26:38 +02:00
Thomas Adamcik
a5a55952fb scanner: Switch to gst.pbutils.Discoverer and refactor API
- New API wraps gst.pbutils.Discoverer for mopidy use.
  - Custom scanner code removed.
- Callback based async API switched with simpler synchronous API
  - Scanner is feed one and one URI and returns the result or raises an error.
- Adds new ScannerError exception for error handling in scanner
- Limits local/scan_timeout to 1000-3600000 i.e. 1s to 1h
- Files with zero duration are now excluded.
- Mtime handling moved out of scanner so we can use it for streams etc.
2013-10-20 13:22:00 +02:00
Stein Magnus Jodal
8561e9c815 docs: Remove mopidy.backends.spotify 2013-10-20 10:44:25 +02:00
Stein Magnus Jodal
11a9b5b1f2 docs: Add Mopidy-Notifier to extension list 2013-10-19 23:15:13 +02:00
Stein Magnus Jodal
8edf81dca1 docs: Update changelog 2013-10-19 22:57:13 +02:00
Thomas Adamcik
e0bfe144f8 Merge pull request #532 from jodal/feature/search-by-albumartist
Search filtering by albumartist
2013-10-19 13:46:58 -07:00
Thomas Adamcik
c8f5c1aacf Merge pull request #537 from jodal/tidy-up-core
Core playback and tracklist modularity improvement v2
2013-10-19 13:24:21 -07:00
Stein Magnus Jodal
27a63b1688 local: Remove redundant test asserts 2013-10-19 22:17:08 +02:00
Stein Magnus Jodal
c850ed2698 Merge branch 'develop' into feature/search-by-albumartist
Conflicts:
	tests/backends/local/library_test.py
2013-10-19 22:15:50 +02:00
Stein Magnus Jodal
7d874873bd local: Include albumartist in 'any' searches 2013-10-19 22:14:53 +02:00
Stein Magnus Jodal
9a5d177dda docs: Update authors list 2013-10-19 21:10:16 +02:00
Stein Magnus Jodal
46bd5bc096 docs: Reduce depth of ToC 2013-10-19 21:09:49 +02:00