Stein Magnus Jodal
4e7c2bab4d
Merge branch 'develop' into feature/filter_improvement
2013-11-11 23:18:23 +01:00
Stein Magnus Jodal
50be4a5316
docs: Update changelog
2013-11-11 23:13:25 +01:00
Stein Magnus Jodal
a289d831d0
Merge pull request #569 from ZenithDK/scan_multiple_artist
...
Fix scan with multiple track artists and add tests
2013-11-11 14:07:36 -08:00
Stein Magnus Jodal
aa7b360d0d
docs: Fix typos
2013-11-11 22:59:45 +01:00
Stein Magnus Jodal
d2280d9a86
docs: Add {mpd,http}/zeroconf descriptions
2013-11-11 22:52:36 +01:00
Stein Magnus Jodal
f7c3272045
docs: Update authors
2013-11-11 22:46:32 +01:00
Stein Magnus Jodal
df4f99cf7b
docs: Update changelog
2013-11-11 22:46:21 +01:00
Stein Magnus Jodal
924553b62e
http: Fix tests
2013-11-11 22:40:45 +01:00
Stein Magnus Jodal
d723db8f41
Merge pull request #573 from adamcik/feature/avahi
...
Cleaned up version of #558 - Add avahi publishing of MPD and HTTP server endpoints.
2013-11-11 13:35:43 -08:00
Thomas Adamcik
660a1b7382
avahi: Remove use of config_section
2013-11-11 22:32:46 +01:00
Thomas Adamcik
f03c049485
avahi: More review comments and some other fixes.
...
- Switched to newstyle class
- Switched to safe values in kwargs
2013-11-11 22:04:13 +01:00
Thomas Adamcik
c964d15ac4
avahi: Simplify config to single value
2013-11-11 21:42:23 +01:00
Thomas Adamcik
e9c2816354
avahi: Add hostname and port template values to names
2013-11-11 21:39:14 +01:00
Thomas Adamcik
fb31193ed0
avahi: Fixes from review comments
2013-11-11 21:26:11 +01:00
Thomas Adamcik
6c6932c374
avahi: Only convert single string at a time in helper
2013-11-11 21:16:05 +01:00
Thomas Adamcik
bcce865ce7
avahi: Convert MPD and HTTP to use cleaned up versions
...
- Move imports to top as they should be.
- Report state based on publish return value.
- Remove overly broad except clauses.
- Unpublish before stopping servers.
2013-11-11 21:15:56 +01:00
Thomas Adamcik
50cfe42ce0
avahi: Improve error handling for dbus errors.
...
- Handle dbus not being installed.
- Handle not finding the system bus.
- Handle not finding the avahi service.
- Return if publish succeeded.
2013-11-11 21:15:47 +01:00
Thomas Adamcik
cf5589b4eb
avahi: Style and code cleanups in zeroconf module.
...
- Prepare for handling missing dbus directly in module.
- Constants should always be all caps.
- Extracted helpers from class to convey intent via their naming.
- Moved imports out of class, imports should always be on the top.
- Made sure calling publish mutiple times does not re-convert text.
- Made sure calling unpublish without publish does not break.
2013-11-11 21:15:35 +01:00
Stein Magnus Jodal
484efab28e
utils: Remove Python 2.6 workaround
2013-11-10 21:37:53 +01:00
Lasse Bigum
c776565f65
Another round of review comments
2013-11-09 01:22:27 +01:00
Thomas Adamcik
51d1e22655
docs: Update changelog for PR #566 and #567
2013-11-08 23:51:45 +01:00
Lasse Bigum
093c0400a9
Fix review comments
2013-11-08 21:43:31 +01:00
Lasse Bigum
03750a8bf2
Fix scan with multiple track artists and add tests
2013-11-08 21:25:21 +01:00
Stein Magnus Jodal
e608f9f213
Merge pull request #567 from adamcik/feature/local-uri-translation
...
local/scanner: Make checking mtime and skipping known files work again
2013-11-07 15:00:17 -08:00
Thomas Adamcik
93918cb1e0
local: flake8 fixes
2013-11-07 23:25:55 +01:00
Stein Magnus Jodal
5b78ff94ff
docs: Remove count from MPD limitations list
2013-11-07 19:33:46 +01:00
Javier Domingo Cansino
71bae709ef
core: filter() to accept also tuples
2013-11-07 11:05:33 +01:00
Javier Domingo Cansino
45a38cdaf1
core: Changing input to accept also sets, as might be also used.
2013-11-07 10:51:29 +01:00
Javier Domingo Cansino
6721a59b26
tests: Fixing self confusion mistake
...
docs: Documenting tracklist's new filter() feature
2013-11-07 09:46:34 +01:00
Javier Domingo Cansino
8b5f30e5ff
Adding test case
2013-11-07 09:34:40 +01:00
Thomas Adamcik
e7dd7e2677
local/scanner: Make checking mtime and skipping known files work again
...
This change just patches over the worst of the inconsistencies in how the
scanner mixes local and file uris to get us to a working state again. Ideally,
this still needs a real cleanup when we finish the plugable library providers
and/or json library work.
2013-11-07 00:03:00 +01:00
Thomas Adamcik
f8dedc0b84
local: Add local_to_file_uri translator
2013-11-06 21:46:41 +01:00
Stein Magnus Jodal
71eff1bf45
Merge pull request #566 from adamcik/feature/scanner
...
Switch back to custom scanner
2013-11-06 12:31:02 -08:00
Thomas Adamcik
86926e8011
scanner: Remove unused argument for progress helper.
2013-11-06 21:14:11 +01:00
Thomas Adamcik
dc3cf427b6
scanner/mpd: Add TODOs for later and fix flake8 warning
2013-11-06 19:19:17 +01:00
Thomas Adamcik
e6381a1a0a
audio: Add mtime to scanner results for file: uris
2013-11-06 19:10:49 +01:00
Thomas Adamcik
469f414c4c
audio: Don't do duration conversion to ms in scanner
2013-11-06 19:10:49 +01:00
Thomas Adamcik
16ac5277f6
audio: Make min duration in scanner configurable.
2013-11-06 19:10:49 +01:00
Thomas Adamcik
20b0602842
audio/scanner: Move translator into audio.
...
Tries to move more of the gst bits and pieces we are leaking into audio.
2013-11-06 19:10:49 +01:00
Thomas Adamcik
4cadba0ac7
scanner: Add progress tracking and process sorted uris
2013-11-06 19:10:49 +01:00
Thomas Adamcik
0a2d74eff1
scanner: Update to use new mopidy.audio.scan
...
Also adds the check less than 100ms check back to the scanner.
2013-11-06 19:10:49 +01:00
Thomas Adamcik
d6ab78a86c
audio: Re-add improved version of python based scanner.
...
- Unlike the old python version we do not wait for the first audio handoff, we
only progress until the PAUSED state. This ensure we don't block on empty files.
- Instead of using the signal watch and running the main loop we simply poll
the messages from the bus directly allowing for a synchronous code flow.
- Between each file the pipeline is always returned to NULL, this is done as we
found that gst 0.10 will slow down as the uribin does not cleanup the
children it creates for handling each file. This issue is not present in 1.0.
- This also works around a segfault that was likely caused by a race condition
that seems to trigger in the 0.10 version of the pbutils discoverer.
- This version of the scanner also fixes the per track slow down, and works out
to be considerably faster than even the built in discoverer from 1.0.
- Finally this removes the WMA hack as I kan no longer find any evidence of it
being needed.
2013-11-06 19:10:49 +01:00
David Eisner
697bff81cd
Advertise HTTP with Avahi
2013-11-05 16:25:21 +00:00
Javier Domingo Cansino
32b01f4e4a
Adding a 'to list' conversion and correcting horrible mistake in comparison (put it reverse)
2013-11-05 13:17:55 +01:00
Javier Domingo Cansino
808770733f
core: Letting filter() accept lists
2013-11-05 13:08:40 +01:00
David Eisner
c4281339b6
Avahi hostname choice extracted for reuse
2013-11-05 11:07:35 +00:00
David Eisner
e9173ae81f
Avahi constants named
2013-11-05 11:06:51 +00:00
David Eisner
6c75b0d96f
Avahi wrapper moved to utils
2013-11-05 10:37:54 +00:00
David Eisner
483ced3c16
Avahi python compatibility fix
2013-11-05 10:33:04 +00:00
Stein Magnus Jodal
0ab1aacbc5
docs: Remove redundant Read The Docs config
2013-11-04 23:36:02 +01:00