andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,152 Commits 1 Branch 0 Tags 24 MiB
e655d39384
Commit Graph

1833 Commits

Author SHA1 Message Date
Thomas Kemmer
e655d39384 Fix #1031: Add get_images() to local library. 2015-03-12 11:43:27 +01:00
Thomas Adamcik
29b00cabf9 Merge pull request #1028 from tkem/fix/1026 
Fix #1026: Sort local playlists by name.
 2015-03-08 23:53:04 +01:00
Lasse Bigum
cf0b666a0a Add tests for PlaybackController get_current_(tl_)track 
Add some more test cases for PlaybackController
 2015-03-08 04:10:02 +01:00
Thomas Kemmer
94c418d5e6 Fix #1026: Sort local playlists by name. 2015-03-07 22:42:22 +01:00
Thomas Kemmer
9150c34053 Fix #1023: Remove support for local album images from coverartarchive.org 2015-03-06 10:02:08 +01:00
Stein Magnus Jodal
2280a533c0 Use py.test as test runner 2015-03-05 00:35:20 +01:00
Thomas Adamcik
319c1fc1e3 local: Readd support for search without limit for get_distinct support 2015-03-02 23:39:06 +01:00
Thomas Adamcik
7c2c4c1c45 Merge branch 'fix/local-json-limit-offset' of https://github.com/ali/mopidy into develop 2015-03-02 23:18:39 +01:00
Thomas Adamcik
8cc9c9bbc0 core: Rename list_distinct to get_distinct 2015-03-02 22:41:09 +01:00
Thomas Adamcik
5fd2afa7ca mpd: Switch list command to using list_distinct 2015-03-02 00:26:51 +01:00
Stein Magnus Jodal
0634de6e28 Merge pull request #1020 from adamcik/feature/fix-ws-disconnect-race 
Fix WS disconnect race
 2015-03-02 00:16:09 +01:00
Thomas Adamcik
0fb6c620df docs: Add changelog entry for broadcast race 2015-03-02 00:05:58 +01:00
Thomas Adamcik
4ee7dd73bd http: Make WS broadcast more robust against disconnect race 
Adds some WebSocketHandler tests that actually connect using a WS client and
plugs a potential race condition.

Any call to write_message could fail, either due to WebSocketClosedError like
in the log below, or simply due to socket errors. To play it safe we catch all
errors and debug log that a broadcast failed.

2015-02-26 21:24:02,266 ERROR    [HttpServer] /home/adamcik/dev/mopidy/mopidy/http/handlers.py:116
  mopidy.http.handlers WebSocket request error: deque index out of range
2015-02-26 21:24:10,098 ERROR    [HttpFrontend-11] build/bdist.linux-x86_64/egg/pykka/actor.py:268
  pykka Unhandled exception in HttpFrontend (urn:uuid:e376bd95-c32e-4e17-ad20-7d0b3c0cf2b2):
Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/pykka/actor.py", line 200, in _actor_loop
    response = self._handle_receive(message)
  File "build/bdist.linux-x86_64/egg/pykka/actor.py", line 294, in _handle_receive
    return callee(*message['args'], **message['kwargs'])
  File ".../dev/mopidy/mopidy/http/actor.py", line 77, in on_event
    on_event(name, **data)
  File ".../dev/mopidy/mopidy/http/actor.py", line 84, in on_event
    handlers.WebSocketHandler.broadcast(message)
  File ".../dev/mopidy/mopidy/http/handlers.py", line 78, in broadcast
    client.write_message(msg)
  File ".../dev/mopidy-virtualenv/local/lib/python2.7/site-packages/tornado/websocket.py", line 183, in write_message
    raise WebSocketClosedError()
WebSocketClosedError
 2015-03-02 00:05:21 +01:00
Lasse Bigum
fbd534efbf Don't change to playing state when seeking in paused state 
Do not switch state from paused to playing when seeking
 2015-03-01 15:50:17 +01:00
Thomas Adamcik
47911f24ea Merge pull request #1013 from tkem/fix/get_images 
backend: Improve default get_images() implementation with album/artist URIs.
 2015-02-28 12:35:16 +01:00
Thomas Kemmer
301f732047 Improve default get_images() implementation with album/artist URIs. 2015-02-27 22:22:28 +01:00
Stein Magnus Jodal
5536c79be5 Merge pull request #1005 from adamcik/fix/808 
Add per logger colors
 2015-02-25 23:18:08 +01:00
Thomas Adamcik
b11d89d72f config: Convert the loglevel schema to a generic map schema 2015-02-25 21:36:59 +01:00
Thomas Adamcik
0829f34a90 Merge pull request #999 from tkem/fix/998 
Fix #998: Remove event already sent by PlaylistsController.
 2015-02-25 21:05:53 +01:00
Thomas Kemmer
dd54fdb086 Fix #937: Local playlists refactoring. 2015-02-25 18:50:29 +01:00
Thomas Kemmer
96a3cb6ef5 Remove obsolete unit test. 2015-02-25 17:48:41 +01:00
Stein Magnus Jodal
255d92f21f Merge pull request #992 from adamcik/feature/default-get-images-fallback 
backend: Add a default get_images impl.
 2015-02-18 22:13:10 +01:00
Thomas Adamcik
2ff2a3719e backend: Add test for get_images fallback 2015-02-18 21:55:39 +01:00
Thomas Adamcik
e4ba4b3e5f mpd: Support blacklisting MPD commands in the server. 
Default blacklist set to listall and listallinfo.

This change has been done to avoid clients being able to call "bad" MPD
commands which are often misused to try and keep a client db. Note that
this change will break some MPD clients, but the blacklist can be controlled
via config to allow opting out for now.
 2015-02-18 00:13:24 +01:00
Ali Ukani
ead147f482 Fix flake8 errors, prepare for Python 3 port 
Fixes flake8 warnings
Reword docstring for find_exact
Use range instead of xrange in preparation for porting to Python 3
 2015-02-16 02:24:40 -05:00
Ali Ukani
fc21d466f0 local: use limit and offset when searching json library 
Fixes the json local library's search behavior. Uses limit and offset
arguments when returning search results.
 2015-02-16 02:24:40 -05:00
Stein Magnus Jodal
5270aa65e2 audio: Move DummyAudio into tests package 2015-02-13 10:40:21 +01:00
Stein Magnus Jodal
b554a64aad mixer: Move DummyMixer into tests package 2015-02-13 01:37:07 +01:00
Stein Magnus Jodal
df95a988b7 backend: Move DummyBackend into tests package 2015-02-13 01:37:07 +01:00
Stein Magnus Jodal
160afbcd26 mpd: Use DummyMixer in tests 2015-02-13 01:22:46 +01:00
Stein Magnus Jodal
886c2b92d8 core: Use a mixer mock in tests 2015-02-13 01:15:25 +01:00
Stein Magnus Jodal
333bc69777 jsonrpc: Don't use mixer in tests 2015-02-13 01:15:15 +01:00
Stein Magnus Jodal
7aede98fda Merge pull request #982 from adamcik/feature/use-proxy-in-stream-scanner 
Use proxy in stream scanner
 2015-02-13 01:04:09 +01:00
Thomas Adamcik
0e4e872d6b stream: Hook stream scanner up to proxy settings 2015-02-13 00:52:20 +01:00
Stein Magnus Jodal
638740541b Merge pull request #981 from adamcik/feature/core-get-images 
Add library.get_images()
 2015-02-13 00:33:29 +01:00
Thomas Adamcik
ddd872cdea core: Always return an answer for all URIs in get_images 
Also make sure that results are tuples instead of lists so we don't
accidentally give out mutable state.
 2015-02-13 00:10:14 +01:00
Thomas Adamcik
3cb9eb52f0 Merge pull request #975 from jodal/feature/core-mixer 
Add core.mixer replacing playback mixer methods.
 2015-02-12 23:50:04 +01:00
Thomas Adamcik
533948f8f8 core: Make sure we return list of images in get_images tests 2015-02-12 23:10:20 +01:00
Thomas Adamcik
b1b6fb7808 tests: Re-add incorrectly removed test case 2015-02-12 23:08:27 +01:00
Thomas Adamcik
c0b0e3657a core: Add core.library.get_images 2015-02-12 22:38:42 +01:00
Stein Magnus Jodal
e938fb0a7f Merge pull request #965 from ZenithDK/fix/flake-lambda 
flake8: fix PEP8 warnings about lambda
 2015-02-12 22:22:53 +01:00
Lasse Bigum
34ada2784a flake8: fix PEP8 warnings about lambda 
Fix the 'lambda to def' warnings
 2015-02-12 22:10:36 +01:00
Thomas Adamcik
05b66ba4a3 models: Add basic image model 2015-02-12 22:02:59 +01:00
Stein Magnus Jodal
df67d708db config: Add support for 'all' loglevel 
Equal to logging.NOTSET or 0 in the logging module.
 2015-02-12 18:12:33 +01:00
Stein Magnus Jodal
e1fa76a48e mpd: Use core.mixer for volume/mute 2015-02-12 10:31:16 +01:00
Stein Magnus Jodal
91bcdddf56 tests: Use core.mixer for volume/mute 2015-02-12 10:31:16 +01:00
Stein Magnus Jodal
42115c56f7 core: Add mixer controller (fixes: #962) 
Deprecate volume and mute methods on playback controller.
 2015-02-12 10:31:16 +01:00
kingosticks
0de13994c2 Moved MPDUriMapper to own file and updated changelog 2015-02-09 12:07:17 +00:00
kingosticks
317d02de3e Pass MPDUrimapper into mpd test setup 2015-02-08 23:43:22 +00:00
Lasse Bigum
4bf7a568d1 Check that config is readable 
Implement a check on file permissions for the config files that are loaded
and print debug if mopidy fails to load it due to missing file file permissions
 2015-02-07 17:47:20 +01:00