andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
6,742 Commits 1 Branch 0 Tags 24 MiB
0ebfeb5a5b
Commit Graph

2034 Commits

Author SHA1 Message Date
Lasse Bigum
cb19b2c48c Allow 'none' as audio.mixer value 
To disable mixing altogether, you can now set the configuration value
 audio/mixer to 'none'.
 2015-03-10 00:26:22 +01:00
Thomas Adamcik
e639b2b18b tests: Add method for emitting fake tags changed in tests 2015-03-09 21:55:23 +01:00
Thomas Adamcik
29b00cabf9 Merge pull request #1028 from tkem/fix/1026 
Fix #1026: Sort local playlists by name.
 2015-03-08 23:53:04 +01:00
Lasse Bigum
cf0b666a0a Add tests for PlaybackController get_current_(tl_)track 
Add some more test cases for PlaybackController
 2015-03-08 04:10:02 +01:00
Thomas Kemmer
94c418d5e6 Fix #1026: Sort local playlists by name. 2015-03-07 22:42:22 +01:00
Thomas Kemmer
9150c34053 Fix #1023: Remove support for local album images from coverartarchive.org 2015-03-06 10:02:08 +01:00
Stein Magnus Jodal
2280a533c0 Use py.test as test runner 2015-03-05 00:35:20 +01:00
Thomas Adamcik
319c1fc1e3 local: Readd support for search without limit for get_distinct support 2015-03-02 23:39:06 +01:00
Thomas Adamcik
7c2c4c1c45 Merge branch 'fix/local-json-limit-offset' of https://github.com/ali/mopidy into develop 2015-03-02 23:18:39 +01:00
Thomas Adamcik
8cc9c9bbc0 core: Rename list_distinct to get_distinct 2015-03-02 22:41:09 +01:00
Thomas Adamcik
5fd2afa7ca mpd: Switch list command to using list_distinct 2015-03-02 00:26:51 +01:00
Stein Magnus Jodal
0634de6e28 Merge pull request #1020 from adamcik/feature/fix-ws-disconnect-race 
Fix WS disconnect race
 2015-03-02 00:16:09 +01:00
Thomas Adamcik
0fb6c620df docs: Add changelog entry for broadcast race 2015-03-02 00:05:58 +01:00
Thomas Adamcik
4ee7dd73bd http: Make WS broadcast more robust against disconnect race 
Adds some WebSocketHandler tests that actually connect using a WS client and
plugs a potential race condition.

Any call to write_message could fail, either due to WebSocketClosedError like
in the log below, or simply due to socket errors. To play it safe we catch all
errors and debug log that a broadcast failed.

2015-02-26 21:24:02,266 ERROR    [HttpServer] /home/adamcik/dev/mopidy/mopidy/http/handlers.py:116
  mopidy.http.handlers WebSocket request error: deque index out of range
2015-02-26 21:24:10,098 ERROR    [HttpFrontend-11] build/bdist.linux-x86_64/egg/pykka/actor.py:268
  pykka Unhandled exception in HttpFrontend (urn:uuid:e376bd95-c32e-4e17-ad20-7d0b3c0cf2b2):
Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/pykka/actor.py", line 200, in _actor_loop
    response = self._handle_receive(message)
  File "build/bdist.linux-x86_64/egg/pykka/actor.py", line 294, in _handle_receive
    return callee(*message['args'], **message['kwargs'])
  File ".../dev/mopidy/mopidy/http/actor.py", line 77, in on_event
    on_event(name, **data)
  File ".../dev/mopidy/mopidy/http/actor.py", line 84, in on_event
    handlers.WebSocketHandler.broadcast(message)
  File ".../dev/mopidy/mopidy/http/handlers.py", line 78, in broadcast
    client.write_message(msg)
  File ".../dev/mopidy-virtualenv/local/lib/python2.7/site-packages/tornado/websocket.py", line 183, in write_message
    raise WebSocketClosedError()
WebSocketClosedError
 2015-03-02 00:05:21 +01:00
Lasse Bigum
fbd534efbf Don't change to playing state when seeking in paused state 
Do not switch state from paused to playing when seeking
 2015-03-01 15:50:17 +01:00
Thomas Adamcik
47911f24ea Merge pull request #1013 from tkem/fix/get_images 
backend: Improve default get_images() implementation with album/artist URIs.
 2015-02-28 12:35:16 +01:00
Thomas Kemmer
301f732047 Improve default get_images() implementation with album/artist URIs. 2015-02-27 22:22:28 +01:00
Stein Magnus Jodal
5536c79be5 Merge pull request #1005 from adamcik/fix/808 
Add per logger colors
 2015-02-25 23:18:08 +01:00
Thomas Adamcik
b11d89d72f config: Convert the loglevel schema to a generic map schema 2015-02-25 21:36:59 +01:00
Thomas Adamcik
0829f34a90 Merge pull request #999 from tkem/fix/998 
Fix #998: Remove event already sent by PlaylistsController.
 2015-02-25 21:05:53 +01:00
Thomas Kemmer
dd54fdb086 Fix #937: Local playlists refactoring. 2015-02-25 18:50:29 +01:00
Thomas Kemmer
96a3cb6ef5 Remove obsolete unit test. 2015-02-25 17:48:41 +01:00
Stein Magnus Jodal
255d92f21f Merge pull request #992 from adamcik/feature/default-get-images-fallback 
backend: Add a default get_images impl.
 2015-02-18 22:13:10 +01:00
Thomas Adamcik
2ff2a3719e backend: Add test for get_images fallback 2015-02-18 21:55:39 +01:00
Thomas Adamcik
e4ba4b3e5f mpd: Support blacklisting MPD commands in the server. 
Default blacklist set to listall and listallinfo.

This change has been done to avoid clients being able to call "bad" MPD
commands which are often misused to try and keep a client db. Note that
this change will break some MPD clients, but the blacklist can be controlled
via config to allow opting out for now.
 2015-02-18 00:13:24 +01:00
Ali Ukani
ead147f482 Fix flake8 errors, prepare for Python 3 port 
Fixes flake8 warnings
Reword docstring for find_exact
Use range instead of xrange in preparation for porting to Python 3
 2015-02-16 02:24:40 -05:00
Ali Ukani
fc21d466f0 local: use limit and offset when searching json library 
Fixes the json local library's search behavior. Uses limit and offset
arguments when returning search results.
 2015-02-16 02:24:40 -05:00
Stein Magnus Jodal
5270aa65e2 audio: Move DummyAudio into tests package 2015-02-13 10:40:21 +01:00
Stein Magnus Jodal
b554a64aad mixer: Move DummyMixer into tests package 2015-02-13 01:37:07 +01:00
Stein Magnus Jodal
df95a988b7 backend: Move DummyBackend into tests package 2015-02-13 01:37:07 +01:00
Stein Magnus Jodal
160afbcd26 mpd: Use DummyMixer in tests 2015-02-13 01:22:46 +01:00
Stein Magnus Jodal
886c2b92d8 core: Use a mixer mock in tests 2015-02-13 01:15:25 +01:00
Stein Magnus Jodal
333bc69777 jsonrpc: Don't use mixer in tests 2015-02-13 01:15:15 +01:00
Stein Magnus Jodal
7aede98fda Merge pull request #982 from adamcik/feature/use-proxy-in-stream-scanner 
Use proxy in stream scanner
 2015-02-13 01:04:09 +01:00
Thomas Adamcik
0e4e872d6b stream: Hook stream scanner up to proxy settings 2015-02-13 00:52:20 +01:00
Stein Magnus Jodal
638740541b Merge pull request #981 from adamcik/feature/core-get-images 
Add library.get_images()
 2015-02-13 00:33:29 +01:00
Thomas Adamcik
ddd872cdea core: Always return an answer for all URIs in get_images 
Also make sure that results are tuples instead of lists so we don't
accidentally give out mutable state.
 2015-02-13 00:10:14 +01:00
Thomas Adamcik
3cb9eb52f0 Merge pull request #975 from jodal/feature/core-mixer 
Add core.mixer replacing playback mixer methods.
 2015-02-12 23:50:04 +01:00
Thomas Adamcik
533948f8f8 core: Make sure we return list of images in get_images tests 2015-02-12 23:10:20 +01:00
Thomas Adamcik
b1b6fb7808 tests: Re-add incorrectly removed test case 2015-02-12 23:08:27 +01:00
Thomas Adamcik
c0b0e3657a core: Add core.library.get_images 2015-02-12 22:38:42 +01:00
Stein Magnus Jodal
e938fb0a7f Merge pull request #965 from ZenithDK/fix/flake-lambda 
flake8: fix PEP8 warnings about lambda
 2015-02-12 22:22:53 +01:00
Lasse Bigum
34ada2784a flake8: fix PEP8 warnings about lambda 
Fix the 'lambda to def' warnings
 2015-02-12 22:10:36 +01:00
Thomas Adamcik
05b66ba4a3 models: Add basic image model 2015-02-12 22:02:59 +01:00
Stein Magnus Jodal
df67d708db config: Add support for 'all' loglevel 
Equal to logging.NOTSET or 0 in the logging module.
 2015-02-12 18:12:33 +01:00
Stein Magnus Jodal
e1fa76a48e mpd: Use core.mixer for volume/mute 2015-02-12 10:31:16 +01:00
Stein Magnus Jodal
91bcdddf56 tests: Use core.mixer for volume/mute 2015-02-12 10:31:16 +01:00
Stein Magnus Jodal
42115c56f7 core: Add mixer controller (fixes: #962) 
Deprecate volume and mute methods on playback controller.
 2015-02-12 10:31:16 +01:00
kingosticks
0de13994c2 Moved MPDUriMapper to own file and updated changelog 2015-02-09 12:07:17 +00:00
kingosticks
317d02de3e Pass MPDUrimapper into mpd test setup 2015-02-08 23:43:22 +00:00
Lasse Bigum
4bf7a568d1 Check that config is readable 
Implement a check on file permissions for the config files that are loaded
and print debug if mopidy fails to load it due to missing file file permissions
 2015-02-07 17:47:20 +01:00
Stein Magnus Jodal
a693993905 flake8: Fix new warnings after flake8 upgrade 2015-02-07 17:11:36 +01:00
Ali Ukani
dac5f9e406 Add test for exact search with album query 2015-01-05 23:24:52 -05:00
kingosticks
1e7a4247c6 Add non-ascii utf-8 chars to test playlists 2015-01-04 20:21:10 +00:00
Thomas Adamcik
ab49d75a45 tests: Fix outstanding flake8 errors in tests 2014-12-30 00:23:08 +01:00
Thomas Adamcik
627b856578 tests: Fix MPD tests helper names 2014-12-30 00:23:08 +01:00
Thomas Adamcik
fa8547c397 tests: Add noqa markers for setUp/tearDown 2014-12-30 00:23:01 +01:00
Thomas Adamcik
a50ba6e3a7 tests: Add noqa markers to custom assert helpers 2014-12-29 23:58:36 +01:00
Thomas Adamcik
9f6e0cc5fa tests: Fix versions test pep8 naming errors 2014-12-29 23:48:59 +01:00
Thomas Adamcik
656f7e976f Merge branch 'develop' into feature/taglist-converter 
Conflicts:
	docs/changelog.rst
 2014-12-25 22:46:44 +01:00
Stein Magnus Jodal
890ed53ee6 Merge branch 'release/v0.19.x' into develop 
Conflicts:
	docs/changelog.rst
 2014-12-24 00:41:10 +01:00
Stein Magnus Jodal
6af624a369 Bump version to 0.19.5 2014-12-24 00:37:33 +01:00
Stein Magnus Jodal
dbbb86e6c0 Merge branch 'release/v0.19.x' into develop 
Conflicts:
	mopidy/core/playback.py
 2014-12-24 00:24:19 +01:00
Stein Magnus Jodal
c6ff9eee86 playback: Remove skipped track on next in consume mode 
Also adds core level tests of consume behavior on next/prev/eot.

Fixes #902
 2014-12-24 00:04:41 +01:00
Stein Magnus Jodal
6ec35b2d02 Merge branch 'release/v0.19.x' into develop 2014-12-23 22:23:32 +01:00
Stein Magnus Jodal
aa3b8ab5f8 path: Support unicode content when creating file 2014-12-23 22:21:10 +01:00
Thomas Adamcik
935a038405 audio: Only add albums that have a name 
Fixes case where we could have an empty album. We could alternatively be more
conservative and only limit to fully empty albums. But I think we only want
ones with names anyway.
 2014-12-22 22:45:31 +01:00
Thomas Adamcik
819680e074 audio: Move utils test to tests folder 2014-12-22 22:34:11 +01:00
Thomas Adamcik
9b9cdc3ade stream: Fix track conversion bug and add tests 
This adds basic checks for the library provider lookup:

- Check that uri schemes are respected
- Check that blacklisting and globbing works
- Check uri successfully gets converted to a track
 2014-12-22 22:29:36 +01:00
Thomas Adamcik
9be788b129 audio: Move tags to track conversion to audio utils 2014-12-18 23:36:56 +01:00
Thomas Adamcik
983148a9a4 audio: Start storing the tags we find in audio 
Adds a new get_currents_tags method for fetching the full set of current tags.
There are still some untested cases for this, and I also suspect we still want
some API refinements one core starts using this.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
6c62252919 audio: Add tags changed event to audio. 
Current version simply emits the keys of the changed tags to the audio
listener. Following change will add support for storing the actual data.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
de6bd63481 audio: Remove min duration code from scanner. 
The local scanner now handles this itself by looking at the duration.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
4f8244c499 audio: Convert audio_data_to_track to tags_to_track 
The new function only uses tags as input. In other words we now need to set
length, uri and mtime ourselves. Users of scan APIs have been updated.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
4948dee4b9 audio: Make scanner return duration in milliseconds 
Also ensures that we normalize unknown duration to None instead of -1.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
d9d501cd98 audio: Update scanner to just return tags+duration 
The caller should know what URI we are talking about. Additionally finding the
mtime is never belonged in this class and has been moved out.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
dcaa0f6732 local: Move musicbrainz cover art helper to translator 2014-12-18 23:28:14 +01:00
Thomas Adamcik
b365d2494b mpd: Remove "Comment" tag type from translator output. 
Newer versions of the protocol have removed this tag, so we should as well.
This also works around the issue of #881 which was breaking things with
newlines in comment fields.

The readcomments command seems to replace this, but it seems to only care about
specific extra tagtypes, not the general comment tag we normally collect when
scanning things.

(cherry picked from commit 08a8d5c43b)
 2014-12-16 23:30:38 +01:00
Stein Magnus Jodal
6e55435aa9 mpd: Enable browsing of empty dirs 
This was disabled together with a bunch of other changes without any
explanation in commit f24ca36e5a. I'm
guessing that this wasn't intentional, and no test covered the case.

(cherry picked from commit 4e508cd017)
 2014-12-16 23:25:31 +01:00
Thomas Adamcik
90fdd46109 local: Cleanup translator tests 2014-12-14 23:14:11 +01:00
Thomas Adamcik
671ee5ee6a audio: Switch to using converted taglists instead of raw data. 2014-12-14 22:25:52 +01:00
Thomas Adamcik
08a8d5c43b mpd: Remove "Comment" tag type from translator output. 
Newer versions of the protocol have removed this tag, so we should as well.
This also works around the issue of #881 which was breaking things with
newlines in comment fields.

The readcomments command seems to replace this, but it seems to only care about
specific extra tagtypes, not the general comment tag we normally collect when
scanning things.
 2014-12-14 14:16:37 +01:00
Thomas Adamcik
2c3217685b utils: Switch to exceptions.FindError for errors. 2014-12-14 14:08:45 +01:00
Stein Magnus Jodal
4e508cd017 mpd: Enable browsing of empty dirs 
This was disabled together with a bunch of other changes without any
explanation in commit f24ca36e5a. I'm
guessing that this wasn't intentional, and no test covered the case.
 2014-12-13 01:27:14 +01:00
Stein Magnus Jodal
4f428b8601 py3: Move compat module out of utils 2014-12-07 21:36:15 +01:00
Stein Magnus Jodal
7a1bb224f7 py3: Avoid indexing exception objects 
It doesn't work on Python 3.
 2014-12-07 20:26:09 +01:00
Stein Magnus Jodal
58527406c1 py3: Use compat.text_type instead of unicode 2014-12-07 20:17:10 +01:00
Stein Magnus Jodal
496142c201 py3: Use absolute imports by default 2014-12-07 20:17:10 +01:00
Stein Magnus Jodal
680dbffc0c models: Make all fields default to None or empty collection 
(cherry picked from commit abed15b9e4)
 2014-11-04 21:27:29 +01:00
Stein Magnus Jodal
a4b17a9aa8 models: Fix equality for fields set to the default 
Fixes #837

(cherry picked from commit bdd1fb983b)
 2014-11-04 20:17:20 +01:00
Stein Magnus Jodal
88d64044de models: Hide empty lists from repr() 
(cherry picked from commit 305a76486d)

Conflicts:
	docs/changelog.rst
 2014-11-04 20:17:13 +01:00
Thomas Kemmer
63277c4db3 Add unit tests for artist browsing 2014-11-04 19:22:45 +01:00
Thomas Adamcik
063c757570 utils/path: Add support for handling sym/hardlink loops 2014-10-15 23:46:08 +02:00
Thomas Adamcik
54a89038d3 utils/path: Don't skip hidden files and folders in generic find code 
Updates the local scan code to do this instead.
 2014-10-15 23:45:49 +02:00
Thomas Adamcik
9b1d20677d tests: Cleanup find tests to use tempfile all over. 
This should make it more clear what structure we expect.
 2014-10-15 23:45:27 +02:00
Thomas Adamcik
69fa6f4674 tests: Test symlink that points to it's own parent. 2014-10-15 23:45:22 +02:00
Thomas Adamcik
93c0d6cc44 tests: Update no permission test to use tempfile. 2014-10-15 23:45:12 +02:00
Thomas Adamcik
b2419f9814 tests: Add test case for a symlink pointing at itself 2014-10-15 23:45:03 +02:00
Thomas Adamcik
ebb62885cd util/path: Add basic support for following symlinks 2014-10-15 23:44:48 +02:00
Thomas Adamcik
682af27348 tests: Add test case for file without permissions. 2014-10-15 23:44:41 +02:00
Thomas Adamcik
d219bab0b2 tests: Add test for directory without permission behaviour 2014-10-15 23:44:01 +02:00
Thomas Adamcik
de5fe5ebab tests: Add test for current find symlink handling 2014-10-15 23:43:13 +02:00
Thomas Adamcik
a8017dfef1 tests: Start adding checks for find errors 2014-10-15 23:42:36 +02:00
Thomas Adamcik
de4bdbec03 tests: Minor cleanup of the existing find tests 2014-10-15 23:42:15 +02:00
Thomas Adamcik
2447e2fa40 util/path: Expose errors to callers of find helper 2014-10-15 23:42:12 +02:00
Stein Magnus Jodal
7856c14b26 tests: Use with stmt for assertRaises 2014-09-25 23:03:35 +02:00
Stein Magnus Jodal
07d088fc18 models: Use with stmts in exception tests 2014-09-24 18:26:25 +02:00
Stein Magnus Jodal
5317834baf history: Change size property to get_length() method 
For consistency with tracklist.get_length() and our goal of aligning Python
and JS APIs by using less properties in the core API.
 2014-09-23 18:47:54 +02:00
Stein Magnus Jodal
5a67339855 history: Cleanup history entry test 2014-09-23 18:47:39 +02:00
Stein Magnus Jodal
d30cf68efd history: Raise TypeError if non-Tracks are added 2014-09-23 18:42:41 +02:00
Stein Magnus Jodal
718405421d history: Rename class to HistoryController 
For consistency with other core controllers.
 2014-09-23 18:32:37 +02:00
Arjun Naik
c38b9f378f Use assertIn instead of assertTrue to test membership. 2014-09-23 18:09:12 +02:00
Arjun Naik
9006968f75 TrackHistory stores Ref instances. Timestamp as epoch in milliseconds also stored. 2014-09-23 18:09:12 +02:00
Arjun Naik
ed87ab8dd1 Added a playback history object to the core. 2014-09-23 18:09:11 +02:00
Stein Magnus Jodal
1fcc75ba1e Merge pull request #840 from tkem/feature/local-library-lookup-multiple 
local: Return multiple tracks from lookup()
 2014-09-23 14:14:22 +02:00
Stein Magnus Jodal
abed15b9e4 models: Make all fields default to None or empty collection 2014-09-22 22:25:42 +02:00
Stein Magnus Jodal
bdd1fb983b models: Fix equality for fields set to the default 
Fixes #837
 2014-09-22 22:01:50 +02:00
Stein Magnus Jodal
305a76486d models: Hide empty lists from repr() 2014-09-22 21:42:57 +02:00
Stein Magnus Jodal
f58fe9a192 py3: Replace xrange() with range() 2014-09-17 20:28:07 +02:00
Thomas Adamcik
d049b07fa9 Merge branch 'develop' into feature/audio-message-handler 2014-09-07 21:38:19 +02:00
Thomas Kemmer
806174916d Change JsonLibrary.lookup to return a list 2014-09-05 05:35:18 +02:00
Stein Magnus Jodal
d41deb1844 Merge branch 'release/v0.19.x' into develop 
Conflicts:
	docs/changelog.rst
 2014-09-01 23:17:00 +02:00
Stein Magnus Jodal
e1ab70e1e9 Bump version to 0.19.4 2014-09-01 23:08:59 +02:00
Thomas Kemmer
f90671fe96 Fixed flake8: I201 Missing newline between sections or imports 2014-08-30 14:10:39 +02:00
Thomas Kemmer
380223bb96 local: Return multiple tracks from lookup() 2014-08-30 14:02:43 +02:00
Stein Magnus Jodal
c50641230d Merge branch 'release/v0.19.x' into develop 2014-08-29 14:03:11 +02:00
Stein Magnus Jodal
a244761abc mpd: Replace / with | instead of whitespace in playlist names 2014-08-17 23:25:09 +02:00
Trygve Aaberge
15597b3c60 tests: Test call order in test_recv_callback_gets_no_data 2014-08-14 12:43:42 +02:00
Trygve Aaberge
265951bf00 network: disable_recv before telling actor to close connection 
As of d62ad96, when the connection can't receive more data from the
client, it tells the actor to stop the connection and calls
disable_recv(). The actor operates in it's own thread and when it stops
the connection, disable_recv is being called again from a different
thread. Since the actor is told to stop the connection before
disable_recv is called, the two calls to disable_recv may happen
simultaneously.

This causes a race condition issue where both threads can reach past the
check that recv_id is not None before either of them set it to None. If
one of them set it to None before the other one tries to use it, an
error is raised.

This commit calls disable_recv before telling the actor to stop the
connection. Since disable_recv is a blocking call, this ensures that
recv_id is being set to None before the actor thread begins to stop the
connection.

Fixes #781
 2014-08-14 01:58:48 +02:00
Stein Magnus Jodal
ae3a932ed3 Merge branch 'release/v0.19.x' into develop 
Conflicts:
	mopidy/config/__init__.py
 2014-08-12 23:54:14 +02:00
Thomas Adamcik
ac5bf9af17 audio: Move most of event handling out of audio. 
Some of the signal handling still needs to be moved.
 2014-08-11 22:33:49 +02:00
Thomas Adamcik
101b2a9817 audio: Make stream-changed correctly handle tee setup 
For the purposes of this event we consider the outputs sink the final element.
If we don't do this we would get one event per branch, and we don't want to
track when each of them actually switches any way. So just tracking when the
tee/outputs bin gets the event is good enough for us.

As part of this I've also added 'testoutput' as a special cased output value.
This is now needed as outputs are always synced to the clock, making testing
a lot less practical.
 2014-08-11 22:33:49 +02:00
Trygve Aaberge
584484379a config: Only load .conf-files when loading directories 2014-08-11 16:21:34 +02:00
Trygve Aaberge
9e41eff187 config: Support passing directories to mopidy --config 2014-08-11 14:48:04 +02:00
Trygve Aaberge
c798257f00 mpd: Test that "list album foo" responds correctly 
Previously, test_list_album_with_artist_name would only test that the
command didn't fail. Now it also checks that the response is correct.
That is, that the response contains albums.

This makes the test detect the error reported in #817.

(cherry picked from commit 9771eda230)
 2014-08-05 23:52:40 +02:00
Trygve Aaberge
9771eda230 mpd: Test that "list album foo" responds correctly 
Previously, test_list_album_with_artist_name would only test that the
command didn't fail. Now it also checks that the response is correct.
That is, that the response contains albums.

This makes the test detect the error reported in #817.
 2014-08-05 18:34:08 +02:00
Thomas Adamcik
d650c0ba14 audio: Split out ouput handling from audio actor 
This also lays some basic ground work for handling multiple outputs.
 2014-08-03 23:57:22 +02:00
Stein Magnus Jodal
e9822117e5 Merge branch 'master' into develop 
Conflicts:
	docs/changelog.rst
 2014-08-03 23:40:18 +02:00
Stein Magnus Jodal
dc80f17296 Bump version to 0.19.3 2014-08-03 23:34:25 +02:00
Stein Magnus Jodal
9260ae23a7 Merge branch 'release/v0.19.x' into develop 2014-08-03 23:13:40 +02:00
Stein Magnus Jodal
837fb00fb7 Fail early if extension doesn't implement setup() 
Fixes #813
 2014-08-03 23:13:14 +02:00
Thomas Adamcik
5d1dd1a355 review-fixes: Mostly typos etc. 2014-08-02 20:45:55 +02:00
Thomas Adamcik
bf752859da flake8: Fix duplicate import and import order in audio actor test 2014-07-29 23:12:53 +02:00
Thomas Adamcik
e73159dc6c Merge branch 'develop' into feature/audio-prep-work-for-gapless 2014-07-29 23:07:08 +02:00
Ignasi Fosch
e9289ca554 Checks for musicbrainz album ID and sets images to a list containing the corresponding URL 2014-07-27 16:34:28 +02:00
Stein Magnus Jodal
3bc82f82ac Bump version to 0.19.2 2014-07-26 14:18:50 +02:00
Stein Magnus Jodal
93bf3ea918 mpd: Fix crash on wrong number of command args 
Fixes #789
 2014-07-26 13:56:26 +02:00
Ignasi Fosch
9d493792bf version help test fixed 2014-07-26 12:31:53 +02:00
Stein Magnus Jodal
19dae10575 Bump version to 0.19.1 2014-07-23 18:14:00 +02:00
Thomas Adamcik
2aeb87e003 Merge branch 'develop' into feature/audio-prep-work-for-gapless 
Conflict files fixed up to a state where tests pass again before commit.

Conflicts:
	mopidy/audio/actor.py
	mopidy/audio/listener.py
	tests/audio/test_actor.py
	tests/audio/test_listener.py
 2014-07-23 00:06:29 +02:00
Stein Magnus Jodal
0bf7302005 Merge remote-tracking branch 'adamcik/fix/gh-734-cleanup-audio-buffering' into develop 
Conflicts:
	mopidy/audio/actor.py
 2014-07-20 12:29:49 +02:00
Stein Magnus Jodal
1ebe1151fc http: Make event emitting testable 2014-07-17 01:14:06 +02:00
Stein Magnus Jodal
3fac0cb8de http: Split socket and server creation 2014-07-17 01:13:48 +02:00
Stein Magnus Jodal
7e6d3de81a Merge branch 'develop' into feature/mixers 
Conflicts:
	mopidy/backend/__init__.py
 2014-07-16 22:12:07 +02:00
Stein Magnus Jodal
44664f2796 exc: Add {Backend,Frontend,Mixer}Error exceptions 
(cherry picked from commit bf8307f329)
 2014-07-16 10:32:18 +02:00
Stein Magnus Jodal
7e489ccb0b exc: Test ScannerError 
(cherry picked from commit 8f59dd69ad)
 2014-07-16 10:32:15 +02:00
Stein Magnus Jodal
dda06dd8de config: Add optional support to Boolean type 2014-07-15 00:33:30 +02:00
Thomas Adamcik
d8c41de2f7 audio: Add tests for state changes while buffering 2014-07-14 23:15:40 +02:00
Stein Magnus Jodal
d15d66f070 Use 'mute' instead of 'muted', to avoid changing old APIs 2014-07-12 03:14:19 +02:00
Stein Magnus Jodal
249114b051 audio: Update tests broken by 5f091c10 2014-07-12 03:12:21 +02:00
Stein Magnus Jodal
a3dc763b29 core: Forward {volume,mute}_changed events, don't trigger them ourselves 2014-07-10 01:15:44 +02:00
Stein Magnus Jodal
b8de7fa75c mixer: Add MixerListener 2014-07-10 01:00:35 +02:00
Stein Magnus Jodal
bf8307f329 exc: Add {Backend,Frontend,Mixer}Error exceptions 2014-07-09 22:17:46 +02:00
Stein Magnus Jodal
8f59dd69ad exc: Test ScannerError 2014-07-09 22:15:45 +02:00
Stein Magnus Jodal
9da716935c audio: Only expose GStreamer's software mixer 2014-07-08 01:34:33 +02:00
Stein Magnus Jodal
6d6bc4b808 core: Use new mixer API 2014-07-08 01:11:25 +02:00
Stein Magnus Jodal
9ced0f740f Merge 'dz0ny/bug/fix-708-duplicate' into develop 2014-07-01 23:25:49 +02:00
dz0ny
d871ca9128 Remove duplicates from library root. 
Closes #708
 2014-06-26 16:27:22 +02:00
Trygve Aaberge
c062dd21c4 mpd: Create unique names for all items in browse 
Replace the playlist uri/name mapping with a mapping for all the items
in browse. Check the mapping when browsing a path.

This has the added benefit of serving as a cache for browse, so we don't
need to traverse the path parts and lookup each of them for each call to
browse.
 2014-06-24 00:45:49 +02:00
Thomas Adamcik
e4d4652c68 Merge pull request #759 from jodal/feature/web-client-selector 
Add web client selector
 2014-06-23 22:47:14 +02:00
Stein Magnus Jodal
25f41664d7 Bump version number to 0.19 2014-06-23 22:32:43 +02:00
Stein Magnus Jodal
aed8670797 http: Fix flake8 warnings 2014-06-22 09:53:03 +02:00
Stein Magnus Jodal
9b9791ab5b Merge pull request #755 from trygveaa/feature/lsinfo-change-order 
mpd: List browse results before playlists in lsinfo
 2014-06-22 09:49:00 +02:00
Trygve Aaberge
1ac470c58c mpd: Test that whitespace query parts are ignored 2014-06-22 02:13:14 +02:00
Stein Magnus Jodal
9f925570d2 http: Redirect from root to /mopidy/ if no static_dir app 2014-06-22 01:24:57 +02:00
Stein Magnus Jodal
6596871918 http: Test serving og legacy static_dir apps 2014-06-22 01:22:22 +02:00
Stein Magnus Jodal
5861071bb1 http: List installed web clients at /mopidy/ 2014-06-22 00:39:54 +02:00
Stein Magnus Jodal
59760bb36c web: Remove WebSocket demo page 2014-06-21 23:27:35 +02:00
Trygve Aaberge
0c3e5bd71e mpd: Test that empty query parts are ignored 2014-06-21 17:29:41 +02:00
Thomas Adamcik
7975815cde audio: Expand audio state changed with target state 2014-06-21 17:28:25 +02:00
Stein Magnus Jodal
fbcc73004d http: Redirect from /app to /app/ 2014-06-21 16:36:16 +02:00
Stein Magnus Jodal
6c6600c37b http: Group HTTP server tests 2014-06-21 16:21:39 +02:00
dz0ny
7c428ce8d2 Fix http router so it can handle /{ext_name} same as /{ext_name}/ 2014-06-21 15:05:13 +02:00
Trygve Aaberge
81898cb709 mpd: Test order of result from lsinfo 2014-06-21 14:42:35 +02:00
Thomas Adamcik
2e1ca08fef audio: Use on buffering internal in buferring tests 2014-06-21 14:20:56 +02:00
Thomas Adamcik
58976ef52d config: Lists need to handle missing values 2014-06-21 14:11:24 +02:00
Trygve Aaberge
0b7243dce1 mpd: Test albums in listall(info) 2014-06-21 01:52:44 +02:00
Stein Magnus Jodal
4cd545e147 Merge branch 'trygveaa/feature/mpd-browse-playlists' into develop 2014-06-20 22:19:48 +02:00
Trygve Aaberge
496b3f5552 mpd: Test playlists in listall(info) 2014-06-20 22:16:27 +02:00
Thomas Adamcik
c87684aa6b audio: Handle all caps ASX tags. 
Also add support for simple asx format.
 2014-06-20 21:31:03 +02:00
Stein Magnus Jodal
720a403439 http: Remove unused Router class 2014-06-04 21:32:54 +02:00
Stein Magnus Jodal
33228f2528 http: Simplify app registration 2014-06-04 21:32:19 +02:00
Stein Magnus Jodal
b6ab29eed4 http: Remove unused code 2014-06-04 21:02:33 +02:00
Stein Magnus Jodal
d13194dfa4 http: Remove static file serving from the Router 2014-06-04 20:55:28 +02:00
Stein Magnus Jodal
eea6138b3d http: Simplify static files serving 2014-06-04 20:47:49 +02:00
Stein Magnus Jodal
684a64405d http: Move MopidyHttpRouter into handlers module 2014-05-22 21:03:42 +02:00
Stein Magnus Jodal
1223103e8f http: Test that routers can mount WSGI apps 2014-05-21 00:38:38 +02:00
Stein Magnus Jodal
fe9a126a2a http: Enforce router's URL namespace 2014-05-20 23:53:26 +02:00
Stein Magnus Jodal
4b383c1762 http: Move Mopidy request handlers to a MopidyHttpRouter 2014-05-20 23:49:22 +02:00
Stein Magnus Jodal
5d1f8f2203 http: Give routers access to the core API 2014-05-20 23:30:49 +02:00
Stein Magnus Jodal
5897675eab http: Split tests into three files 2014-05-20 23:07:28 +02:00
Stein Magnus Jodal
e9ff16fe63 http: Simplify test imports 2014-05-20 22:55:37 +02:00
Stein Magnus Jodal
6d04aaf3e4 http: More consistent use of 'request handler' 2014-05-20 22:50:45 +02:00
Stein Magnus Jodal
ea5a317b00 http: Avoid tornado import before extension is loaded, group all handlers 2014-05-20 22:36:15 +02:00
Stein Magnus Jodal
1a72f68707 http: Import modules, not attributes 2014-05-20 22:32:45 +02:00
Stein Magnus Jodal
1838f10dcf http: Rename 'setup_routes()' to 'get_request_handlers()' 2014-05-20 22:28:18 +02:00
Stein Magnus Jodal
e8291d471e http: Rename 'linkify()' to 'get_root_url()' 2014-05-20 22:16:01 +02:00
Stein Magnus Jodal
cad0207ef8 http: Rename 'path' to 'static_file_path' 2014-05-20 22:12:06 +02:00
dz0ny
031c7c8e93 Add: Tornado as required dependency 
Fix: Remove draft76
Fix: Remove class attributes for ws handler
Revert: default to /ws/ for for mopidy.html
 2014-05-12 16:16:08 +02:00
dz0ny
73721c77ad Fix: Fields order doesn't matter for json. Test for valid dict and data only 2014-05-12 15:14:42 +02:00
dz0ny
26833b4093 Fix: Import order for whole PR 2014-05-12 14:54:50 +02:00
dz0ny
f1d1a4713b Squashed commit of the following: 
commit dbb7005aa866cdc337bde9c8169e9bf15e5c8042
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 11 22:12:58 2014 +0200

    Fix: Make PR mergable

commit 5bb27da72c4276a930bf33955e6583f6781d23f6
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 23:31:54 2014 +0200

    Add: helper method for extensin url

commit 8a348b26b65102084a606ff73384a478bb785cf1
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 00:35:50 2014 +0200

    Add: Refactor ws and rpc to handlers, reuse code

commit 677c809d2b39a6c982ab835368fdb8a3ad9d1a92
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 00:18:10 2014 +0200

    Fix: Return proper HTTP headers

commit fe5fea2fc2a0d28a39532d6d4cd2b21013d57d24
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Wed May 7 23:48:19 2014 +0200

    Add: RPC post handler
    Add: tests for http post handler

commit e77e60310853b368758b09b303a96a95ff1b9b93
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 22:15:04 2014 +0200

    Add: Documentation on how to extend http api

commit a3a14fb5d15f095e5bab23a590e0a8360a039f9a
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 19:48:34 2014 +0200

    Add: HTTP tests for default router and static handler

commit 0d9544256bcb8f048eaedb5cdd57b1de027d387b
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:44:32 2014 +0200

    Fix: Move StaticFileHandler to main http package

commit c83c9f661e658e4a843dc5c8c6ba5dc3f1ea9c1e
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:29:49 2014 +0200

    Add: default Router implementation

commit 258cb7210bdf13833884c04cfb7fb4fa704394a7
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:00:46 2014 +0200

    Add: Switch to registry for router registration

commit b7bfe7b814235b030d7ac30de90e2331e3d809d3
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 21:52:58 2014 +0200

    Fix: Private methods
    Fix: Point to mopidy.html instead main.html
    Fix: Less noise in console

commit 232abe3029e93f78ce25db0c1bd44743cc23ed2d
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 21:32:07 2014 +0200

    Fix: Start IOLoop in separate thread, so actor can stop it

commit d686892c2fa993cbedc99c8e8e7f9c961ac6f35a
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 19:30:49 2014 +0200

    Fix: Router load order
    Fix: JS helper library WSS default url
    Add: Handlers from extensions

commit a1b0f5673a6719f229df27feccb284324675e9d1
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 14:53:30 2014 +0200

    Add: Switch to Tornado framework
 2014-05-12 14:54:50 +02:00
Stein Magnus Jodal
95c06f40db audio: Fix test setup 2014-05-12 14:52:45 +02:00
Thomas Adamcik
e4e7b20f74 flake: Fix stupid flake error caused by newly added check 2014-05-08 22:57:02 +02:00
Thomas Adamcik
56b9724ffc Merge pull request #715 from geigerzaehler/gst-buffer 
Pause gstreamer when buffering
 2014-05-08 22:07:13 +02:00
Stein Magnus Jodal
b754885064 Fix all import order warnings 2014-05-07 20:08:43 +02:00
Stein Magnus Jodal
2979de0f94 http: Polish Mopidy-HTTP Zeroconf service 
Builds upon #725 to:

- Remove extra config for Mopidy-HTTP Zeroconf service
- Refactor Zeroconf setup code in the HTTP frontend a bit
- Add documentation
 2014-05-06 23:20:14 +02:00
Stein Magnus Jodal
1b5c21452f Merge wlcx/feature/zeroconf-announce-mopidy into develop 2014-05-06 23:16:26 +02:00
Sam Willcocks
05089fba3b Update tests to add zeroconf-websocket config option 2014-04-27 17:50:41 +01:00
Trygve Aaberge
d62ad966af network: Respond to messages before closing connections 
This makes a connection tell the actor to stop the connection, instead
of stopping it itself. This is preferable, because other messages sent
to the actor that is not processed yet, may now send data to the client.

E.g. it makes this work:
$ echo status | nc localhost 6600
 2014-04-25 06:11:01 +02:00
Thomas Scholtes
2b7ff237b8 Add tests for Audio buffering 2014-04-03 21:43:56 +02:00
Stein Magnus Jodal
5583ca5aba New flake8 version with new checks to conform to 2014-03-29 20:47:42 +01:00
Stein Magnus Jodal
957036c899 Merge pull request #707 into develop 
Improve scan performance for remote filesystems
 2014-03-02 08:34:54 +01:00
Stein Magnus Jodal
061ff00a39 tests: Don't depend on the order of random sequences 2014-02-28 01:17:53 +01:00
Thomas Adamcik
7386dd30b6 utils: Remove old find_files 2014-02-26 23:53:12 +01:00
Thomas Adamcik
5b7a6065e7 util: Add find_mtimes helper 2014-02-26 23:27:44 +01:00
Stein Magnus Jodal
30dde4e593 ext: Remove old extension API 
As far as I know, all extensions except Mopidy-Arcam (not currently
maintained) and Mopidy-VKontakte already use the new API. Both of the
remaining extensions got open pull requests with the needed changes to use the
new API.
 2014-02-17 11:44:57 +01:00
Thomas Adamcik
79ce2ab902 Merge branch 'develop' into feature/mpd-tokenized-requests 
Conflicts:
	docs/changelog.rst
 2014-02-16 23:22:07 +01:00
Thomas Adamcik
8756c2bff5 review: Type fixing 2014-02-16 23:17:46 +01:00
Stein Magnus Jodal
4df730742d Release v0.18.3 2014-02-16 21:46:21 +01:00
Stein Magnus Jodal
fa15e7a264 Bump version number to 0.18.2 2014-02-16 21:24:57 +01:00
Thomas Adamcik
2e6f716b72 Merge branch 'develop' into feature/mpd-tokenized-requests 
Conflicts:
	mopidy/mpd/protocol/stored_playlists.py
 2014-01-30 22:48:28 +01:00
Thomas Adamcik
e4932c05b1 audio: Add more TODOs 2014-01-30 22:21:59 +01:00
Stein Magnus Jodal
38d3c6ccf9 models: Make Playlist.last_modified milliseconds since Unix epoch 2014-01-28 23:57:02 +01:00
Thomas Adamcik
dd98ad8353 audio: Update tests and dummy audio actor to pass 2014-01-28 23:19:33 +01:00
Thomas Adamcik
d1b91117b4 audio: Update dummy audio used for testing 2014-01-28 21:34:31 +01:00
Thomas Adamcik
0d18bdea79 audio: Add about to finish callback support 2014-01-27 23:43:11 +01:00
Thomas Adamcik
99d581f7fc audio: Add position_changed event to know when seeks happen 2014-01-27 23:04:15 +01:00
Thomas Adamcik
6490d5bd2d audio: Add more tests for audio events 2014-01-27 22:34:42 +01:00
Thomas Adamcik
a4315251ca audio: Slight test refactor to not hide what is going on 2014-01-26 23:30:12 +01:00
Thomas Adamcik
d962277bc9 audio: Add stream_changed event plus tests 2014-01-26 23:27:30 +01:00
Thomas Adamcik
f24ca36e5a mpd: Switch browse commands to common helper 2014-01-25 00:42:32 +01:00
Thomas Adamcik
3cec929bd7 Merge branch 'develop' into feature/mpd-tokenized-requests 
Conflicts:
	mopidy/mpd/protocol/music_db.py
	tests/mpd/protocol/test_music_db.py
 2014-01-24 19:38:56 +01:00
Thomas Adamcik
da724e6b77 Merge remote-tracking branch 'UncommonGoods/develop' into develop 2014-01-24 19:31:25 +01:00
Thomas Adamcik
e304b7fc2b mpd: Use mopidy.mpd.exceptions in commands 2014-01-24 01:12:26 +01:00
Thomas Adamcik
86f5602023 mpd: Remove old command handlers 2014-01-24 00:35:10 +01:00
Thomas Adamcik
dc8d311bc3 mpd: Complete music db conversion with list 2014-01-24 00:23:05 +01:00
Thomas Adamcik
68aa0b556c mpd: Convert search functions in music db 2014-01-23 23:58:42 +01:00
Stein Magnus Jodal
bf9499131a Bump version number to 0.18.1 2014-01-23 23:19:51 +01:00
Thomas Adamcik
8f8bed5b87 mpd: Implement playlistinfo from current playlist 2014-01-23 23:12:25 +01:00