Commit Graph

7288 Commits

Author SHA1 Message Date
Thomas Adamcik
79a4835e4e core: Add tests for change_track failing in about-to-finish 2016-02-14 17:23:20 +01:00
Thomas Adamcik
76ab5ffb04 core: Make sure exceptions from backend's change_track is handled
Also adds TODOs for the rest of the backend calls in playback which all need to
assume backends can and will screw up.
2016-02-14 17:16:31 +01:00
Thomas Adamcik
b293a116b6 audio: Make sure about to finish skips unplayable tracks 2016-02-14 16:26:47 +01:00
Thomas Adamcik
440969aead Merge pull request #1444 from jodal/fix/1418-unmerged-fixes-and-tests-from-1.1
core: Unmerged fixes and tests from 1.1 regarding unplayable tracks
2016-02-14 16:24:25 +01:00
Stein Magnus Jodal
9b18ff07ee core: Readd regression test for #1352
Fixes #1418

Based on test that was present in 1.1.2 but dropped in the #1400 merge.
2016-02-14 16:12:45 +01:00
Stein Magnus Jodal
a42ce9f00e core: Test next/prev skips over unplayable tracks
Fixes #1418

Based on tests that was present in 1.1.2 but dropped in the #1400 merge.
2016-02-14 15:47:22 +01:00
Stein Magnus Jodal
cc82e68a58 core: Remove unplayable track in consume mode
Fixes #1418

This was previously fixed in 1.1.2, but the fix was skipped in when
release-1.1 was merged into develop in #1400, thus no changelog entry.
2016-02-14 15:47:22 +01:00
Stein Magnus Jodal
0539e4e8fe Revert "core: Add TODO for testing unplayable-by-backend tracks"
This reverts commit 3a8d896146.
2016-02-14 15:47:18 +01:00
Stein Magnus Jodal
3a8d896146 core: Add TODO for testing unplayable-by-backend tracks 2016-02-14 12:49:15 +01:00
Stein Magnus Jodal
7a8d166e19 Merge pull request #1439 from adamcik/fix/1304-postpone-tags
Postpone tags between about-to-finish and stream-start
2016-02-14 12:40:02 +01:00
Thomas Adamcik
d20621c801 docs: Add changelog entry for tags_changed 2016-02-14 12:36:55 +01:00
Thomas Adamcik
b63b3c288a audio: Postpone tags until after stream-start
When a new URI gets set we create a pending tags dictionary. This gets all the
tags until stream-start, at which point they are all emitted at once. During
track playback tags works as before.

This ensure we don't prematurely tell clients about metadata changes.
2016-02-14 12:36:19 +01:00
Thomas Adamcik
c23cad5d13 audio: Only emit tags changed when tags changed.
Previously we alerted AudioListeners about all new tags, now we filter it down
to just the changed ones. Only real reason for this is that the changed
messages spam the log output making debugging harder.
2016-02-14 12:36:19 +01:00
Stein Magnus Jodal
69a52bf031 Merge pull request #1443 from tkem/fix/1428
Fix #1428: Add m3u/base_dir confval.
2016-02-14 12:14:21 +01:00
Thomas Kemmer
6aef96a0d3 Fix #1428: Add m3u/base_dir confval. 2016-02-14 12:07:22 +01:00
Stein Magnus Jodal
6b873816af Merge pull request #1442 from trygveaa/fix/audio-config-buffer-size
audio: Add a config option for queue buffer size
2016-02-14 00:27:37 +01:00
Trygve Aaberge
59dadc6535 docs: Link to config and clarify buffer size 2016-02-14 00:21:22 +01:00
Trygve Aaberge
3e781310f9 tests: Add buffer_time to test config 2016-02-14 00:15:27 +01:00
Trygve Aaberge
0580a46688 audio: Add a config option for queue buffer size
It may help to increase this for users that are experiencing buffering
before track changes. Workaround for #1409.
2016-02-13 23:37:22 +01:00
Thomas Adamcik
23d0bd290d Merge pull request #1438 from jodal/fix/1430-audio-crash
audio: Workaround crash caused by race
2016-02-13 20:57:29 +01:00
Stein Magnus Jodal
68add6cda9 audio: Workaround crash caused by race
Fixes #1430. See #1222 for explanation and proper fix.
2016-02-10 23:03:36 +01:00
Stein Magnus Jodal
be568b769f Merge pull request #1437 from jodal/fix/1435-stop-on-sigterm
Stop GLib mainloop on SIGTERM
2016-02-10 21:59:33 +01:00
Stein Magnus Jodal
e88b2a7beb commands: Make GLib quit mainloop on SIGTERM
Fixes #1435
2016-02-10 21:37:28 +01:00
Stein Magnus Jodal
3a7e7cdde0 process: Rename exit_handler() to sigterm_handler() 2016-02-10 21:34:37 +01:00
Stein Magnus Jodal
4691bf5ea6 process: Remove unused BaseThread class 2016-02-10 21:09:16 +01:00
Stein Magnus Jodal
6d856e88bb docs: Add missing packages for Debian stable and Ubuntu < 15.10
Fixes #1434
2016-02-10 19:12:59 +01:00
Stein Magnus Jodal
c4da2c240f Merge pull request #1433 from trygveaa/fix/gst-init
Fix errors and warnings when importing Gst with gst-python >= 1.5.2
2016-02-08 09:00:24 +01:00
Trygve Aaberge
17d96edd41 gst1: Import GstPbutils after calling Gst.init
With gst-python 1.6.2, importing GstPbutils before calling Gst.init
gives some warnings.
2016-02-08 00:31:50 +01:00
Trygve Aaberge
fefb6aa5a2 gst1: Don't check Gst.is_initialized before calling Gst.init
As of gst-python 1.5.2, Gst.is_initialized throws a NotInitialized
exception if run before Gst.init. Gst.init should be a noop if run again
after the first call, so this should be safe.

This fixes #1432.
2016-02-08 00:31:45 +01:00
Trygve Aaberge
6cbfe86677 gst1: Send in an argument to Gst.init
As of gst-python 1.5.2, the init call requires one argument. The
argument is a list of the command line options. I don't think we need to
send any.

This relates to #1432.
2016-02-08 00:31:16 +01:00
Stein Magnus Jodal
e67e4c2c6e core: Avoid use of deprecated property 2016-02-07 22:06:48 +01:00
Stein Magnus Jodal
cd83084804 tests: Merge TestPlayUnknownHandling into TestUnplayableURI 2016-02-07 22:01:33 +01:00
Stein Magnus Jodal
1f4f0ab03b tests: Prefix some test classes with 'Test'
We don't want to rely on them subclassing unittest.TestCase.
2016-02-07 22:00:16 +01:00
Stein Magnus Jodal
4d0bc755a0 docs: Fix typo 2016-02-07 13:03:19 +01:00
Stein Magnus Jodal
78d10c4ab8 Reduce variation in Pykka imports
Which lets us reduce the amount of mocked modules when building docs
2016-02-07 12:55:13 +01:00
Stein Magnus Jodal
95b21599c7 docs: Update mocks for docs build without all deps
Fixes #1431
2016-02-07 12:45:16 +01:00
Stein Magnus Jodal
3f7fbf67f3 Fix remaining gi.repository imports 2016-02-07 12:45:12 +01:00
Stein Magnus Jodal
e7184cf0b3 Bump version to 2.0.0 because of GStreamer 1
Doing it right away instead of just before release for compat with
Mopidy-Spotify's develop branch.
2016-02-06 01:23:23 +01:00
Stein Magnus Jodal
ace7634804 gst1: Require GStreamer >= 1.2.3 2016-02-05 12:05:30 +01:00
Stein Magnus Jodal
0ac50ed499 docs: Update Arch source install to use new gst-python2 package
Thanks to Sergej Pupykin
2016-02-04 14:45:39 +01:00
Stein Magnus Jodal
b3f8460a94 gst1: Fix taglist creation 2016-02-04 00:24:44 +01:00
Stein Magnus Jodal
d0783db422 docs: Fix link text 2016-02-04 00:12:19 +01:00
Stein Magnus Jodal
79cdc16d64 Merge pull request #1426 from adamcik/fix/1404-duplicate-seeks
audio: Prevent double seeks in appsrc (fixes: #1404)
2016-02-03 23:40:31 +01:00
Stein Magnus Jodal
42a0f63ece docs: Update Icecast streaming section
Fixes #1351
2016-02-03 23:37:07 +01:00
Stein Magnus Jodal
851c206d45 docs: Move advanced audio setups out of config page 2016-02-03 23:11:18 +01:00
Thomas Adamcik
0336b6077c audio: Prevent double seeks in appsrc (fixes: #1404)
Sending the seek event to the playbin forwards it to all sinks. Which in turn
means on seek event per sink. To avoid this we inject the seek event in an
element before the tee.
2016-02-03 22:38:25 +01:00
Stein Magnus Jodal
30b50b64d3 docs: Update gst-{launch,inspect}-{0.10 => 1.0} 2016-02-03 22:24:20 +01:00
Stein Magnus Jodal
c749647a7b deps: lamemp3enc replaces lame in Gst1 2016-02-03 22:10:11 +01:00
Stein Magnus Jodal
dd7caa322d deps: mpg123audiocodec is an alternative to flump3dec and mad on Gst1 2016-02-03 22:09:52 +01:00
Stein Magnus Jodal
5e1633e1e2 deps: mpegaudioparse replaces mp3parse in Gst1 2016-02-03 22:09:22 +01:00