andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7,741 Commits 1 Branch 0 Tags 24 MiB
release-2.2-my
Commit Graph

2288 Commits

Author SHA1 Message Date
Stein Magnus Jodal
07cf962434 Merge branch 'develop' into feature/new-playlists-api 
Conflicts:
	docs/changelog.rst
 2015-03-23 21:45:32 +01:00
Stein Magnus Jodal
dbe4165a0f m3u: Only test through core actor 2015-03-23 13:31:25 +01:00
Thomas Adamcik
6d22c4fd59 core: Remove set_current_tl_track 2015-03-23 00:50:05 +01:00
Thomas Adamcik
07f0453c6e core: Make event triggers internal 2015-03-23 00:50:05 +01:00
Stein Magnus Jodal
d37bd62bb1 backend: Remove playlists.playlists property 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
e3f2e368c7 m3u: Add playlists.get_items() 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
4bae9c874c m3u: Add playlists.as_list() 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
5693b454ee m3u: Use lookup() instead of playlists prop in tests 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
bd2e4f7af0 core: Reimplement get_playlists() using new backend API 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
4f3a0839b3 core: Add playlists.as_list() and playlists.get_items(uri) 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
55b1eb7383 backend: Add playlists.as_list() and playlists.get_items(uri) 2015-03-23 00:44:39 +01:00
Stein Magnus Jodal
9462071e0c Merge pull request #1074 from adamcik/fix/1069-handle-broken-backends 
core: Protect against old clients that implement backend.play
 2015-03-23 00:05:05 +01:00
Thomas Adamcik
a74bc24bdc core: Protect against old clients that implement backend.play 2015-03-22 23:54:37 +01:00
Thomas Adamcik
7ec2342921 core: Normalize search queries 
This is needed as otherwise each and every backend needs to handle the fact
that some "bad" clients might send {'field': 'value'} instead of
{'field': ['value']} Though the real problem isn't the clients but our
organically grown query API.
 2015-03-22 23:33:49 +01:00
Thomas Adamcik
28f8a99090 review: Fixed mock use and docstring 2015-03-22 23:14:29 +01:00
Thomas Adamcik
efe9430c7a core: Update playback code to take change track into account. 
This change has us checking the return value of change_track when deciding if
the play call was a success or if the track is unplayable. Which ensures that
the following can no longer happen: 1) play stream 2) play stream that fails
change_track 3) stream 1) continues playing. Correct behavior being the next
stream playing instead.
 2015-03-22 22:12:51 +01:00
Thomas Kemmer
67d4dac862 m3u: Store by URI internally 
Based upon tkem's PR #1053
 2015-03-22 21:54:29 +01:00
Stein Magnus Jodal
12649265b1 Bump version to 1.0.0 
So that the development version of extensions can start depending on
1.0.0 and test that they work with the changed APIs.
 2015-03-22 09:25:04 +01:00
Stein Magnus Jodal
56dca0e931 Merge pull request #1064 from adamcik/fix/1052-break-backend-play 
backend: Change playback API (breaking change!)
 2015-03-22 09:19:39 +01:00
Stein Magnus Jodal
b2f60bc338 m3u: Extract new M3U backend from local 
Fixes #1054
 2015-03-21 08:13:45 +01:00
Thomas Adamcik
31d12c7e1d Merge pull request #1065 from jodal/fix/1060-tracklist-add-uris 
core: Add uris kwarg to tracklist.add()
 2015-03-21 00:42:22 +01:00
Stein Magnus Jodal
2bc3db0d0e core: Add uris kwarg to tracklist.core() 
Fixes #1060
 2015-03-21 00:16:24 +01:00
Stein Magnus Jodal
f67e55618c core: Make lookup(uris=...) return dict with all uris 
All uris given to lookup should be in the result even if there is no
backend to handle the uri, and the lookup result thus is an empty list.

As a side effect, future.get() is now called in the order of the URIs
in the `uris` list, making it easier to mock out
backend.library.lookup() in core layer tests.
 2015-03-21 00:11:15 +01:00
Thomas Adamcik
bbf52eede9 backend: Change playback API (breaking change!) 
While trying to remove traces of stop calls in core to get gapless working I
found we had no way to switch to switch tracks without triggering a play. This
change fixes this by changing the backends playback provider API.

- play() now _only_ starts playback and does not take any arguments.
- prepare_change() has been added, this could have been avoided with a kwarg to
  change_track(track), but that would break more backends.
- core has been updated to call prepare_change+change_track+play as needed.
- tests have been updated to handle this change.

Longer term I hope to completely rework the playback API in backends, as 99% of
our backends only use change_track(track) to translate URIs. So we should make
simple case simple, and handle mopidy-spotify / appsrc in some other way.

Cherry picked from the WIP gapless branch.
 2015-03-21 00:05:00 +01:00
Stein Magnus Jodal
861f60e6f1 core: Make history.add() private 
Instead of changing the signature to add(uri, name) I opted for
renaming it to _add_track(track).

Since it's internal we may change it whenever we like to. Since you need
different logic for extracting an interesting name from a track and from
a ref or a stream title, it makes sense to add another method for adding
refs/stream titles to the history when that time comes.

Fixes #1056
 2015-03-20 22:41:56 +01:00
Stein Magnus Jodal
dc982cd880 Merge pull request #1047 from adamcik/fix/1008-add-uris-to-lookup 
core: Add uris argument to library.lookup (Fixes #1008)
 2015-03-18 23:24:29 +01:00
Stein Magnus Jodal
65c5242b14 backend: Remove default impl of PlaylistProvider.playlists 
The default was insane. For one, because overriding e.g. just the
getter would make the property have a pair of working getter and
setter that are entirely disconnected.
 2015-03-18 00:25:26 +01:00
Thomas Adamcik
fdc84c3905 core: Add uris argument to library.lookup (Fixes #1008) 
For now this doesn't add any corresponding APIs to backends, or for that matter
tracklist.add(uris). This is just to get the API in for clients in 0.20.
 2015-03-17 23:49:21 +01:00
Thomas Adamcik
65f87e89f1 core: Update pending track handling and fix consume / gapless issue 
- Pending track should only be triggered by stream_changed if there is one.
- Tracklist changed was incorrectly calling stop breaking tests and gapless
- Tests have been updated to capture and replay audio events. This should avoid
  test deadlocks while still using the audio fakes.
 2015-03-16 23:50:08 +01:00
Stein Magnus Jodal
5240b50f8b Merge pull request #1040 from adamcik/fix/only-update-stream-title-for-streams 
core: Only emit stream title changed for streams
 2015-03-15 21:27:50 +01:00
Stein Magnus Jodal
0f21e7425e Merge pull request #1039 from adamcik/bug/923/duration-as-int-or-none 
core: Correctly handle missing duration in seek.
 2015-03-15 21:26:16 +01:00
Thomas Adamcik
28d047e1d2 core: Only emit stream title changed for streams 
This is done by checking for the presence of the organization tag typically set
by web streams. This might be a bit to strict and a bad heuristic, but it's
currently better than wrongly emitting stream titles for non streams IMO.
 2015-03-15 11:42:01 +01:00
Thomas Adamcik
6adeea6009 core: Correctly handle missing duration in seek. 
Seeks will now fail when the duration is None, this is an approximation to if
the track is seekable or not. This check is need as otherwise seeking a radio
stream will trigger the next track.

If the track truly isn't seekable despite having a duration we should still
fail as GStreamer will reject the seek.
 2015-03-15 11:29:07 +01:00
Stein Magnus Jodal
aed91008a3 deps: Add executable path to 'mopidy deps' output 2015-03-14 23:07:59 +01:00
Stein Magnus Jodal
336ef4534a tests: Use assertEqual instead of assertEquals 2015-03-14 23:01:49 +01:00
Thomas Kemmer
29b4a2075a local: Fix get_images() for local libraries returning single track from lookup(). 2015-03-14 16:12:46 +01:00
Thomas Adamcik
6260ba00be core: Test stream_title_changed listener 2015-03-14 00:30:46 +01:00
Thomas Adamcik
67f9bd73bf Merge branch 'develop' into feature/stream-reference 
Conflicts:
	docs/changelog.rst
 2015-03-14 00:28:51 +01:00
Thomas Adamcik
ea97047607 flake8: Fix bad import 2015-03-14 00:10:21 +01:00
Thomas Adamcik
4db4b4d63b core: Reduce stream metadata to just the title 
The API I really want for this to support regular tracks, stream updates and
dynamic playlists is still unclear to me. As such I'm taking the KISS approach
and reducing this to just the stream title and nothing else.

If all goes as planed this will be replaced by playback_track_changed(tlid, ref)
style events and other improvements in a later version.
 2015-03-13 23:56:51 +01:00
Thomas Adamcik
980e04537b Merge pull request #1035 from jodal/feature/none-mixer-adjustments 
core/mpd: None-mixer adjustments
 2015-03-13 23:31:20 +01:00
Stein Magnus Jodal
30badf60b9 Merge pull request #1033 from adamcik/feature/scanner-with-typefind 
Add typefinding / MIME guess to scan code.
 2015-03-13 23:22:12 +01:00
Stein Magnus Jodal
b29f9e10c4 core: get_mute() with no mixer returns None 
...and not False, because the mute state is unknown (None) and not
unmuted (False) when there is no mixer.

Note that this change does not affect the MPD responses.
 2015-03-13 21:19:56 +01:00
Thomas Adamcik
083ec130f9 Merge pull request #1015 from ZenithDK/feature/mixer_none 
core/mpd: Allow empty or 'none' as audio.mixer value
 2015-03-13 17:57:51 +01:00
Thomas Adamcik
cee73b5501 audio: Add support for checking seekable state in scanner 
Return type of scanner changed to a named tuple with (uri, tags, duration,
seekable). This should help with #872 and the related "live" issues.

Tests, local scan and stream metadata lookup have been updated to account for
the changes.
 2015-03-12 22:11:50 +01:00
Thomas Kemmer
e655d39384 Fix #1031: Add get_images() to local library. 2015-03-12 11:43:27 +01:00
Thomas Adamcik
6fcd43891e core: Switch to reference based stream info. 
- Adds tests for new behaviors in core.
- Adds stream name to MPD format (fixes #944)
- Adds 'stream_changed' core event (needs a new name/event)
- Adds 'get_stream_reference' (which I'm also unsure about)

The bits I'm unsure about are mostly with respect to #270, but I'm going ahead
with this commit so we can discuss the details in PR with this code as an
example.
 2015-03-10 21:55:51 +01:00
Lasse Bigum
cb19b2c48c Allow 'none' as audio.mixer value 
To disable mixing altogether, you can now set the configuration value
 audio/mixer to 'none'.
 2015-03-10 00:26:22 +01:00
Thomas Adamcik
e639b2b18b tests: Add method for emitting fake tags changed in tests 2015-03-09 21:55:23 +01:00
Thomas Adamcik
29b00cabf9 Merge pull request #1028 from tkem/fix/1026 
Fix #1026: Sort local playlists by name.
 2015-03-08 23:53:04 +01:00
Lasse Bigum
cf0b666a0a Add tests for PlaybackController get_current_(tl_)track 
Add some more test cases for PlaybackController
 2015-03-08 04:10:02 +01:00
Thomas Kemmer
94c418d5e6 Fix #1026: Sort local playlists by name. 2015-03-07 22:42:22 +01:00
Thomas Kemmer
9150c34053 Fix #1023: Remove support for local album images from coverartarchive.org 2015-03-06 10:02:08 +01:00
Stein Magnus Jodal
2280a533c0 Use py.test as test runner 2015-03-05 00:35:20 +01:00
Thomas Adamcik
319c1fc1e3 local: Readd support for search without limit for get_distinct support 2015-03-02 23:39:06 +01:00
Thomas Adamcik
7c2c4c1c45 Merge branch 'fix/local-json-limit-offset' of https://github.com/ali/mopidy into develop 2015-03-02 23:18:39 +01:00
Thomas Adamcik
8cc9c9bbc0 core: Rename list_distinct to get_distinct 2015-03-02 22:41:09 +01:00
Thomas Adamcik
5fd2afa7ca mpd: Switch list command to using list_distinct 2015-03-02 00:26:51 +01:00
Stein Magnus Jodal
0634de6e28 Merge pull request #1020 from adamcik/feature/fix-ws-disconnect-race 
Fix WS disconnect race
 2015-03-02 00:16:09 +01:00
Thomas Adamcik
0fb6c620df docs: Add changelog entry for broadcast race 2015-03-02 00:05:58 +01:00
Thomas Adamcik
4ee7dd73bd http: Make WS broadcast more robust against disconnect race 
Adds some WebSocketHandler tests that actually connect using a WS client and
plugs a potential race condition.

Any call to write_message could fail, either due to WebSocketClosedError like
in the log below, or simply due to socket errors. To play it safe we catch all
errors and debug log that a broadcast failed.

2015-02-26 21:24:02,266 ERROR    [HttpServer] /home/adamcik/dev/mopidy/mopidy/http/handlers.py:116
  mopidy.http.handlers WebSocket request error: deque index out of range
2015-02-26 21:24:10,098 ERROR    [HttpFrontend-11] build/bdist.linux-x86_64/egg/pykka/actor.py:268
  pykka Unhandled exception in HttpFrontend (urn:uuid:e376bd95-c32e-4e17-ad20-7d0b3c0cf2b2):
Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/pykka/actor.py", line 200, in _actor_loop
    response = self._handle_receive(message)
  File "build/bdist.linux-x86_64/egg/pykka/actor.py", line 294, in _handle_receive
    return callee(*message['args'], **message['kwargs'])
  File ".../dev/mopidy/mopidy/http/actor.py", line 77, in on_event
    on_event(name, **data)
  File ".../dev/mopidy/mopidy/http/actor.py", line 84, in on_event
    handlers.WebSocketHandler.broadcast(message)
  File ".../dev/mopidy/mopidy/http/handlers.py", line 78, in broadcast
    client.write_message(msg)
  File ".../dev/mopidy-virtualenv/local/lib/python2.7/site-packages/tornado/websocket.py", line 183, in write_message
    raise WebSocketClosedError()
WebSocketClosedError
 2015-03-02 00:05:21 +01:00
Lasse Bigum
fbd534efbf Don't change to playing state when seeking in paused state 
Do not switch state from paused to playing when seeking
 2015-03-01 15:50:17 +01:00
Thomas Adamcik
47911f24ea Merge pull request #1013 from tkem/fix/get_images 
backend: Improve default get_images() implementation with album/artist URIs.
 2015-02-28 12:35:16 +01:00
Thomas Kemmer
301f732047 Improve default get_images() implementation with album/artist URIs. 2015-02-27 22:22:28 +01:00
Stein Magnus Jodal
5536c79be5 Merge pull request #1005 from adamcik/fix/808 
Add per logger colors
 2015-02-25 23:18:08 +01:00
Thomas Adamcik
b11d89d72f config: Convert the loglevel schema to a generic map schema 2015-02-25 21:36:59 +01:00
Thomas Adamcik
0829f34a90 Merge pull request #999 from tkem/fix/998 
Fix #998: Remove event already sent by PlaylistsController.
 2015-02-25 21:05:53 +01:00
Thomas Kemmer
dd54fdb086 Fix #937: Local playlists refactoring. 2015-02-25 18:50:29 +01:00
Thomas Kemmer
96a3cb6ef5 Remove obsolete unit test. 2015-02-25 17:48:41 +01:00
Stein Magnus Jodal
255d92f21f Merge pull request #992 from adamcik/feature/default-get-images-fallback 
backend: Add a default get_images impl.
 2015-02-18 22:13:10 +01:00
Thomas Adamcik
2ff2a3719e backend: Add test for get_images fallback 2015-02-18 21:55:39 +01:00
Thomas Adamcik
e4ba4b3e5f mpd: Support blacklisting MPD commands in the server. 
Default blacklist set to listall and listallinfo.

This change has been done to avoid clients being able to call "bad" MPD
commands which are often misused to try and keep a client db. Note that
this change will break some MPD clients, but the blacklist can be controlled
via config to allow opting out for now.
 2015-02-18 00:13:24 +01:00
Ali Ukani
ead147f482 Fix flake8 errors, prepare for Python 3 port 
Fixes flake8 warnings
Reword docstring for find_exact
Use range instead of xrange in preparation for porting to Python 3
 2015-02-16 02:24:40 -05:00
Ali Ukani
fc21d466f0 local: use limit and offset when searching json library 
Fixes the json local library's search behavior. Uses limit and offset
arguments when returning search results.
 2015-02-16 02:24:40 -05:00
Stein Magnus Jodal
5270aa65e2 audio: Move DummyAudio into tests package 2015-02-13 10:40:21 +01:00
Stein Magnus Jodal
b554a64aad mixer: Move DummyMixer into tests package 2015-02-13 01:37:07 +01:00
Stein Magnus Jodal
df95a988b7 backend: Move DummyBackend into tests package 2015-02-13 01:37:07 +01:00
Stein Magnus Jodal
160afbcd26 mpd: Use DummyMixer in tests 2015-02-13 01:22:46 +01:00
Stein Magnus Jodal
886c2b92d8 core: Use a mixer mock in tests 2015-02-13 01:15:25 +01:00
Stein Magnus Jodal
333bc69777 jsonrpc: Don't use mixer in tests 2015-02-13 01:15:15 +01:00
Stein Magnus Jodal
7aede98fda Merge pull request #982 from adamcik/feature/use-proxy-in-stream-scanner 
Use proxy in stream scanner
 2015-02-13 01:04:09 +01:00
Thomas Adamcik
0e4e872d6b stream: Hook stream scanner up to proxy settings 2015-02-13 00:52:20 +01:00
Stein Magnus Jodal
638740541b Merge pull request #981 from adamcik/feature/core-get-images 
Add library.get_images()
 2015-02-13 00:33:29 +01:00
Thomas Adamcik
ddd872cdea core: Always return an answer for all URIs in get_images 
Also make sure that results are tuples instead of lists so we don't
accidentally give out mutable state.
 2015-02-13 00:10:14 +01:00
Thomas Adamcik
3cb9eb52f0 Merge pull request #975 from jodal/feature/core-mixer 
Add core.mixer replacing playback mixer methods.
 2015-02-12 23:50:04 +01:00
Thomas Adamcik
533948f8f8 core: Make sure we return list of images in get_images tests 2015-02-12 23:10:20 +01:00
Thomas Adamcik
b1b6fb7808 tests: Re-add incorrectly removed test case 2015-02-12 23:08:27 +01:00
Thomas Adamcik
c0b0e3657a core: Add core.library.get_images 2015-02-12 22:38:42 +01:00
Stein Magnus Jodal
e938fb0a7f Merge pull request #965 from ZenithDK/fix/flake-lambda 
flake8: fix PEP8 warnings about lambda
 2015-02-12 22:22:53 +01:00
Lasse Bigum
34ada2784a flake8: fix PEP8 warnings about lambda 
Fix the 'lambda to def' warnings
 2015-02-12 22:10:36 +01:00
Thomas Adamcik
05b66ba4a3 models: Add basic image model 2015-02-12 22:02:59 +01:00
Stein Magnus Jodal
df67d708db config: Add support for 'all' loglevel 
Equal to logging.NOTSET or 0 in the logging module.
 2015-02-12 18:12:33 +01:00
Stein Magnus Jodal
e1fa76a48e mpd: Use core.mixer for volume/mute 2015-02-12 10:31:16 +01:00
Stein Magnus Jodal
91bcdddf56 tests: Use core.mixer for volume/mute 2015-02-12 10:31:16 +01:00
Stein Magnus Jodal
42115c56f7 core: Add mixer controller (fixes: #962) 
Deprecate volume and mute methods on playback controller.
 2015-02-12 10:31:16 +01:00
kingosticks
0de13994c2 Moved MPDUriMapper to own file and updated changelog 2015-02-09 12:07:17 +00:00
kingosticks
317d02de3e Pass MPDUrimapper into mpd test setup 2015-02-08 23:43:22 +00:00
Lasse Bigum
4bf7a568d1 Check that config is readable 
Implement a check on file permissions for the config files that are loaded
and print debug if mopidy fails to load it due to missing file file permissions
 2015-02-07 17:47:20 +01:00
Stein Magnus Jodal
a693993905 flake8: Fix new warnings after flake8 upgrade 2015-02-07 17:11:36 +01:00
Thomas Adamcik
41d48dc0ec audio: Stop mocking in audio event tests 2015-01-24 00:49:02 +01:00
Thomas Adamcik
b0aebaf993 core: Make sure current_tl_track changes on stream change 
- Adds stream changed handler to core
- Moves playback started trigger to stream changed
- Made about to finish store next track in _pending_tl_track
- Set the pending track as current in stream changed
- Adds tests for all of this and fixes existing tests
 2015-01-23 00:14:30 +01:00
Thomas Adamcik
49f16704d8 core: Remove on_end_of_track from playback 
This has been replaced by on_about_to_finish and on_end_of_stream.
Tests have been updated to reflect these changes.
 2015-01-22 23:16:51 +01:00
Thomas Adamcik
82bf1c0eb9 core: Move core.playback.on_end_of_track off change_track helper 
Only handles the playing case, unlike the previous and next changes. It should
also be noted that this is just a temporary state on the road to making this
method handle gapless.
 2015-01-21 23:15:42 +01:00
Thomas Adamcik
4a39671ee7 core: Move core.playback.previous off change_track helper 
Same fix as for core.playback.next and mostly the same caveats.
 2015-01-21 23:07:47 +01:00
Thomas Adamcik
bbb3301a98 core: Move core.playback.next off change_track helper 
Note that since this doesn't use play via change_track we have to copy over the
tracking code and make sure it is only run for the playing case
 2015-01-21 23:02:06 +01:00
Thomas Adamcik
9fc319055c backend: Change playback API (breaking change) 
While trying to remove traces of stop calls in core to get gapless working I
found we had no way to switch to switch tracks without triggering a play. This
change fixes this by changing the backends playback provider API.

- play() now _only_ starts playback and does not take any arguments.
- prepare_change() has been added, this could have been avoided with a kwarg to
  change_track(track), but that would break more backends.
- core has been updated to call prepare_change+change_track+play as needed.
- tests have been updated to handle this change.

Longer term I hope to completely rework the playback API in backends, as 99% of
our backends only use change_track(track) to translate URIs. So we should make
simple case simple, and handle mopidy-spotify / appsrc in some other way.
 2015-01-21 22:13:41 +01:00
Ali Ukani
dac5f9e406 Add test for exact search with album query 2015-01-05 23:24:52 -05:00
kingosticks
1e7a4247c6 Add non-ascii utf-8 chars to test playlists 2015-01-04 20:21:10 +00:00
Thomas Adamcik
ab49d75a45 tests: Fix outstanding flake8 errors in tests 2014-12-30 00:23:08 +01:00
Thomas Adamcik
627b856578 tests: Fix MPD tests helper names 2014-12-30 00:23:08 +01:00
Thomas Adamcik
fa8547c397 tests: Add noqa markers for setUp/tearDown 2014-12-30 00:23:01 +01:00
Thomas Adamcik
a50ba6e3a7 tests: Add noqa markers to custom assert helpers 2014-12-29 23:58:36 +01:00
Thomas Adamcik
9f6e0cc5fa tests: Fix versions test pep8 naming errors 2014-12-29 23:48:59 +01:00
Thomas Adamcik
656f7e976f Merge branch 'develop' into feature/taglist-converter 
Conflicts:
	docs/changelog.rst
 2014-12-25 22:46:44 +01:00
Stein Magnus Jodal
890ed53ee6 Merge branch 'release/v0.19.x' into develop 
Conflicts:
	docs/changelog.rst
 2014-12-24 00:41:10 +01:00
Stein Magnus Jodal
6af624a369 Bump version to 0.19.5 2014-12-24 00:37:33 +01:00
Stein Magnus Jodal
dbbb86e6c0 Merge branch 'release/v0.19.x' into develop 
Conflicts:
	mopidy/core/playback.py
 2014-12-24 00:24:19 +01:00
Stein Magnus Jodal
c6ff9eee86 playback: Remove skipped track on next in consume mode 
Also adds core level tests of consume behavior on next/prev/eot.

Fixes #902
 2014-12-24 00:04:41 +01:00
Stein Magnus Jodal
6ec35b2d02 Merge branch 'release/v0.19.x' into develop 2014-12-23 22:23:32 +01:00
Stein Magnus Jodal
aa3b8ab5f8 path: Support unicode content when creating file 2014-12-23 22:21:10 +01:00
Thomas Adamcik
935a038405 audio: Only add albums that have a name 
Fixes case where we could have an empty album. We could alternatively be more
conservative and only limit to fully empty albums. But I think we only want
ones with names anyway.
 2014-12-22 22:45:31 +01:00
Thomas Adamcik
819680e074 audio: Move utils test to tests folder 2014-12-22 22:34:11 +01:00
Thomas Adamcik
9b9cdc3ade stream: Fix track conversion bug and add tests 
This adds basic checks for the library provider lookup:

- Check that uri schemes are respected
- Check that blacklisting and globbing works
- Check uri successfully gets converted to a track
 2014-12-22 22:29:36 +01:00
Thomas Adamcik
9be788b129 audio: Move tags to track conversion to audio utils 2014-12-18 23:36:56 +01:00
Thomas Adamcik
983148a9a4 audio: Start storing the tags we find in audio 
Adds a new get_currents_tags method for fetching the full set of current tags.
There are still some untested cases for this, and I also suspect we still want
some API refinements one core starts using this.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
6c62252919 audio: Add tags changed event to audio. 
Current version simply emits the keys of the changed tags to the audio
listener. Following change will add support for storing the actual data.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
de6bd63481 audio: Remove min duration code from scanner. 
The local scanner now handles this itself by looking at the duration.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
4f8244c499 audio: Convert audio_data_to_track to tags_to_track 
The new function only uses tags as input. In other words we now need to set
length, uri and mtime ourselves. Users of scan APIs have been updated.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
4948dee4b9 audio: Make scanner return duration in milliseconds 
Also ensures that we normalize unknown duration to None instead of -1.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
d9d501cd98 audio: Update scanner to just return tags+duration 
The caller should know what URI we are talking about. Additionally finding the
mtime is never belonged in this class and has been moved out.
 2014-12-18 23:28:19 +01:00
Thomas Adamcik
dcaa0f6732 local: Move musicbrainz cover art helper to translator 2014-12-18 23:28:14 +01:00
Thomas Adamcik
b365d2494b mpd: Remove "Comment" tag type from translator output. 
Newer versions of the protocol have removed this tag, so we should as well.
This also works around the issue of #881 which was breaking things with
newlines in comment fields.

The readcomments command seems to replace this, but it seems to only care about
specific extra tagtypes, not the general comment tag we normally collect when
scanning things.

(cherry picked from commit 08a8d5c43b)
 2014-12-16 23:30:38 +01:00
Stein Magnus Jodal
6e55435aa9 mpd: Enable browsing of empty dirs 
This was disabled together with a bunch of other changes without any
explanation in commit f24ca36e5a. I'm
guessing that this wasn't intentional, and no test covered the case.

(cherry picked from commit 4e508cd017)
 2014-12-16 23:25:31 +01:00
Thomas Adamcik
90fdd46109 local: Cleanup translator tests 2014-12-14 23:14:11 +01:00
Thomas Adamcik
671ee5ee6a audio: Switch to using converted taglists instead of raw data. 2014-12-14 22:25:52 +01:00
Thomas Adamcik
08a8d5c43b mpd: Remove "Comment" tag type from translator output. 
Newer versions of the protocol have removed this tag, so we should as well.
This also works around the issue of #881 which was breaking things with
newlines in comment fields.

The readcomments command seems to replace this, but it seems to only care about
specific extra tagtypes, not the general comment tag we normally collect when
scanning things.
 2014-12-14 14:16:37 +01:00
Thomas Adamcik
2c3217685b utils: Switch to exceptions.FindError for errors. 2014-12-14 14:08:45 +01:00
Stein Magnus Jodal
4e508cd017 mpd: Enable browsing of empty dirs 
This was disabled together with a bunch of other changes without any
explanation in commit f24ca36e5a. I'm
guessing that this wasn't intentional, and no test covered the case.
 2014-12-13 01:27:14 +01:00
Stein Magnus Jodal
4f428b8601 py3: Move compat module out of utils 2014-12-07 21:36:15 +01:00
Stein Magnus Jodal
7a1bb224f7 py3: Avoid indexing exception objects 
It doesn't work on Python 3.
 2014-12-07 20:26:09 +01:00
Stein Magnus Jodal
58527406c1 py3: Use compat.text_type instead of unicode 2014-12-07 20:17:10 +01:00
Stein Magnus Jodal
496142c201 py3: Use absolute imports by default 2014-12-07 20:17:10 +01:00
Stein Magnus Jodal
680dbffc0c models: Make all fields default to None or empty collection 
(cherry picked from commit abed15b9e4)
 2014-11-04 21:27:29 +01:00
Stein Magnus Jodal
a4b17a9aa8 models: Fix equality for fields set to the default 
Fixes #837

(cherry picked from commit bdd1fb983b)
 2014-11-04 20:17:20 +01:00
Stein Magnus Jodal
88d64044de models: Hide empty lists from repr() 
(cherry picked from commit 305a76486d)

Conflicts:
	docs/changelog.rst
 2014-11-04 20:17:13 +01:00
Thomas Kemmer
63277c4db3 Add unit tests for artist browsing 2014-11-04 19:22:45 +01:00
Thomas Adamcik
063c757570 utils/path: Add support for handling sym/hardlink loops 2014-10-15 23:46:08 +02:00
Thomas Adamcik
54a89038d3 utils/path: Don't skip hidden files and folders in generic find code 
Updates the local scan code to do this instead.
 2014-10-15 23:45:49 +02:00
Thomas Adamcik
9b1d20677d tests: Cleanup find tests to use tempfile all over. 
This should make it more clear what structure we expect.
 2014-10-15 23:45:27 +02:00
Thomas Adamcik
69fa6f4674 tests: Test symlink that points to it's own parent. 2014-10-15 23:45:22 +02:00
Thomas Adamcik
93c0d6cc44 tests: Update no permission test to use tempfile. 2014-10-15 23:45:12 +02:00
Thomas Adamcik
b2419f9814 tests: Add test case for a symlink pointing at itself 2014-10-15 23:45:03 +02:00
Thomas Adamcik
ebb62885cd util/path: Add basic support for following symlinks 2014-10-15 23:44:48 +02:00
Thomas Adamcik
682af27348 tests: Add test case for file without permissions. 2014-10-15 23:44:41 +02:00
Thomas Adamcik
d219bab0b2 tests: Add test for directory without permission behaviour 2014-10-15 23:44:01 +02:00
Thomas Adamcik
de5fe5ebab tests: Add test for current find symlink handling 2014-10-15 23:43:13 +02:00
Thomas Adamcik
a8017dfef1 tests: Start adding checks for find errors 2014-10-15 23:42:36 +02:00
Thomas Adamcik
de4bdbec03 tests: Minor cleanup of the existing find tests 2014-10-15 23:42:15 +02:00
Thomas Adamcik
2447e2fa40 util/path: Expose errors to callers of find helper 2014-10-15 23:42:12 +02:00
Stein Magnus Jodal
7856c14b26 tests: Use with stmt for assertRaises 2014-09-25 23:03:35 +02:00
Stein Magnus Jodal
07d088fc18 models: Use with stmts in exception tests 2014-09-24 18:26:25 +02:00
Stein Magnus Jodal
5317834baf history: Change size property to get_length() method 
For consistency with tracklist.get_length() and our goal of aligning Python
and JS APIs by using less properties in the core API.
 2014-09-23 18:47:54 +02:00
Stein Magnus Jodal
5a67339855 history: Cleanup history entry test 2014-09-23 18:47:39 +02:00
Stein Magnus Jodal
d30cf68efd history: Raise TypeError if non-Tracks are added 2014-09-23 18:42:41 +02:00
Stein Magnus Jodal
718405421d history: Rename class to HistoryController 
For consistency with other core controllers.
 2014-09-23 18:32:37 +02:00
Arjun Naik
c38b9f378f Use assertIn instead of assertTrue to test membership. 2014-09-23 18:09:12 +02:00
Arjun Naik
9006968f75 TrackHistory stores Ref instances. Timestamp as epoch in milliseconds also stored. 2014-09-23 18:09:12 +02:00
Arjun Naik
ed87ab8dd1 Added a playback history object to the core. 2014-09-23 18:09:11 +02:00
Stein Magnus Jodal
1fcc75ba1e Merge pull request #840 from tkem/feature/local-library-lookup-multiple 
local: Return multiple tracks from lookup()
 2014-09-23 14:14:22 +02:00
Stein Magnus Jodal
abed15b9e4 models: Make all fields default to None or empty collection 2014-09-22 22:25:42 +02:00
Stein Magnus Jodal
bdd1fb983b models: Fix equality for fields set to the default 
Fixes #837
 2014-09-22 22:01:50 +02:00
Stein Magnus Jodal
305a76486d models: Hide empty lists from repr() 2014-09-22 21:42:57 +02:00
Stein Magnus Jodal
f58fe9a192 py3: Replace xrange() with range() 2014-09-17 20:28:07 +02:00
Thomas Adamcik
d049b07fa9 Merge branch 'develop' into feature/audio-message-handler 2014-09-07 21:38:19 +02:00
Thomas Kemmer
806174916d Change JsonLibrary.lookup to return a list 2014-09-05 05:35:18 +02:00
Stein Magnus Jodal
d41deb1844 Merge branch 'release/v0.19.x' into develop 
Conflicts:
	docs/changelog.rst
 2014-09-01 23:17:00 +02:00
Stein Magnus Jodal
e1ab70e1e9 Bump version to 0.19.4 2014-09-01 23:08:59 +02:00
Thomas Kemmer
f90671fe96 Fixed flake8: I201 Missing newline between sections or imports 2014-08-30 14:10:39 +02:00
Thomas Kemmer
380223bb96 local: Return multiple tracks from lookup() 2014-08-30 14:02:43 +02:00
Stein Magnus Jodal
c50641230d Merge branch 'release/v0.19.x' into develop 2014-08-29 14:03:11 +02:00
Stein Magnus Jodal
a244761abc mpd: Replace / with | instead of whitespace in playlist names 2014-08-17 23:25:09 +02:00
Trygve Aaberge
15597b3c60 tests: Test call order in test_recv_callback_gets_no_data 2014-08-14 12:43:42 +02:00
Trygve Aaberge
265951bf00 network: disable_recv before telling actor to close connection 
As of d62ad96, when the connection can't receive more data from the
client, it tells the actor to stop the connection and calls
disable_recv(). The actor operates in it's own thread and when it stops
the connection, disable_recv is being called again from a different
thread. Since the actor is told to stop the connection before
disable_recv is called, the two calls to disable_recv may happen
simultaneously.

This causes a race condition issue where both threads can reach past the
check that recv_id is not None before either of them set it to None. If
one of them set it to None before the other one tries to use it, an
error is raised.

This commit calls disable_recv before telling the actor to stop the
connection. Since disable_recv is a blocking call, this ensures that
recv_id is being set to None before the actor thread begins to stop the
connection.

Fixes #781
 2014-08-14 01:58:48 +02:00
Stein Magnus Jodal
ae3a932ed3 Merge branch 'release/v0.19.x' into develop 
Conflicts:
	mopidy/config/__init__.py
 2014-08-12 23:54:14 +02:00
Thomas Adamcik
ac5bf9af17 audio: Move most of event handling out of audio. 
Some of the signal handling still needs to be moved.
 2014-08-11 22:33:49 +02:00
Thomas Adamcik
101b2a9817 audio: Make stream-changed correctly handle tee setup 
For the purposes of this event we consider the outputs sink the final element.
If we don't do this we would get one event per branch, and we don't want to
track when each of them actually switches any way. So just tracking when the
tee/outputs bin gets the event is good enough for us.

As part of this I've also added 'testoutput' as a special cased output value.
This is now needed as outputs are always synced to the clock, making testing
a lot less practical.
 2014-08-11 22:33:49 +02:00
Trygve Aaberge
584484379a config: Only load .conf-files when loading directories 2014-08-11 16:21:34 +02:00
Trygve Aaberge
9e41eff187 config: Support passing directories to mopidy --config 2014-08-11 14:48:04 +02:00
Trygve Aaberge
c798257f00 mpd: Test that "list album foo" responds correctly 
Previously, test_list_album_with_artist_name would only test that the
command didn't fail. Now it also checks that the response is correct.
That is, that the response contains albums.

This makes the test detect the error reported in #817.

(cherry picked from commit 9771eda230)
 2014-08-05 23:52:40 +02:00
Trygve Aaberge
9771eda230 mpd: Test that "list album foo" responds correctly 
Previously, test_list_album_with_artist_name would only test that the
command didn't fail. Now it also checks that the response is correct.
That is, that the response contains albums.

This makes the test detect the error reported in #817.
 2014-08-05 18:34:08 +02:00
Thomas Adamcik
d650c0ba14 audio: Split out ouput handling from audio actor 
This also lays some basic ground work for handling multiple outputs.
 2014-08-03 23:57:22 +02:00
Stein Magnus Jodal
e9822117e5 Merge branch 'master' into develop 
Conflicts:
	docs/changelog.rst
 2014-08-03 23:40:18 +02:00
Stein Magnus Jodal
dc80f17296 Bump version to 0.19.3 2014-08-03 23:34:25 +02:00
Stein Magnus Jodal
9260ae23a7 Merge branch 'release/v0.19.x' into develop 2014-08-03 23:13:40 +02:00
Stein Magnus Jodal
837fb00fb7 Fail early if extension doesn't implement setup() 
Fixes #813
 2014-08-03 23:13:14 +02:00
Thomas Adamcik
5d1dd1a355 review-fixes: Mostly typos etc. 2014-08-02 20:45:55 +02:00
Thomas Adamcik
bf752859da flake8: Fix duplicate import and import order in audio actor test 2014-07-29 23:12:53 +02:00
Thomas Adamcik
e73159dc6c Merge branch 'develop' into feature/audio-prep-work-for-gapless 2014-07-29 23:07:08 +02:00
Ignasi Fosch
e9289ca554 Checks for musicbrainz album ID and sets images to a list containing the corresponding URL 2014-07-27 16:34:28 +02:00
Stein Magnus Jodal
3bc82f82ac Bump version to 0.19.2 2014-07-26 14:18:50 +02:00
Stein Magnus Jodal
93bf3ea918 mpd: Fix crash on wrong number of command args 
Fixes #789
 2014-07-26 13:56:26 +02:00
Ignasi Fosch
9d493792bf version help test fixed 2014-07-26 12:31:53 +02:00
Stein Magnus Jodal
19dae10575 Bump version to 0.19.1 2014-07-23 18:14:00 +02:00
Thomas Adamcik
2aeb87e003 Merge branch 'develop' into feature/audio-prep-work-for-gapless 
Conflict files fixed up to a state where tests pass again before commit.

Conflicts:
	mopidy/audio/actor.py
	mopidy/audio/listener.py
	tests/audio/test_actor.py
	tests/audio/test_listener.py
 2014-07-23 00:06:29 +02:00
Stein Magnus Jodal
0bf7302005 Merge remote-tracking branch 'adamcik/fix/gh-734-cleanup-audio-buffering' into develop 
Conflicts:
	mopidy/audio/actor.py
 2014-07-20 12:29:49 +02:00
Stein Magnus Jodal
1ebe1151fc http: Make event emitting testable 2014-07-17 01:14:06 +02:00
Stein Magnus Jodal
3fac0cb8de http: Split socket and server creation 2014-07-17 01:13:48 +02:00
Stein Magnus Jodal
7e6d3de81a Merge branch 'develop' into feature/mixers 
Conflicts:
	mopidy/backend/__init__.py
 2014-07-16 22:12:07 +02:00
Stein Magnus Jodal
44664f2796 exc: Add {Backend,Frontend,Mixer}Error exceptions 
(cherry picked from commit bf8307f329)
 2014-07-16 10:32:18 +02:00
Stein Magnus Jodal
7e489ccb0b exc: Test ScannerError 
(cherry picked from commit 8f59dd69ad)
 2014-07-16 10:32:15 +02:00
Stein Magnus Jodal
dda06dd8de config: Add optional support to Boolean type 2014-07-15 00:33:30 +02:00
Thomas Adamcik
d8c41de2f7 audio: Add tests for state changes while buffering 2014-07-14 23:15:40 +02:00
Stein Magnus Jodal
d15d66f070 Use 'mute' instead of 'muted', to avoid changing old APIs 2014-07-12 03:14:19 +02:00
Stein Magnus Jodal
249114b051 audio: Update tests broken by 5f091c10 2014-07-12 03:12:21 +02:00
Stein Magnus Jodal
a3dc763b29 core: Forward {volume,mute}_changed events, don't trigger them ourselves 2014-07-10 01:15:44 +02:00
Stein Magnus Jodal
b8de7fa75c mixer: Add MixerListener 2014-07-10 01:00:35 +02:00
Stein Magnus Jodal
bf8307f329 exc: Add {Backend,Frontend,Mixer}Error exceptions 2014-07-09 22:17:46 +02:00
Stein Magnus Jodal
8f59dd69ad exc: Test ScannerError 2014-07-09 22:15:45 +02:00
Stein Magnus Jodal
9da716935c audio: Only expose GStreamer's software mixer 2014-07-08 01:34:33 +02:00
Stein Magnus Jodal
6d6bc4b808 core: Use new mixer API 2014-07-08 01:11:25 +02:00
Stein Magnus Jodal
9ced0f740f Merge 'dz0ny/bug/fix-708-duplicate' into develop 2014-07-01 23:25:49 +02:00
dz0ny
d871ca9128 Remove duplicates from library root. 
Closes #708
 2014-06-26 16:27:22 +02:00
Trygve Aaberge
c062dd21c4 mpd: Create unique names for all items in browse 
Replace the playlist uri/name mapping with a mapping for all the items
in browse. Check the mapping when browsing a path.

This has the added benefit of serving as a cache for browse, so we don't
need to traverse the path parts and lookup each of them for each call to
browse.
 2014-06-24 00:45:49 +02:00
Thomas Adamcik
e4d4652c68 Merge pull request #759 from jodal/feature/web-client-selector 
Add web client selector
 2014-06-23 22:47:14 +02:00
Stein Magnus Jodal
25f41664d7 Bump version number to 0.19 2014-06-23 22:32:43 +02:00
Stein Magnus Jodal
aed8670797 http: Fix flake8 warnings 2014-06-22 09:53:03 +02:00
Stein Magnus Jodal
9b9791ab5b Merge pull request #755 from trygveaa/feature/lsinfo-change-order 
mpd: List browse results before playlists in lsinfo
 2014-06-22 09:49:00 +02:00
Trygve Aaberge
1ac470c58c mpd: Test that whitespace query parts are ignored 2014-06-22 02:13:14 +02:00
Stein Magnus Jodal
9f925570d2 http: Redirect from root to /mopidy/ if no static_dir app 2014-06-22 01:24:57 +02:00
Stein Magnus Jodal
6596871918 http: Test serving og legacy static_dir apps 2014-06-22 01:22:22 +02:00
Stein Magnus Jodal
5861071bb1 http: List installed web clients at /mopidy/ 2014-06-22 00:39:54 +02:00
Stein Magnus Jodal
59760bb36c web: Remove WebSocket demo page 2014-06-21 23:27:35 +02:00
Trygve Aaberge
0c3e5bd71e mpd: Test that empty query parts are ignored 2014-06-21 17:29:41 +02:00
Thomas Adamcik
7975815cde audio: Expand audio state changed with target state 2014-06-21 17:28:25 +02:00
Stein Magnus Jodal
fbcc73004d http: Redirect from /app to /app/ 2014-06-21 16:36:16 +02:00
Stein Magnus Jodal
6c6600c37b http: Group HTTP server tests 2014-06-21 16:21:39 +02:00
dz0ny
7c428ce8d2 Fix http router so it can handle /{ext_name} same as /{ext_name}/ 2014-06-21 15:05:13 +02:00
Trygve Aaberge
81898cb709 mpd: Test order of result from lsinfo 2014-06-21 14:42:35 +02:00
Thomas Adamcik
2e1ca08fef audio: Use on buffering internal in buferring tests 2014-06-21 14:20:56 +02:00
Thomas Adamcik
58976ef52d config: Lists need to handle missing values 2014-06-21 14:11:24 +02:00
Trygve Aaberge
0b7243dce1 mpd: Test albums in listall(info) 2014-06-21 01:52:44 +02:00
Stein Magnus Jodal
4cd545e147 Merge branch 'trygveaa/feature/mpd-browse-playlists' into develop 2014-06-20 22:19:48 +02:00
Trygve Aaberge
496b3f5552 mpd: Test playlists in listall(info) 2014-06-20 22:16:27 +02:00
Thomas Adamcik
c87684aa6b audio: Handle all caps ASX tags. 
Also add support for simple asx format.
 2014-06-20 21:31:03 +02:00
Stein Magnus Jodal
720a403439 http: Remove unused Router class 2014-06-04 21:32:54 +02:00
Stein Magnus Jodal
33228f2528 http: Simplify app registration 2014-06-04 21:32:19 +02:00
Stein Magnus Jodal
b6ab29eed4 http: Remove unused code 2014-06-04 21:02:33 +02:00
Stein Magnus Jodal
d13194dfa4 http: Remove static file serving from the Router 2014-06-04 20:55:28 +02:00
Stein Magnus Jodal
eea6138b3d http: Simplify static files serving 2014-06-04 20:47:49 +02:00
Stein Magnus Jodal
684a64405d http: Move MopidyHttpRouter into handlers module 2014-05-22 21:03:42 +02:00
Stein Magnus Jodal
1223103e8f http: Test that routers can mount WSGI apps 2014-05-21 00:38:38 +02:00
Stein Magnus Jodal
fe9a126a2a http: Enforce router's URL namespace 2014-05-20 23:53:26 +02:00
Stein Magnus Jodal
4b383c1762 http: Move Mopidy request handlers to a MopidyHttpRouter 2014-05-20 23:49:22 +02:00
Stein Magnus Jodal
5d1f8f2203 http: Give routers access to the core API 2014-05-20 23:30:49 +02:00
Stein Magnus Jodal
5897675eab http: Split tests into three files 2014-05-20 23:07:28 +02:00
Stein Magnus Jodal
e9ff16fe63 http: Simplify test imports 2014-05-20 22:55:37 +02:00
Stein Magnus Jodal
6d04aaf3e4 http: More consistent use of 'request handler' 2014-05-20 22:50:45 +02:00
Stein Magnus Jodal
ea5a317b00 http: Avoid tornado import before extension is loaded, group all handlers 2014-05-20 22:36:15 +02:00
Stein Magnus Jodal
1a72f68707 http: Import modules, not attributes 2014-05-20 22:32:45 +02:00
Stein Magnus Jodal
1838f10dcf http: Rename 'setup_routes()' to 'get_request_handlers()' 2014-05-20 22:28:18 +02:00
Stein Magnus Jodal
e8291d471e http: Rename 'linkify()' to 'get_root_url()' 2014-05-20 22:16:01 +02:00
Stein Magnus Jodal
cad0207ef8 http: Rename 'path' to 'static_file_path' 2014-05-20 22:12:06 +02:00
dz0ny
031c7c8e93 Add: Tornado as required dependency 
Fix: Remove draft76
Fix: Remove class attributes for ws handler
Revert: default to /ws/ for for mopidy.html
 2014-05-12 16:16:08 +02:00
dz0ny
73721c77ad Fix: Fields order doesn't matter for json. Test for valid dict and data only 2014-05-12 15:14:42 +02:00
dz0ny
26833b4093 Fix: Import order for whole PR 2014-05-12 14:54:50 +02:00
dz0ny
f1d1a4713b Squashed commit of the following: 
commit dbb7005aa866cdc337bde9c8169e9bf15e5c8042
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 11 22:12:58 2014 +0200

    Fix: Make PR mergable

commit 5bb27da72c4276a930bf33955e6583f6781d23f6
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 23:31:54 2014 +0200

    Add: helper method for extensin url

commit 8a348b26b65102084a606ff73384a478bb785cf1
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 00:35:50 2014 +0200

    Add: Refactor ws and rpc to handlers, reuse code

commit 677c809d2b39a6c982ab835368fdb8a3ad9d1a92
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Thu May 8 00:18:10 2014 +0200

    Fix: Return proper HTTP headers

commit fe5fea2fc2a0d28a39532d6d4cd2b21013d57d24
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Wed May 7 23:48:19 2014 +0200

    Add: RPC post handler
    Add: tests for http post handler

commit e77e60310853b368758b09b303a96a95ff1b9b93
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 22:15:04 2014 +0200

    Add: Documentation on how to extend http api

commit a3a14fb5d15f095e5bab23a590e0a8360a039f9a
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 19:48:34 2014 +0200

    Add: HTTP tests for default router and static handler

commit 0d9544256bcb8f048eaedb5cdd57b1de027d387b
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:44:32 2014 +0200

    Fix: Move StaticFileHandler to main http package

commit c83c9f661e658e4a843dc5c8c6ba5dc3f1ea9c1e
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:29:49 2014 +0200

    Add: default Router implementation

commit 258cb7210bdf13833884c04cfb7fb4fa704394a7
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sun May 4 15:00:46 2014 +0200

    Add: Switch to registry for router registration

commit b7bfe7b814235b030d7ac30de90e2331e3d809d3
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 21:52:58 2014 +0200

    Fix: Private methods
    Fix: Point to mopidy.html instead main.html
    Fix: Less noise in console

commit 232abe3029e93f78ce25db0c1bd44743cc23ed2d
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 21:32:07 2014 +0200

    Fix: Start IOLoop in separate thread, so actor can stop it

commit d686892c2fa993cbedc99c8e8e7f9c961ac6f35a
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 19:30:49 2014 +0200

    Fix: Router load order
    Fix: JS helper library WSS default url
    Add: Handlers from extensions

commit a1b0f5673a6719f229df27feccb284324675e9d1
Author: dz0ny <dz0ny@ubuntu.si>
Date:   Sat May 3 14:53:30 2014 +0200

    Add: Switch to Tornado framework
 2014-05-12 14:54:50 +02:00
Stein Magnus Jodal
95c06f40db audio: Fix test setup 2014-05-12 14:52:45 +02:00
Thomas Adamcik
e4e7b20f74 flake: Fix stupid flake error caused by newly added check 2014-05-08 22:57:02 +02:00
Thomas Adamcik
56b9724ffc Merge pull request #715 from geigerzaehler/gst-buffer 
Pause gstreamer when buffering
 2014-05-08 22:07:13 +02:00
Stein Magnus Jodal
b754885064 Fix all import order warnings 2014-05-07 20:08:43 +02:00
Stein Magnus Jodal
2979de0f94 http: Polish Mopidy-HTTP Zeroconf service 
Builds upon #725 to:

- Remove extra config for Mopidy-HTTP Zeroconf service
- Refactor Zeroconf setup code in the HTTP frontend a bit
- Add documentation
 2014-05-06 23:20:14 +02:00
Stein Magnus Jodal
1b5c21452f Merge wlcx/feature/zeroconf-announce-mopidy into develop 2014-05-06 23:16:26 +02:00
Sam Willcocks
05089fba3b Update tests to add zeroconf-websocket config option 2014-04-27 17:50:41 +01:00
Trygve Aaberge
d62ad966af network: Respond to messages before closing connections 
This makes a connection tell the actor to stop the connection, instead
of stopping it itself. This is preferable, because other messages sent
to the actor that is not processed yet, may now send data to the client.

E.g. it makes this work:
$ echo status | nc localhost 6600
 2014-04-25 06:11:01 +02:00
Thomas Scholtes
2b7ff237b8 Add tests for Audio buffering 2014-04-03 21:43:56 +02:00
Stein Magnus Jodal
5583ca5aba New flake8 version with new checks to conform to 2014-03-29 20:47:42 +01:00
Stein Magnus Jodal
957036c899 Merge pull request #707 into develop 
Improve scan performance for remote filesystems
 2014-03-02 08:34:54 +01:00
Stein Magnus Jodal
061ff00a39 tests: Don't depend on the order of random sequences 2014-02-28 01:17:53 +01:00
Thomas Adamcik
7386dd30b6 utils: Remove old find_files 2014-02-26 23:53:12 +01:00
Thomas Adamcik
5b7a6065e7 util: Add find_mtimes helper 2014-02-26 23:27:44 +01:00
Stein Magnus Jodal
30dde4e593 ext: Remove old extension API 
As far as I know, all extensions except Mopidy-Arcam (not currently
maintained) and Mopidy-VKontakte already use the new API. Both of the
remaining extensions got open pull requests with the needed changes to use the
new API.
 2014-02-17 11:44:57 +01:00
Thomas Adamcik
79ce2ab902 Merge branch 'develop' into feature/mpd-tokenized-requests 
Conflicts:
	docs/changelog.rst
 2014-02-16 23:22:07 +01:00
Thomas Adamcik
8756c2bff5 review: Type fixing 2014-02-16 23:17:46 +01:00
Stein Magnus Jodal
4df730742d Release v0.18.3 2014-02-16 21:46:21 +01:00
Stein Magnus Jodal
fa15e7a264 Bump version number to 0.18.2 2014-02-16 21:24:57 +01:00
Thomas Adamcik
2e6f716b72 Merge branch 'develop' into feature/mpd-tokenized-requests 
Conflicts:
	mopidy/mpd/protocol/stored_playlists.py
 2014-01-30 22:48:28 +01:00
Thomas Adamcik
e4932c05b1 audio: Add more TODOs 2014-01-30 22:21:59 +01:00
Stein Magnus Jodal
38d3c6ccf9 models: Make Playlist.last_modified milliseconds since Unix epoch 2014-01-28 23:57:02 +01:00
Thomas Adamcik
dd98ad8353 audio: Update tests and dummy audio actor to pass 2014-01-28 23:19:33 +01:00
Thomas Adamcik
d1b91117b4 audio: Update dummy audio used for testing 2014-01-28 21:34:31 +01:00
Thomas Adamcik
0d18bdea79 audio: Add about to finish callback support 2014-01-27 23:43:11 +01:00
Thomas Adamcik
99d581f7fc audio: Add position_changed event to know when seeks happen 2014-01-27 23:04:15 +01:00
Thomas Adamcik
6490d5bd2d audio: Add more tests for audio events 2014-01-27 22:34:42 +01:00
Thomas Adamcik
a4315251ca audio: Slight test refactor to not hide what is going on 2014-01-26 23:30:12 +01:00
Thomas Adamcik
d962277bc9 audio: Add stream_changed event plus tests 2014-01-26 23:27:30 +01:00
Thomas Adamcik
f24ca36e5a mpd: Switch browse commands to common helper 2014-01-25 00:42:32 +01:00
Thomas Adamcik
3cec929bd7 Merge branch 'develop' into feature/mpd-tokenized-requests 
Conflicts:
	mopidy/mpd/protocol/music_db.py
	tests/mpd/protocol/test_music_db.py
 2014-01-24 19:38:56 +01:00
Thomas Adamcik
da724e6b77 Merge remote-tracking branch 'UncommonGoods/develop' into develop 2014-01-24 19:31:25 +01:00
Thomas Adamcik
e304b7fc2b mpd: Use mopidy.mpd.exceptions in commands 2014-01-24 01:12:26 +01:00
Thomas Adamcik
86f5602023 mpd: Remove old command handlers 2014-01-24 00:35:10 +01:00
Thomas Adamcik
dc8d311bc3 mpd: Complete music db conversion with list 2014-01-24 00:23:05 +01:00
Thomas Adamcik
68aa0b556c mpd: Convert search functions in music db 2014-01-23 23:58:42 +01:00
Stein Magnus Jodal
bf9499131a Bump version number to 0.18.1 2014-01-23 23:19:51 +01:00
Thomas Adamcik
8f8bed5b87 mpd: Implement playlistinfo from current playlist 2014-01-23 23:12:25 +01:00
Thomas Adamcik
fddb299ed9 mpd: Update type converters naming and add UINT 
Also adds tests for RANGE helper.
 2014-01-23 21:31:18 +01:00
Thomas Adamcik
eb85f92d96 mpd: Store auth required and if command should be listed 2014-01-22 23:27:25 +01:00
nathanharper
039fc4b681 refactored mpd.protocol.music_db regex 
got quote backreference working,
eliminated need for the non-capturing pattern,
fixed problem with quoted fields.
 2014-01-22 05:16:38 -05:00
Thomas Adamcik
066fed1522 mpd: Update tokenizer to use mopidy.mpd.exceptions 2014-01-22 00:10:30 +01:00
Thomas Adamcik
756cf1518b mpd: Add last missing error cases for tokenizer. 
If we decide that exact error message parity is not needed these can and should
be removed as they complicate the tokenizer.
 2014-01-21 23:20:24 +01:00
Thomas Adamcik
f7ec1fba01 mpd: Fix tokenizer error messages to match original protocol 2014-01-21 22:10:00 +01:00
Thomas Adamcik
f7aff706a8 mpd: Move commands tests to mpd directory 2014-01-21 21:14:30 +01:00
Thomas Adamcik
d445740318 mpd: Split out tokenizer and add proper errors. 2014-01-21 21:10:55 +01:00
Thomas Adamcik
335cf4e612 mpd: Return command name in find handler. 2014-01-21 20:40:49 +01:00
Thomas Adamcik
3c0cc1564c local: Make browse test check ordering again 2014-01-20 23:22:15 +01:00
Thomas Adamcik
9ba168e9b9 local: Update browse cache code to add all directories 
Tests have been updated to make sure multiple folders are added. We had
forgotten to add child folders to the ones that had already been created.
 2014-01-19 22:21:02 +01:00
Thomas Adamcik
455f3dd403 mpd: Write commands helper for tokenized command handling 
This provides a class which works as a command registry. Functions are added to
the registry through a method on the class `add`.  Add acts as a decorator
taking in the name of the command and optionally type converters for arguments.

When handling requests, we can now tokenize the line, and then just pass the
arguments to our commands helper. It will lookup the correct handler and apply
any validation before calling the original function.

For the sake of testing the original function is not wrapped. This the
functions, and anything testing them directly can simply assume pre-converted
data as long as type annotations are in place.

A sample usage would be:

    @protocol.commands.add('addid', position=protocol.integer)
    def addid(context, uri, position=None)
        pass

    def handle_request(line):
        tokens = protocol.tokenizer(line)
        context = ...
        result = protocol.commands.call(tokens, context=context)
 2014-01-19 19:59:07 +01:00
Thomas Adamcik
b34a8c1f73 mpd: Add MPD tokenizer 
- Adds tests for correctness of tokenizer (which also would have shown shlex
  wouldn't have worked).
- Should conform with the original's behavior, though we won't be able to match
  the error messages without a lot of extra work as a non-regexp version is
  likely a no go on python due to speed.
 2014-01-19 13:47:09 +01:00
Stein Magnus Jodal
1ea0978af5 dummy: Move dummy backend back into the mopidy package 2014-01-18 01:38:10 +01:00
Thomas Adamcik
e97e620635 local: Rename json test to new naming scheme 2014-01-18 01:35:33 +01:00
Stein Magnus Jodal
da71d7fb14 Merge pull request #647 from adamcik/feature/browse-by-uri 
Convert browse API to be fully URI based.
 2014-01-17 15:58:39 -08:00
Stein Magnus Jodal
31abe0bc93 mpd: Annotate exceptions with current command automatically (fixes #649) 2014-01-18 00:34:41 +01:00
Stein Magnus Jodal
06856851f7 local: Make search filters more robust (fixes #635) 2014-01-17 23:43:43 +01:00
Thomas Adamcik
43e16ddb65 mpd: Switch mpd to use path<->uri mapping for browsing 2014-01-17 17:16:24 +01:00
Thomas Adamcik
d6aa9fb013 local: Convert local browsing to uri based system. 2014-01-17 17:16:24 +01:00
Thomas Adamcik
999f478010 core: Update browse to use uri isntead of path 2014-01-17 17:16:24 +01:00
Thomas Adamcik
826419d829 backend/core: Switch to root_directory instead of name 2014-01-16 22:53:18 +01:00
Stein Magnus Jodal
300c5d2e64 Merge pull request #644 from adamcik/feature/scanner-tag-handling 
Cleanup taglist handling and translation to tracks.
 2014-01-15 15:10:26 -08:00
Stein Magnus Jodal
06719d0e66 Bump version to 0.18.0a1 for easier testing of updated extensions 2014-01-15 23:51:28 +01:00
Thomas Adamcik
81b920a9e4 model: Update to handle None in sets. 
Also adds some missing tests for composers and performers.
 2014-01-15 22:20:36 +01:00
Thomas Adamcik
3e9cd0c4b7 audio: Add tests for all fields that can be converted 2014-01-15 22:20:36 +01:00
Thomas Adamcik
ac9f106107 audio: Update how translator test data is built. 2014-01-15 22:20:36 +01:00
Thomas Adamcik
b0b5d4972f models: Make .copy(foo=None) null out field. 2014-01-15 22:20:36 +01:00
Thomas Adamcik
807bedad85 audio: Change audio data convert to operate on taglists 2014-01-15 22:20:36 +01:00
Thomas Adamcik
7209b38aa6 audio: Nest tags in scan data return value 2014-01-15 22:20:36 +01:00
Thomas Adamcik
57798a2757 audio: Ensure tests can be run on their own 2014-01-15 22:20:35 +01:00
Stein Magnus Jodal
d698653d83 mpd: Implement "listallinfo" command (fixes #145) 2014-01-15 01:11:27 +01:00
Stein Magnus Jodal
afbff12ccc mpd: Implement "listall" command 2014-01-15 00:52:01 +01:00
Stein Magnus Jodal
c781f77ef3 Rename test files to pattern expected by test runners 2014-01-15 00:01:50 +01:00
Stein Magnus Jodal
ead48f61cb Merge pull request #641 from jodal/feature/consistent-playback-events 
Make core playback events consistent
 2014-01-14 14:55:21 -08:00
Stein Magnus Jodal
c6cff2794c Merge pull request #640 from adamcik/feature/local-browse 
Add local browsing
 2014-01-14 14:43:31 -08:00
Thomas Adamcik
03838a1968 mpd: Add tests for adding VFS folders 2014-01-14 23:29:52 +01:00
Thomas Adamcik
a8458720ee local: Review fixes 2014-01-14 22:07:20 +01:00
Stein Magnus Jodal
1d108752f6 core: Make events emitted on playback consistent (fixes #629) 
This commit does not try to make the events correct/perfect with regard to
GStreamer states, end-of-stream signalling, etc. It only tries to make the
events work consistently across all the methods on the playback controller.

* play(track) while already playing has changed from:

  - playback_state_changed(old_state='playing', new_state='playing')
  - track_playback_started(track=...)

  to:

  - playback_state_changed(old_state='playing', new_state='stopped')
  - track_playback_ended(track=..., time_position=...)
  - playback_state_changed(old_state='stopped', new_state='playing')
  - track_playback_started(track=...)

* next() has changed from:

  - track_playback_ended(track=..., time_position=...)
  - playback_state_changed(old_state='playing', new_state='stopped')
  - track_playback_ended(track=..., time_position=0)
  - playback_state_changed(old_state='stopped', new_state='playing')
  - track_playback_started(track=...)

  to same as play() above.

* previous() has changed in the same way as next().

* on_end_of_track() has changed from:

  - track_playback_ended(track=..., time_position=...)
  - playback_state_changed(old_state='playing', new_state='playing')
  - track_playback_started(track=...)

  to same as play() above.

* stop() has reordered its events from:

  - track_playback_ended(track=..., time_position=...)
  - playback_state_changed(old_state='playing', new_state='stopped')

  to:

  - playback_state_changed(old_state='playing', new_state='stopped')
  - track_playback_ended(track=..., time_position=...)
 2014-01-14 01:18:39 +01:00
Thomas Adamcik
82584eb21a local: Add browser support for json library. 2014-01-13 23:43:55 +01:00
Stein Magnus Jodal
e071a161d6 Merge pull request #634 from sdbakker/enhancement/mixer-volume 
Mixer volume in config
 2014-01-13 13:27:51 -08:00
Stein Magnus Jodal
05632c3b8b backend: Update backend API imports 2014-01-11 18:20:45 +01:00
Stein Magnus Jodal
d724001f5b tests: Move mopidy.backends.dummy to tests.dummy_backend 2014-01-11 15:49:22 +01:00
Stein Magnus Jodal
2731d23578 local: Move mopidy.{backends => }.local 2014-01-11 15:17:05 +01:00
Simon de Bakker
ca35094554 Forgot to adapt tests for audio actor 2014-01-10 23:38:59 +01:00
Thomas Adamcik
cb97def432 Merge pull request #626 from jodal/feature/library-browse 
Library browsing support in backend and core API and MPD lsinfo command
 2014-01-09 13:20:40 -08:00
Thomas Adamcik
c51fdc68a2 Merge branch 'feature/extm3u' of https://github.com/tkem/mopidy into develop 
Conflicts:
	mopidy/backends/local/translator.py
 2014-01-09 22:14:29 +01:00
Stein Magnus Jodal
fe28311324 models: Use new Ref constructors 2014-01-09 08:54:33 +01:00
Stein Magnus Jodal
9da5ccbb79 models: Add type specific constructors to Ref 2014-01-09 08:50:31 +01:00
Stein Magnus Jodal
1fd1a38013 Merge branch 'develop' into feature/library-browse 
Conflicts:
	mopidy/backends/local/json/library.py
	mopidy/core/actor.py
	tests/backends/local/library_test.py
 2014-01-09 08:39:38 +01:00
Stein Magnus Jodal
28cf3228b2 Merge pull request #617 from adamcik/feature/extension-registry 
Switch to registry for most of mopidy extension hooks
 2014-01-08 23:32:06 -08:00
Thomas Adamcik
96eb9a87c6 mpd: Whitespace fix to make travis happy. 2014-01-09 00:41:46 +01:00
kingosticks
f2a26ef246 Fixed line length for flake 2014-01-08 23:04:38 +00:00
kingosticks
0d74be0b1e Empty MPD commands should return an error instead of OK, just like the original MPD server. Includes tests. 2014-01-06 12:33:20 +00:00
Stein Magnus Jodal
252f4792a0 core: Check if library is browsable at startup 2014-01-03 23:12:03 +01:00
Stein Magnus Jodal
69836d2e16 backend: Rename library.name to library.root_directory_name 2014-01-03 23:10:02 +01:00
Stein Magnus Jodal
af3b0e40fd models: Add Ref.type constants 2014-01-03 22:19:54 +01:00
Stein Magnus Jodal
048c3bb544 core: Use library name instead of URI scheme in browse() 2014-01-02 23:10:15 +01:00
Stein Magnus Jodal
7dba0dafa5 mpd: Include dirs and files in lsinfo response 2014-01-02 22:06:33 +01:00
Stein Magnus Jodal
6027ed1fac core: Add library.browse() 2014-01-02 22:06:33 +01:00
Stein Magnus Jodal
a3731c8187 backend: Add library.browse() 2014-01-02 22:06:32 +01:00
Thomas Adamcik
702befd6ae Merge branch 'develop' into feature/extension-registry 
Conflicts:
	setup.py
 2013-12-31 15:34:02 +01:00
Thomas Adamcik
29bb2d52b6 local: Re-add test for #500 fix. 2013-12-31 15:31:09 +01:00
Thomas Adamcik
e82ce6256d core: Re-add one uri scheme per backend constraint. 2013-12-31 14:45:57 +01:00
Stein Magnus Jodal
4b9ab5fcbc Remove empty "frontends" packages 2013-12-31 14:14:19 +01:00
Stein Magnus Jodal
1ee534126e mpd: Move mopidy.{frontends => }.mpd 2013-12-31 14:11:16 +01:00
Stein Magnus Jodal
621aff22c9 http: Move mopidy.{frontends => }.http 2013-12-31 14:04:25 +01:00
Thomas Adamcik
60112d7c6f Merge branch 'develop' into feature/extension-registry 2013-12-30 00:37:17 +01:00
Stein Magnus Jodal
e87d5729e3 models: Add lightweight Ref model with URI, name, and type 2013-12-29 19:31:14 +01:00
Thomas Adamcik
d93d3e6fcd local: Add local/library config value 
- Updated library provider to support missing library
- Added config value to select local library provider
- Updated tests to use library config value
 2013-12-24 00:22:58 +01:00
Thomas Adamcik
e065f349db local: Add local library provider back 
- Re-add a local library provider that uses our new library interface
- Re-add our json library using the new interface
- Hardcode these to use each other for now
- Scanner bit is still missing, will re-add in one of the next commits
- Bypassed test for #500 for the time being
 2013-12-23 23:43:04 +01:00
Thomas Adamcik
353782e2c8 local: Add local/data_dir config value. 
Not in use yet but, needed for future changes planed in this branch.
 2013-12-23 21:40:35 +01:00
Stein Magnus Jodal
3859448e06 core: Test version property, fix typo in changelog 2013-12-15 22:49:33 +01:00
Thomas Kemmer
9bf7e39425 fix flake8 error E302 2013-12-10 06:57:16 +01:00
Thomas Kemmer
584dc1eaf6 add playlists test for writing EXTM3U files 2013-12-09 16:13:05 +01:00
Thomas Kemmer
18c44e0d8a add translator tests for EXTM3U files 2013-12-09 15:54:28 +01:00
Thomas Kemmer
b6ee1707d3 add translator tests for EXTM3U files 2013-12-09 15:52:46 +01:00
Thomas Kemmer
a5c02c1034 basic EXTM3U playlist support 2013-12-08 15:23:23 +01:00
Thomas Adamcik
9c2d38e989 local: Remove tag cache support 
- Updates doc references to tag cache
- Removes tag cache from config and marks it deprecated
- Removes tag cache from setup.py
- Removes tag cache from config converter
- Removes tag cache from tests
- Converts local library tests to use JSON.
 2013-12-04 22:38:16 +01:00
Thomas Adamcik
da63942b48 config: Improve handling of Deprecated config values 2013-12-04 22:38:16 +01:00
Thomas Adamcik
26ec956a08 config: Add deprecated config value support. 
This makes it possible to mark a key as deprecated, this implies it will be
ignored if present, and never included in the resulting config.
 2013-11-29 00:15:03 +01:00
Thomas Adamcik
3bbcb4d121 local: Review comment fixes 2013-11-28 23:20:03 +01:00
Thomas Adamcik
603b57ef3c utils: Remove find_uris and update find_files 
- find_uris is no more
- find_files now returns file paths relative to path being searched
- find_files now only works on directories
- find_files tests have been updated to reflect changes
- local scanner has gotten a minimal update to reflect this alteration
 2013-11-27 22:50:35 +01:00
Thomas Adamcik
c025b87076 tagcache: Split out to own extension for eventual deletion. 2013-11-27 00:04:51 +01:00
Thomas Adamcik
04044d035f core: Refactor core Backends helper 
Replaces the jungle of extra dicts/lists with an OrderedDict per backend
feature type. Also makes sure that each type/scheme is unique instead of
the scheme alone.
 2013-11-27 00:04:51 +01:00
Thomas Adamcik
ff9f473c2f local: Move tag cache translators and tests out. 2013-11-26 17:47:52 +01:00
Thomas Adamcik
774e629425 config: Fix review comments. 2013-11-23 07:18:57 +01:00
Thomas Adamcik
b22d7bee0b utils: Add mkdir and content options to get_or_create_file 
This lets callers control is parent directories are created, and set the
default content of the file.
 2013-11-22 07:17:02 +01:00
Stein Magnus Jodal
8ea996de13 Revert "tests: Don't redefine PYTHONPATH" 
This reverts commit 6be5cc0f1b.
 2013-11-20 23:13:31 +01:00
Stein Magnus Jodal
6be5cc0f1b tests: Don't redefine PYTHONPATH 
Shot in the dark to get Travis to find dbus-python when running the `mopidy`
command as a subprocess of the tests.
 2013-11-20 22:40:12 +01:00
Stein Magnus Jodal
b0cffb8681 mpd: Move query_from_mpd_search_format into only module using it 2013-11-17 16:00:15 +01:00
Thomas Adamcik
03c301705d commands: Move mopidy.utils.command to mopidy.commands 
- Also adds documenation to Command class.
- Moves scan command to commands to match naming.
 2013-11-16 03:02:45 +01:00
Thomas Adamcik
2f6ecd9171 commands: Move to using a help attribute instead of __doc__ 2013-11-16 02:26:47 +01:00
Thomas Adamcik
37ba3ca01d Merge branch 'develop' into feature/commands-helper-tmp 
Conflicts:
	mopidy/utils/log.py
 2013-11-14 23:36:27 +01:00
Thomas Adamcik
c0f1a1352b commands: Replace set_defaults with set method 
For our use case we only need to be able to override a value, not set defaults
so this simplifies everything.
 2013-11-14 23:31:20 +01:00
Thomas Adamcik
39f7fd5955 commands: Extend use of exit helper to parser errors 
This moves all the bad arugment handling into our class and makes sure to mark
all the helpers as internal.
 2013-11-14 23:31:20 +01:00
Thomas Adamcik
d82f48a42f commands: Internalise handling of help action 
This means help will always be handled by the root command. Additionally this
adds an exit helper.
 2013-11-14 23:31:20 +01:00
Thomas Adamcik
0b1b249ae8 commands: Remove trailing newline for command errors 2013-11-14 23:31:20 +01:00
Thomas Adamcik
1394f3929b commands: Add run method to Commands 2013-11-14 23:31:20 +01:00
Thomas Adamcik
f5a5f9e9b1 commands: Add str method CommandError 2013-11-14 23:31:20 +01:00
Thomas Adamcik
b5360a1360 commands: Add usage to CommandError 2013-11-14 23:31:20 +01:00
Thomas Adamcik
001c8e0bdc commands: Add set_defaults() to the parser 
- Removes mock based test that checks delegation, just check commands result
- Allow setting of defaults that propegate down the chain
- Move internal parser args to a _parse helper.
 2013-11-14 23:31:20 +01:00
Thomas Adamcik
6bddcb7875 commands: Add help_formatter() with tests. 2013-11-14 23:31:20 +01:00
Thomas Adamcik
88bc046605 commands: Make sure parser errors get translated to correct error type. 2013-11-14 23:31:20 +01:00
Thomas Adamcik
fa7eee3bdf commands: Add basic format usage helper 2013-11-14 23:31:20 +01:00
Thomas Adamcik
754865d8b6 commands: Set child names upon adding them 2013-11-14 23:31:20 +01:00
Thomas Adamcik
7c82485a07 commands: Start adding commands util helper. 
This class is intended to be used to contruct a tree of sub-commands. In this
intial version it mainly focuses on exposing `add_argument` to allow for nested
parsers. Next step is to start adding better `--help` that shows the entire tree
and hooking it up to select what code path to really run.
 2013-11-14 23:31:20 +01:00
Lasse Bigum
f5e94d8f7c Address review comments 2013-11-13 00:40:47 +01:00
Lasse Bigum
9ba5f6862f Merge branch 'develop' of https://github.com/mopidy/mopidy into feature/extra_tags 2013-11-13 00:23:44 +01:00
Stein Magnus Jodal
04788abaac core: Change tracklist.{filter,remove} usage 
The criterias are now a mapping between field names and one or more values.
This aligns tracklist.{filter,remove} with the API of
library.{find_exact,search}, and allows for e.g. batch removals.

An exception is raised immediately if the API is used in the old way to ease
migration and debugging.
 2013-11-12 00:00:22 +01:00
Stein Magnus Jodal
4e7c2bab4d Merge branch 'develop' into feature/filter_improvement 2013-11-11 23:18:23 +01:00
Stein Magnus Jodal
a289d831d0 Merge pull request #569 from ZenithDK/scan_multiple_artist 
Fix scan with multiple track artists and add tests
 2013-11-11 14:07:36 -08:00
Stein Magnus Jodal
924553b62e http: Fix tests 2013-11-11 22:40:45 +01:00
Lasse Bigum
2bd1f043ce Updated code with new multiple artist handling and added tests 2013-11-09 03:01:53 +01:00
Lasse Bigum
8b7621c3e3 Merge branch 'develop' of https://github.com/mopidy/mopidy into feature/extra_tags 2013-11-09 02:37:44 +01:00
Lasse Bigum
c776565f65 Another round of review comments 2013-11-09 01:22:27 +01:00
Lasse Bigum
093c0400a9 Fix review comments 2013-11-08 21:43:31 +01:00
Lasse Bigum
03750a8bf2 Fix scan with multiple track artists and add tests 2013-11-08 21:25:21 +01:00
Thomas Adamcik
9539c2ac35 main: Switch to subcommands 
- show-deps replaced with 'mopidy deps'
- show-config replaced with 'mopidy config'
- Just running mopidy now displays help, run 'mopidy run' to start server.
 2013-11-08 19:53:00 +01:00
Javier Domingo Cansino
6721a59b26 tests: Fixing self confusion mistake 
docs: Documenting tracklist's new filter() feature
 2013-11-07 09:46:34 +01:00
Javier Domingo Cansino
8b5f30e5ff Adding test case 2013-11-07 09:34:40 +01:00
Thomas Adamcik
469f414c4c audio: Don't do duration conversion to ms in scanner 2013-11-06 19:10:49 +01:00
Thomas Adamcik
20b0602842 audio/scanner: Move translator into audio. 
Tries to move more of the gst bits and pieces we are leaking into audio.
 2013-11-06 19:10:49 +01:00
Thomas Adamcik
0a2d74eff1 scanner: Update to use new mopidy.audio.scan 
Also adds the check less than 100ms check back to the scanner.
 2013-11-06 19:10:49 +01:00
Lasse Bigum
af6225538d Add more tests 2013-11-05 23:17:15 +01:00
Lasse Bigum
9d7db4cf4f Add frontend MPD tests for 'search comment "foo"' 2013-11-03 01:52:34 +01:00
Lasse Bigum
a516d2051d Added a ton of extra tests and expanded a few to include new tags 2013-11-03 01:01:42 +01:00
Lasse Bigum
f90f5f608e Fix testcases after merging mopidy/develop 2013-11-02 23:44:33 +01:00
Lasse Bigum
e12a75c880 Merge branch 'develop' of https://github.com/mopidy/mopidy into feature/extra_tags 2013-11-02 23:39:19 +01:00
Lasse Bigum
9593da08b6 Rename track in MPD to track_name to avoid confusion 2013-11-02 22:34:26 +01:00
Stein Magnus Jodal
838f584e2b local: Formatting 2013-11-02 22:18:37 +01:00
Stein Magnus Jodal
b0d43444c2 local: Remove debug logging in tests 2013-11-02 22:18:26 +01:00
Lasse Bigum
f295cbd3cb Fix flake8 issues 2013-11-02 22:14:25 +01:00
Lasse Bigum
24944bd8e3 Split artist and albumartist dependency, update tests based on this 2013-11-02 22:13:54 +01:00
Lasse Bigum
86f18935fe Fix flake8 errors and add a few more tests 2013-11-02 21:57:53 +01:00
Lasse Bigum
fd213f2d78 Add tests for albumartist 2013-11-02 21:57:53 +01:00
Lasse Bigum
e7746dac1b Remove debug, make track_no more robust 2013-11-02 21:54:46 +01:00
Lasse Bigum
efc9fc75b5 Fix track_no 2013-11-02 21:49:44 +01:00
Stein Magnus Jodal
04d9fa667b deps: Don't strip last dir from dependency path 2013-11-02 19:25:06 +01:00
Lasse Bigum
2bbd9003a2 Date is not mandatory AFAICT 2013-11-02 03:07:13 +01:00
Lasse Bigum
df1820f0a7 Add genre, composer, and performer tags and use them 2013-11-02 02:29:37 +01:00
Stein Magnus Jodal
c3a9bc06ed Bump version for development 2013-10-27 22:44:10 +01:00
Stein Magnus Jodal
9064fc02fd Merge branch 'develop' into feature/mpd-search-by-albumartist 
Conflicts:
	mopidy/frontends/mpd/protocol/music_db.py
	mopidy/frontends/mpd/translator.py
 2013-10-27 21:30:58 +01:00
Stein Magnus Jodal
be6e6c9a93 local: Readd lost test assertion 2013-10-27 21:26:26 +01:00
Stein Magnus Jodal
c42dd1bf1d mpd: Add 'find track ""' test to match search tests 2013-10-27 21:23:45 +01:00
Stein Magnus Jodal
d13d9958b0 mpd: Formatting 2013-10-27 21:22:57 +01:00